From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78A2DEB64DD for ; Mon, 14 Aug 2023 10:34:20 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.583530.913756 (Exim 4.92) (envelope-from ) id 1qVUtW-0000mF-GU; Mon, 14 Aug 2023 10:33:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 583530.913756; Mon, 14 Aug 2023 10:33:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qVUtW-0000m8-E2; Mon, 14 Aug 2023 10:33:54 +0000 Received: by outflank-mailman (input) for mailman id 583530; Mon, 14 Aug 2023 10:33:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qVUtV-0000m2-LD for xen-devel@lists.xenproject.org; Mon, 14 Aug 2023 10:33:53 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f867d50-3a8e-11ee-b288-6b7b168915f2; Mon, 14 Aug 2023 12:33:51 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 3EF4B4EE0737; Mon, 14 Aug 2023 12:33:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f867d50-3a8e-11ee-b288-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 14 Aug 2023 12:33:51 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 3/6] x86/vm_event: add missing include In-Reply-To: <30d1ef98-d847-b0ca-6771-4bc0abcdb214@suse.com> References: <30d1ef98-d847-b0ca-6771-4bc0abcdb214@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <808999f0142825bebfdbe16a309d529f@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 14/08/2023 09:39, Jan Beulich wrote: > On 11.08.2023 09:19, Nicola Vetrini wrote: >> The missing header included by this patch provides declarations for >> the functions >> 'vm_event_{fill_regs,set_registers,monitor_next_interrupt}' >> that are defined in the source file. This also resolves violations >> of MISRA C:2012 Rule 8.4. >> >> Signed-off-by: Nicola Vetrini >> Fixes: adc75eba8b15 ("x86/vm_event: consolidate hvm_event_fill_regs >> and p2m_vm_event_fill_regs") >> Fixes: 975efd3baa8d ("introduce VM_EVENT_FLAG_SET_REGISTERS") >> Fixes: 9864841914c2 ("x86/vm_event: add support for >> VM_EVENT_REASON_INTERRUPT") > > It's hard to see how it can be three commit here. The oldest one is at > fault, I would say. Since the patch is concerned with more than one function then in a sense I agree with you (the headers should have been included in the proper way the first time around), but then more definitions have been added by adc75eba8b15 and 9864841914c2, and these should have triggered a refactoring too. I can leave just 975efd3baa8d in the Fixes if the preferred way is to list just the first problematic commit (perhaps with a little explanation after --- ). > > Also please remember to Cc maintainers. Yes, sorry. I must have forgotten to run add_maintainers. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)