All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v5 0/2] clean up interrupt handle
Date: Tue, 04 Apr 2017 16:50:01 +0200	[thread overview]
Message-ID: <8091532.IGg7nCNBxL@xps13> (raw)
In-Reply-To: <20170404222732.981-1-qi.z.zhang@intel.com>

2017-04-05 06:27, Qi Zhang:
> It seems its not necessary to register an intr_handle for interrupt callback
> function. "void* cb_arg" shows enough when be used to pass the object that
> contain the information be required to handle the interrupt event( A typical
> way which is implemented by almost all driver is by passing a rte_ethdev
> instance).
> The patch change the prototype of rte_intr_callback_fn by removing
> the uncessary intr_handle paramter.
> 
> v5:
> 
> - Update mlx4 driver which is missed in previous version.
> 
> v4:
> 
> - Update mlx5 driver which is missed in v1, v2, v3.
> - Add back patch 1 of v2 to make this complete though it already be applied.
> - Remove patch 3 which is not necessary with latest master.

Why have you removed patch 3?

There is this error now:

test/test/test_interrupts.c:217:4: fatal error:
incompatible pointer types passing 'void (struct rte_intr_handle *, void *)'
to parameter of type 'rte_intr_callback_fn' (aka 'void (*)(void *)')
[-Wincompatible-pointer-types]
                        test_interrupt_callback, arg) >= 0) {

  reply	other threads:[~2017-04-04 14:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31  2:09 [PATCH v3 0/2] clean up interrupt handle Qi Zhang
2017-03-31  2:09 ` [PATCH v3 1/2] eal: " Qi Zhang
2017-03-31  2:09 ` [PATCH v3 2/2] app/test: update test code Qi Zhang
2017-04-04 10:12 ` [PATCH v3 0/2] clean up interrupt handle Thomas Monjalon
2017-04-04 12:41   ` Zhang, Qi Z
2017-04-04 21:21 ` [PATCH v4 " Qi Zhang
2017-04-04 21:21   ` [PATCH v4 1/2] vfio: keep interrupt source read only Qi Zhang
2017-04-04 21:21   ` [PATCH v4 2/2] eal: clean up interrupt handle Qi Zhang
2017-04-04 13:54     ` Shahaf Shuler
2017-04-04 14:23       ` Zhang, Qi Z
2017-04-04 22:27   ` [PATCH v5 0/2] " Qi Zhang
2017-04-04 14:50     ` Thomas Monjalon [this message]
2017-04-04 14:58       ` Zhang, Qi Z
2017-04-04 22:27     ` [PATCH v5 1/2] vfio: keep interrupt source read only Qi Zhang
2017-04-04 22:27     ` [PATCH v5 2/2] eal: clean up interrupt handle Qi Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8091532.IGg7nCNBxL@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.