From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkFb3-0005fI-TR for qemu-devel@nongnu.org; Wed, 14 Sep 2016 15:11:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkFax-0006qt-V1 for qemu-devel@nongnu.org; Wed, 14 Sep 2016 15:11:48 -0400 References: <1473878907-10477-1-git-send-email-lvivier@redhat.com> <1473878907-10477-3-git-send-email-lvivier@redhat.com> From: Eric Blake Message-ID: <80ae56d7-c57d-6afa-bdb2-cf2dd43cedfd@redhat.com> Date: Wed, 14 Sep 2016 14:11:41 -0500 MIME-Version: 1.0 In-Reply-To: <1473878907-10477-3-git-send-email-lvivier@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3Li3LJojFi0ER7WGxhDhw0ssPwtVsBvBO" Subject: Re: [Qemu-devel] [PATCH 2/5] spapr_rtas: convert to trace framework instead of DPRINTF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , david@gibson.dropbear.id.au Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3Li3LJojFi0ER7WGxhDhw0ssPwtVsBvBO From: Eric Blake To: Laurent Vivier , david@gibson.dropbear.id.au Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org Message-ID: <80ae56d7-c57d-6afa-bdb2-cf2dd43cedfd@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/5] spapr_rtas: convert to trace framework instead of DPRINTF References: <1473878907-10477-1-git-send-email-lvivier@redhat.com> <1473878907-10477-3-git-send-email-lvivier@redhat.com> In-Reply-To: <1473878907-10477-3-git-send-email-lvivier@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/14/2016 01:48 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > hw/ppc/spapr_rtas.c | 30 ++++++++---------------------- > hw/ppc/trace-events | 9 +++++++++ > 2 files changed, 17 insertions(+), 22 deletions(-) >=20 > +++ b/hw/ppc/trace-events > @@ -57,6 +57,15 @@ spapr_drc_realize_child(uint32_t index, char *childn= ame) "drc: 0x%"PRIx32", chil > spapr_drc_realize_complete(uint32_t index) "drc: 0x%"PRIx32 > spapr_drc_unrealize(uint32_t index) "drc: 0x%"PRIx32 > =20 > +# hw/ppc/spapr_rtas.c > + > +spapr_rtas_set_indicator_invalid(uint32_t index) "sensor index: 0x%"PR= Ix32 Same comment about extra newline as on 1/5 (and probably for the whole series); otherwise: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3Li3LJojFi0ER7WGxhDhw0ssPwtVsBvBO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX2aDtAAoJEKeha0olJ0NqjxAIAINpiO+QLhdujtviHENfPXeX 6lcy3HhQhawSYuiQPsiVfb35vvUaXkAGHFd9bKG4XTtRed2OxgIMAgsBuslEvQN0 ekiO023XJw31qH8PdlPwBafJJy6OHTRC6LFpYWp6WezSxPz0JbBqPNZc38GwNoV9 QqEvY9qp8XI4S+X9wZCYpn/pnEEWjlPMxqXkH86BWJDA1FVgw7jNJ5mMTkeBCCbt Sk69PKSa58TbYNYDYu4GXhJj2r5/FN75bWIN7Scgl6wUyGyFJ3eQW+rTJ7BIegyN PQ4fCYqr1bRUKNBmmJtENL29sozqo79IxsAEa94OWGoih8AaOv7ECt47jp3MoCY= =RhOQ -----END PGP SIGNATURE----- --3Li3LJojFi0ER7WGxhDhw0ssPwtVsBvBO--