From: okaya@codeaurora.org
To: Huacai Chen <chenhc@lemote.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
James Hogan <james.hogan@mips.com>,
Linux MIPS Mailing List <linux-mips@linux-mips.org>,
Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
stable <stable@vger.kernel.org>,
chenhuacai@gmail.com
Subject: Re: [PATCH] MIPS: io: Add barrier after register read in inX()
Date: Mon, 23 Apr 2018 07:58:39 -0400 [thread overview]
Message-ID: <80ba8c398092f2570dee009504faafed@codeaurora.org> (raw)
In-Reply-To: <CAAhV-H6R8=59WLEOHRNhMHvNsrZXUZnShr94BfCY2xhgZZj7+Q@mail.gmail.com>
On 2018-04-23 00:51, Huacai Chen wrote:
> Your patch add rmb() before read in readX(), why inX() need rmb() after
> read?
>
I had to double check what ioswab macro does.
/*
* Raw operations are never swapped in software. OTOH values that raw
* operations are working on may or may not have been swapped by the bus
* hardware. An example use would be for flash memory that's used for
* execute in place.
*/
# define __raw_ioswabb(a, x) (x)
# define __raw_ioswabw(a, x) (x)
# define __raw_ioswabl(a, x) (x)
# define __raw_ioswabq(a, x) (x)
# define ____raw_ioswabq(a, x) (x)
/* ioswab[bwlq], __mem_ioswab[bwlq] are defined in mangle-port.h */
So, neither my patch nor yours places rmb before read.
Both are placing it after read and it is the right thing.
ioswab is just an endianness conversion macro.
> Huacai
>
> On Mon, Apr 23, 2018 at 12:31 PM, <okaya@codeaurora.org> wrote:
>> On 2018-04-22 23:53, Huacai Chen wrote:
>>>
>>> While a barrier is present in the outX() functions before the
>>> register
>>> write, a similar barrier is missing in the inX() functions after the
>>> register read. This could allow memory accesses following inX() to
>>> observe stale data.
>>>
>>> This patch is very similar to commit a1cc7034e33d12dc1 ("MIPS: io:
>>> Add
>>> barrier after register read in readX()"). Because
>>> war_io_reorder_wmb()
>>> is both used by writeX() and outX(), if readX() need a barrier then
>>> so
>>> does inX().
>>>
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Huacai Chen <chenhc@lemote.com>
>>> ---
>>> arch/mips/include/asm/io.h | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h
>>> index a7d0b83..cea8ad8 100644
>>> --- a/arch/mips/include/asm/io.h
>>> +++ b/arch/mips/include/asm/io.h
>>> @@ -414,6 +414,8 @@ static inline type pfx##in##bwlq##p(unsigned long
>>> port) \
>>> __val = *__addr;
>>> \
>>> slow;
>>> \
>>>
>>> \
>>> + /* prevent prefetching of coherent DMA data prematurely */
>>> \
>>> + rmb();
>>> \
>>> return pfx##ioswab##bwlq(__addr, __val);
>>> \
>>> }
>>
>>
>> Typically read barrier is applied after register read.
prev parent reply other threads:[~2018-04-23 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 3:53 [PATCH] MIPS: io: Add barrier after register read in inX() Huacai Chen
2018-04-23 4:31 ` okaya
2018-04-23 4:51 ` Huacai Chen
2018-04-23 11:58 ` okaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ba8c398092f2570dee009504faafed@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=james.hogan@mips.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.