From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: RE: [PATCH 2/2] ARM: Make CONFIG_FPE_NWFPE depend on !CONFIG_THUMB2_KERNEL Date: Fri, 4 Feb 2011 16:17:07 +0530 Message-ID: <80d490aede945bdbb95cbf073cb9d846@mail.gmail.com> References: <1291895982-4775-1-git-send-email-dave.martin@linaro.org> <1291895982-4775-3-git-send-email-dave.martin@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from na3sys009aog114.obsmtp.com ([74.125.149.211]:37431 "EHLO na3sys009aog114.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858Ab1BDKra (ORCPT ); Fri, 4 Feb 2011 05:47:30 -0500 Received: by ywj3 with SMTP id 3so950013ywj.14 for ; Fri, 04 Feb 2011 02:47:09 -0800 (PST) In-Reply-To: <1291895982-4775-3-git-send-email-dave.martin@linaro.org> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Dave Martin , linux-arm-kernel@lists.infradead.org Cc: linux-omap@vger.kernel.org > -----Original Message----- > From: Dave Martin [mailto:dave.martin@linaro.org] > Sent: Thursday, December 09, 2010 5:30 PM > To: linux-arm-kernel@lists.infradead.org > Cc: Dave Martin; Santosh Shilimkar; linux-omap@vger.kernel.org > Subject: [PATCH 2/2] ARM: Make CONFIG_FPE_NWFPE depend on > !CONFIG_THUMB2_KERNEL > > Because the nwfpe support is unlikely to be used on new platforms > and requires CONFIG_OABI_COMPAT, which is not generally used with > ARMv7+, we shouldn't expect to build nwfpe support into a Thumb-2 > kernel. > > At present, nwfpe contains assembly code which isn't Thumb-2 > compatible, and for now it doesn't appear useful to port this > code. > > All ARMv7-A/R platforms necessarily have VFPv3 hardware floating- > point natively, making emulation unnecessary. > > Signed-off-by: Dave Martin > Acked-by: Catalin Marinas > --- Acked-by: Santosh Shilimkar ` > arch/arm/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index f9ca7f3..7e825c3 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1759,7 +1759,7 @@ comment "At least one emulation must be > selected" > > config FPE_NWFPE > bool "NWFPE math emulation" > - depends on !AEABI || OABI_COMPAT > + depends on (!AEABI || OABI_COMPAT) && !THUMB2_KERNEL > ---help--- > Say Y to include the NWFPE floating point emulator in the > kernel. > This is necessary to run most binaries. Linux does not > currently > -- > 1.7.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Fri, 4 Feb 2011 16:17:07 +0530 Subject: [PATCH 2/2] ARM: Make CONFIG_FPE_NWFPE depend on !CONFIG_THUMB2_KERNEL In-Reply-To: <1291895982-4775-3-git-send-email-dave.martin@linaro.org> References: <1291895982-4775-1-git-send-email-dave.martin@linaro.org> <1291895982-4775-3-git-send-email-dave.martin@linaro.org> Message-ID: <80d490aede945bdbb95cbf073cb9d846@mail.gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > -----Original Message----- > From: Dave Martin [mailto:dave.martin at linaro.org] > Sent: Thursday, December 09, 2010 5:30 PM > To: linux-arm-kernel at lists.infradead.org > Cc: Dave Martin; Santosh Shilimkar; linux-omap at vger.kernel.org > Subject: [PATCH 2/2] ARM: Make CONFIG_FPE_NWFPE depend on > !CONFIG_THUMB2_KERNEL > > Because the nwfpe support is unlikely to be used on new platforms > and requires CONFIG_OABI_COMPAT, which is not generally used with > ARMv7+, we shouldn't expect to build nwfpe support into a Thumb-2 > kernel. > > At present, nwfpe contains assembly code which isn't Thumb-2 > compatible, and for now it doesn't appear useful to port this > code. > > All ARMv7-A/R platforms necessarily have VFPv3 hardware floating- > point natively, making emulation unnecessary. > > Signed-off-by: Dave Martin > Acked-by: Catalin Marinas > --- Acked-by: Santosh Shilimkar ` > arch/arm/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index f9ca7f3..7e825c3 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1759,7 +1759,7 @@ comment "At least one emulation must be > selected" > > config FPE_NWFPE > bool "NWFPE math emulation" > - depends on !AEABI || OABI_COMPAT > + depends on (!AEABI || OABI_COMPAT) && !THUMB2_KERNEL > ---help--- > Say Y to include the NWFPE floating point emulator in the > kernel. > This is necessary to run most binaries. Linux does not > currently > -- > 1.7.1