Re: [OE-core] [PATCH v3 1/3] systemd-boot-native: undelete but disable configure and compile tasks

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2025-02-04 at 16:17 +0200, Mikko Rapeli via
lists.openembedded.org wrote:
> The tasks were deleted and do_patch() was run after do_install()
> which means that patches applied in SRC_URI were not in the
> ukify.py binary installed. Mark the tasks as noexec since
> they don't need to do anything.
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> ---
>  meta/recipes-core/systemd/systemd-boot-native_257.1.bb | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
> b/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
> index 58db408dcf..5b4b63c294 100644
> --- a/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
> +++ b/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
> @@ -2,13 +2,12 @@ require systemd.inc
>  
>  inherit native
>  
> -deltask do_configure
> -deltask do_compile
> +do_configure[noexec] = "1"
> +do_compile[noexec] = "1"
>  
>  do_install () {
>         install -Dm 0755 ${S}/src/ukify/ukify.py ${D}${bindir}/ukify
>  }
> -addtask install after do_unpack

I'm a little torn on this, we could fix it by changing do_unpack to
do_patch.

Using deltask is slightly more efficient in that it completely removes
a a node on the task graph rather than having it present and running
all the way up to just short of execution.

Cheers,

Richard