From: Jan Beulich <jbeulich@suse.com>
To: Nicola Vetrini <nicola.vetrini@bugseng.com>
Cc: sstabellini@kernel.org, michal.orzel@amd.com,
xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com,
consulting@bugseng.com,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [XEN PATCH v2 5/5] x86: refactor macros in 'xen-mca.h'
Date: Tue, 8 Aug 2023 14:06:50 +0200 [thread overview]
Message-ID: <80ead475-68cd-0cf3-3d2e-252ad4b1f976@suse.com> (raw)
In-Reply-To: <9eea3e6039a72d0502ed1416449e041a@bugseng.com>
On 08.08.2023 14:02, Nicola Vetrini wrote:
> On 08/08/2023 13:08, Nicola Vetrini wrote:
>> The macros defined 'xen/include/public/arch-x86/xen-mca.h' are revised
>> to address the following concerns:
>> - needless underscore prefixes for parameter names;
>> - the variable 'i' in function 'mce_action' that is shadowed
>> by the local variable in the macro.
>>
>> Therefore, the refactoring aims to resolve present shadowing
>> issues, which violate MISRA C:2012 Rule 5.3, and lessen the
>> probability of future ones with some renames.
>>
>> No functional change.
>>
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
>> ---
>> Changes in v2:
>> - Added missing parentheses.
This ...
>> - Clarified commit message.
>> ---
>
> Missing a
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> from the other version, since nothing changed code-wise.
... isn't exactly "nothing", but well.
Jan
next prev parent reply other threads:[~2023-08-08 12:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 11:08 [XEN PATCH v2 0/5] x86: address MISRA C:2012 Rule 5.3 Nicola Vetrini
2023-08-08 11:08 ` [XEN PATCH v2 1/5] " Nicola Vetrini
2023-08-08 13:46 ` Jan Beulich
2023-08-09 7:32 ` Nicola Vetrini
2023-08-08 11:08 ` [XEN PATCH v2 2/5] xen/delay: " Nicola Vetrini
2023-08-08 13:56 ` Jan Beulich
2023-08-08 13:57 ` Jan Beulich
2023-08-08 11:08 ` [XEN PATCH v2 3/5] x86/include: " Nicola Vetrini
2023-08-08 14:01 ` Jan Beulich
2023-08-08 11:08 ` [XEN PATCH v2 4/5] x86/xstate: " Nicola Vetrini
2023-08-08 14:03 ` Jan Beulich
2023-08-08 11:08 ` [XEN PATCH v2 5/5] x86: refactor macros in 'xen-mca.h' Nicola Vetrini
2023-08-08 12:02 ` Nicola Vetrini
2023-08-08 12:06 ` Jan Beulich [this message]
2023-08-08 14:46 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ead475-68cd-0cf3-3d2e-252ad4b1f976@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ayan.kumar.halder@amd.com \
--cc=consulting@bugseng.com \
--cc=michal.orzel@amd.com \
--cc=nicola.vetrini@bugseng.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xenia.ragiadakou@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.