From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 27 Mar 2003 19:07:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 27 Mar 2003 19:07:04 -0500 Received: from [218.44.239.73] ([218.44.239.73]:40100 "EHLO oris.opensource.gr.jp") by vger.kernel.org with ESMTP id ; Thu, 27 Mar 2003 19:07:01 -0500 Date: Fri, 28 Mar 2003 09:18:03 +0900 Message-ID: <80k7ekgx8k.wl@oris.opensource.jp> From: GOTO Masanori To: Adrian Bunk Cc: YOKOTA Hiroshi , GOTO Masanori , Marcelo Tosatti , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [patch] fix nsp32.c .text.exit error In-Reply-To: <20030327221410.GE24744@fs.tum.de> References: <20030327221410.GE24744@fs.tum.de> User-Agent: Wanderlust/2.9.9 (Unchained Melody) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/21.2 (i386-debian-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 27 Mar 2003 23:14:11 +0100, Adrian Bunk wrote: > In drivers/scsi/nsp32.c the function nsp32_remove is __devexit but the > pointer to it isn't __devexit_p resulting in a .text.exit compile error > if !CONFIG_HOTPLUG. > > The following patch is needed: > > --- linux-2.4.21-pre6-full-nohotplug/drivers/scsi/nsp32.c.old 2003-03-27 22:35:04.000000000 +0100 > +++ linux-2.4.21-pre6-full-nohotplug/drivers/scsi/nsp32.c 2003-03-27 22:36:14.000000000 +0100 > @@ -2125,7 +2125,7 @@ > .name = "nsp32", > .id_table = nsp32_pci_table, > .probe = nsp32_probe, > - .remove = nsp32_remove, > + .remove = __devexit_p(nsp32_remove), > #ifdef CONFIG_PM > /* .suspend = nsp32_suspend,*/ > /* .resume = nsp32_resume,*/ > > > This patch applies against 2.4.21-pre6 and 2.5.66. I've tested the > compilation with 2.4.21-pre6. Looks fine. Thanks! Regards, -- gotom