From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Lee Jones <lee.jones@linaro.org>, "'Chris Ball'" <cjb@laptop.org>
Cc: Jingoo Han <jg1.han@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
"'Laurent Pinchart'" <laurent.pinchart+renesas@ideasonboard.com>,
"'Guennadi Liakhovetski'" <g.liakhovetski@gmx.de>
Subject: Re: [PATCH 1/5] mfd: asic3: Remove .set_pwr() callback
Date: Wed, 28 Aug 2013 09:51:15 +0200 [thread overview]
Message-ID: <81053150.gZpPo7ioCr@avalon> (raw)
In-Reply-To: <20130828074126.GD10210@lee--X1>
Hi Lee,
(Dropping Ian Molton <ian.molton@collabora.co.uk> from the CC list as the e-
mail address isn't valid anymore)
On Wednesday 28 August 2013 08:41:26 Lee Jones wrote:
> > > Since 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from
> > > platform data", .set_pwr() callback is removed from platform data.
> > > Thus, .set_pwr() is not used anymore. Also, this patch fixes
> > > the following build error and warning.
> > >
> > > drivers/mfd/asic3.c:724:2: error: unknown field 'set_pwr' specified in
> > > initializer drivers/mfd/asic3.c:724:2: warning: initialization makes
> > > integer from pointer without a cast [enabled by default]
> > > drivers/mfd/asic3.c:724:2: warning: (near initialization for
> > > 'asic3_mmc_data.capabilities' [enabled by default]
> >
> > My bad, it looks like I've overlooked a few users of the .set_pwr() field
> > :-/ Sorry about that.
>
> <snip>
>
> > I don't think blindly removing the function is the right fix, as it seems
> > to be needed. Looking at the whole series, I believe we should just
> > revert 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from platform
> > data" instead.
>
> No need to revert it, as it's not in Mainline yet. Just request for it
> to be removed from Chris' tree.
I spupose it depends on whether Chris has provided a stable branch with the
patch included. I'm fine with both, the commit just needs to be undone one way
or another.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-08-28 7:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 5:52 [PATCH 1/5] mfd: asic3: Remove .set_pwr() callback Jingoo Han
2013-08-28 5:54 ` [PATCH 2/5] mfd: t7l66xb: " Jingoo Han
2013-08-28 5:54 ` [PATCH 3/5] mfd: tc6387xb: " Jingoo Han
2013-08-28 5:54 ` [PATCH 4/5] mfd: tc6393xb: " Jingoo Han
2013-08-28 5:55 ` [PATCH 5/5] mfd: tmio_core: Remove tmio_core_mmc_pwr() Jingoo Han
2013-08-28 6:27 ` [PATCH 1/5] mfd: asic3: Remove .set_pwr() callback Jingoo Han
2013-08-28 7:37 ` Lee Jones
2013-08-28 7:36 ` Laurent Pinchart
2013-08-28 7:41 ` Lee Jones
2013-08-28 7:51 ` Laurent Pinchart [this message]
2013-08-29 14:42 ` Kevin Hilman
2013-08-29 14:59 ` Laurent Pinchart
2013-09-06 11:38 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81053150.gZpPo7ioCr@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=jg1.han@samsung.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.