diff for duplicates of <8117172.9hfShvmdlS@avalon> diff --git a/a/1.txt b/N1/1.txt index a89158c..ae751e0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -179,12 +179,12 @@ to you. > + writeb(0, priv->base + I2C_OFS_IICACT0); > + > + retr = 1000; -> + while (readb(priv->base + I2C_OFS_IICACT0) == 1 && retr) +> + while (readb(priv->base + I2C_OFS_IICACT0) = 1 && retr) How about adding a cpu_relax() here ? > + retr--; -> + WARN_ON(retr == 0); +> + WARN_ON(retr = 0); > + } > + > + /* Transfer mode set */ @@ -200,12 +200,12 @@ How about adding a cpu_relax() here ? > + writeb(I2C_BIT_IICE0, priv->base + I2C_OFS_IICACT0); > + > + retr = 1000; -> + while (readb(priv->base + I2C_OFS_IICACT0) == 0 && retr) +> + while (readb(priv->base + I2C_OFS_IICACT0) = 0 && retr) And here too. > + retr--; -> + WARN_ON(retr == 0); +> + WARN_ON(retr = 0); > +} > + > +static int __em_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, @@ -294,7 +294,7 @@ Same for the check in the loop below. > + return -EAGAIN; > + > + for (i = 0; i < num; i++) { -> + ret = __em_i2c_xfer(adap, &msgs[i], (i == (num - 1))); +> + ret = __em_i2c_xfer(adap, &msgs[i], (i = (num - 1))); > + if (ret < 0) > + return ret; > + } diff --git a/a/content_digest b/N1/content_digest index 5ec0abe..79cf852 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01436219188-4325-4-git-send-email-wsa@the-dreams.de\0" "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Subject\0Re: [PATCH 3/5] i2c: emev2: add driver\0" - "Date\0Tue, 07 Jul 2015 21:40:30 +0300\0" + "Date\0Tue, 07 Jul 2015 18:40:30 +0000\0" "To\0Wolfram Sang <wsa@the-dreams.de>\0" "Cc\0linux-i2c@vger.kernel.org" linux-sh@vger.kernel.org @@ -192,12 +192,12 @@ "> +\t\twriteb(0, priv->base + I2C_OFS_IICACT0);\n" "> +\n" "> +\t\tretr = 1000;\n" - "> +\t\twhile (readb(priv->base + I2C_OFS_IICACT0) == 1 && retr)\n" + "> +\t\twhile (readb(priv->base + I2C_OFS_IICACT0) = 1 && retr)\n" "\n" "How about adding a cpu_relax() here ?\n" "\n" "> +\t\t\tretr--;\n" - "> +\t\tWARN_ON(retr == 0);\n" + "> +\t\tWARN_ON(retr = 0);\n" "> +\t}\n" "> +\n" "> +\t/* Transfer mode set */\n" @@ -213,12 +213,12 @@ "> +\twriteb(I2C_BIT_IICE0, priv->base + I2C_OFS_IICACT0);\n" "> +\n" "> +\tretr = 1000;\n" - "> +\twhile (readb(priv->base + I2C_OFS_IICACT0) == 0 && retr)\n" + "> +\twhile (readb(priv->base + I2C_OFS_IICACT0) = 0 && retr)\n" "\n" "And here too.\n" "\n" "> +\t\tretr--;\n" - "> +\tWARN_ON(retr == 0);\n" + "> +\tWARN_ON(retr = 0);\n" "> +}\n" "> +\n" "> +static int __em_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msg,\n" @@ -307,7 +307,7 @@ "> +\t\treturn -EAGAIN;\n" "> +\n" "> +\tfor (i = 0; i < num; i++) {\n" - "> +\t\tret = __em_i2c_xfer(adap, &msgs[i], (i == (num - 1)));\n" + "> +\t\tret = __em_i2c_xfer(adap, &msgs[i], (i = (num - 1)));\n" "> +\t\tif (ret < 0)\n" "> +\t\t\treturn ret;\n" "> +\t}\n" @@ -448,4 +448,4 @@ "\n" Laurent Pinchart -c2a129d60b9b73709ef50ebf73ee05c8825b24bc3b170694a355e33add8fea82 +0a5a8f2c16f7672c733ee9bf6c8354cdb26d0ce6f550d7a327d018c4ffce3629
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.