From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, Nicolas Belin <nbelin@baylibre.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
pavel@ucw.cz
Subject: Re: [PATCH 0/3] leds: add support for apa102c leds
Date: Tue, 18 Feb 2020 22:26:36 +0100 [thread overview]
Message-ID: <812dc835-7f97-00e5-1d75-c160e11f63fc@gmail.com> (raw)
In-Reply-To: <04642127-0e68-43b1-9b6c-0dbb56dc9bfe@ti.com>
Hi Dan,
On 2/18/20 1:43 PM, Dan Murphy wrote:
> Hellp
>
> On 2/18/20 3:37 AM, Nicolas Belin wrote:
>> This patch series adds the driver and its related documentation
>> for the APA102C RGB Leds.
>>
>> Patch 1 adds the APA102C led manufacturer to the vendor-prefixes list.
>>
>> Patch 2 Documents the APA102C led driver.
>>
>> Patch 3 contains the actual driver code and modifications in the Kconfig
>> and the Makefile.
>
> Is this something that can benefit from the Multicolor framework patches?
>
> https://lore.kernel.org/patchwork/project/lkml/list/?series=427513
>
> Can you RFC the APA102C driver on top of the Multicolor FW to see how it
> blends?
Just to let you know - I am currently playing with Samsung Galaxy S3,
which has mainline support, and also with a driver for its RGB LED:
leds-an30259a.c. I am adjusting that driver to LED multicolor class
and I will have certainly some more remarks (also to the variable naming
I proposed myself, which after few months feels awkward to me).
Generally speaking - we have to do everything to make the addition
of LED multicolor support to the driver way easier and more
straightforward since currently it is painful. I would go for
a separate compilation unit for multicolor specifc part of LED drivers.
But I will be able to tell more after few more days.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-02-18 21:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 9:37 [PATCH 0/3] leds: add support for apa102c leds Nicolas Belin
2020-02-18 9:37 ` [PATCH 1/3] dt-bindings: Document shiji vendor-prefix Nicolas Belin
2020-02-18 12:40 ` Dan Murphy
2020-02-18 9:37 ` [PATCH 2/3] dt-bindings: leds: Shiji Lighting APA102C LED driver Nicolas Belin
2020-02-18 20:28 ` Jacek Anaszewski
2020-02-20 10:30 ` Geert Uytterhoeven
2020-02-20 19:41 ` Jacek Anaszewski
2020-02-18 9:37 ` [PATCH 3/3] drivers: leds: add support for apa102c leds Nicolas Belin
2020-02-18 21:13 ` Jacek Anaszewski
2020-02-20 10:25 ` Nicolas Belin
2020-02-18 12:43 ` [PATCH 0/3] " Dan Murphy
2020-02-18 21:26 ` Jacek Anaszewski [this message]
2020-02-20 10:19 ` Nicolas Belin
2020-02-26 14:19 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=812dc835-7f97-00e5-1d75-c160e11f63fc@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nbelin@baylibre.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.