From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHSLx-0002WY-57 for ath10k@lists.infradead.org; Thu, 26 Mar 2020 13:15:25 +0000 MIME-Version: 1.0 Date: Thu, 26 Mar 2020 18:45:06 +0530 From: ssreeela@codeaurora.org Subject: Re: [PATCH] ath10k: enable VHT160 and VHT80+80 modes In-Reply-To: <20200326095907.5326BC433BA@smtp.codeaurora.org> References: <1585148169-2320-1-git-send-email-ssreeela@codeaurora.org> <20200326095907.5326BC433BA@smtp.codeaurora.org> Message-ID: <812e84a585ed3aeda9aa54f7d2b14e93@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: Lei Wang , Rick Wu , linux-wireless@vger.kernel.org, Sebastian Gottschall , ath10k@lists.infradead.org T24gMjAyMC0wMy0yNiAxNToyOSwgS2FsbGUgVmFsbyB3cm90ZToKPiBTb3dtaXlhIFNyZWUgRWxh dmFsYWdhbiA8c3NyZWVlbGFAY29kZWF1cm9yYS5vcmc+IHdyb3RlOgo+IAo+PiBGcm9tOiBMZWkg V2FuZyA8bGVpd2FAY29kZWF1cm9yYS5vcmc+Cj4+IAo+PiBTZXQgcmlnaHQgY2hhbm5lbCBmcmVx dWVuY2llcyBpbiBWSFQxNjAgbW9kZSBhY2NvcmRpbmcgdG8gdGhlIFZIVDE2MAo+PiBpbnRlcm9w ZXJhYmlsaXR5IHdvcmthcm91bmQgYWRkZWQgYXMgcGFydCBvZiBJRUVFIFN0ZCA4MDIuMTHihKIt MjAxNiBpbgo+PiAiVGFibGUgOS0yNTLigJRWSFQgT3BlcmF0aW9uIEluZm9ybWF0aW9uIHN1YmZp ZWxkcyIsIGJhbmRfY2VudGVyX2ZyZXEyCj4+IGNvcnJlc3BvbmRzIHRvIENDRlMxIGluIFRhYmxl IDktMjUzLiBQcmV2aW91cyBpbXBsZW1lbnRhdGlvbgo+PiAoYmFuZF9jZW50ZXJfZnJlcTIgPSAw IGZvciBWSFQxNjApIGlzIG9ubHkgZGVwcmVjYXRlZC4KPj4gCj4+IEVuYWJsZSBWSFQ4MCs4MCBt b2RlIGFuZCBzZXQgdGhlIHByb3BlciBwZWVyIFJYIG5zcyB2YWx1ZSBmb3IgVkhUMTYwIAo+PiBh bmQKPj4gVkhUODArODAgbW9kZS4KPj4gCj4+IEJhc2VkIG9uIHBhdGNoZXMgYnkgU2ViYXN0aWFu IEdvdHRzY2hhbGw6Cj4+IAo+PiBodHRwczovL2xrbWwua2VybmVsLm9yZy9yLzIwMTgwNzA0MDk1 NDQ0LjY2Mi0xLXMuZ290dHNjaGFsbEBkZC13cnQuY29tCj4+IAo+PiBodHRwczovL2xrbWwua2Vy bmVsLm9yZy9yLzIwMTgwNzA0MTIwNTE5LjY0NzktMS1zLmdvdHRzY2hhbGxAZGQtd3J0LmNvbQo+ PiAKPj4gVGVzdGVkOiBxY2E5OTg0IHdpdGggZmlybXdhcmUgdmVyIDEwLjQtMy4xMC0wMDA0Nwo+ PiAKPj4gQ28tZGV2ZWxvcGVkLWJ5OiBTZWJhc3RpYW4gR290dHNjaGFsbCA8cy5nb3R0c2NoYWxs QGRkLXdydC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IFNlYmFzdGlhbiBHb3R0c2NoYWxsIDxzLmdv dHRzY2hhbGxAZGQtd3J0LmNvbT4KPj4gQ28tZGV2ZWxvcGVkLWJ5OiBSaWNrIFd1IDxyd3VAY29k ZWF1cm9yYS5vcmc+Cj4+IFNpZ25lZC1vZmYtYnk6IFJpY2sgV3UgPHJ3dUBjb2RlYXVyb3JhLm9y Zz4KPj4gU2lnbmVkLW9mZi1ieTogTGVpIFdhbmcgPGxlaXdhQGNvZGVhdXJvcmEub3JnPgo+PiBT aWduZWQtb2ZmLWJ5OiBTb3dtaXlhIFNyZWUgRWxhdmFsYWdhbiA8c3NyZWVlbGFAY29kZWF1cm9y YS5vcmc+Cj4gCj4gRmFpbHMgdG8gYnVpbGQgb24gR0NDIDguMS4gRGlkIHlvdSB0ZXN0IHRoaXM/ Cj4gCj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4vaW5jbHVkZS9hc20tZ2VuZXJpYy9idWcuaDo1 LAo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2J1Zy5oOjgz LAo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUvbGludXgvYnVnLmg6NSwKPiAgICAg ICAgICAgICAgICAgIGZyb20gLi9pbmNsdWRlL25ldC9tYWM4MDIxMS5oOjE2LAo+ICAgICAgICAg ICAgICAgICAgZnJvbSBkcml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRoMTBrL21hYy5oOjEwLAo+ ICAgICAgICAgICAgICAgICAgZnJvbSBkcml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRoMTBrL21h Yy5jOjg6Cj4gSW4gZnVuY3Rpb24gJ2F0aDEwa19wZWVyX2Fzc29jX2hfdmh0JywKPiAgICAgaW5s aW5lZCBmcm9tICdhdGgxMGtfcGVlcl9hc3NvY19wcmVwYXJlJyBhdAo+IGRyaXZlcnMvbmV0L3dp cmVsZXNzL2F0aC9hdGgxMGsvbWFjLmM6Mjc5MDoyOgo+IC4vaW5jbHVkZS9saW51eC9jb21waWxl ci5oOjM1MDozODogZXJyb3I6IGNhbGwgdG8KPiAnX19jb21waWxldGltZV9hc3NlcnRfMjYzMScg ZGVjbGFyZWQgd2l0aCBhdHRyaWJ1dGUgZXJyb3I6Cj4gQlVJTERfQlVHX09OIGZhaWxlZDogKCgo KCgofigoKDBVTCkpKSkgLSAoKCgoMVVMKSkpIDw8ICgzKSkgKyAxKSAmCj4gKH4oKCgwVUwpKSkg Pj4gKDY0IC0gMSAtICg1KSkpKSkgKyAoMVVMTCA8PAo+IChfX2J1aWx0aW5fZmZzbGwoKCgofigo KDBVTCkpKSkgLSAoKCgoMVVMKSkpIDw8ICgzKSkgKyAxKSAmCj4gKH4oKCgwVUwpKSkgPj4gKDY0 IC0gMSAtICg1KSkpKSkgLSAxKSkpICYgKCgoKCgofigoKDBVTCkpKSkgLQo+ICgoKCgxVUwpKSkg PDwgKDMpKSArIDEpICYgKH4oKCgwVUwpKSkgPj4gKDY0IC0gMSAtICg1KSkpKSkgKyAoMVVMTCA8 PAo+IChfX2J1aWx0aW5fZmZzbGwoKCgofigoKDBVTCkpKSkgLSAoKCgoMVVMKSkpIDw8ICgzKSkg KyAxKSAmCj4gKH4oKCgwVUwpKSkgPj4gKDY0IC0gMSAtICg1KSkpKSkgLSAxKSkpIC0gMSkpICE9 IDAKPiAgIF9jb21waWxldGltZV9hc3NlcnQoY29uZGl0aW9uLCBtc2csIF9fY29tcGlsZXRpbWVf YXNzZXJ0XywgX19MSU5FX18pCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBeCj4gLi9pbmNsdWRlL2xpbnV4L2NvbXBpbGVyLmg6MzMxOjQ6IG5vdGU6IGluIGRlZmluaXRp b24gb2YgbWFjcm8KPiAnX19jb21waWxldGltZV9hc3NlcnQnCj4gICAgIHByZWZpeCAjIyBzdWZm aXgoKTsgICAgXAo+ICAgICBefn5+fn4KPiAuL2luY2x1ZGUvbGludXgvY29tcGlsZXIuaDozNTA6 Mjogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvCj4gJ19jb21waWxldGltZV9hc3NlcnQnCj4g ICBfY29tcGlsZXRpbWVfYXNzZXJ0KGNvbmRpdGlvbiwgbXNnLCBfX2NvbXBpbGV0aW1lX2Fzc2Vy dF8sIF9fTElORV9fKQo+ICAgXn5+fn5+fn5+fn5+fn5+fn5+fgo+IC4vaW5jbHVkZS9saW51eC9i dWlsZF9idWcuaDozOTozNzogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvCj4gJ2NvbXBpbGV0 aW1lX2Fzc2VydCcKPiAgI2RlZmluZSBCVUlMRF9CVUdfT05fTVNHKGNvbmQsIG1zZykgY29tcGls ZXRpbWVfYXNzZXJ0KCEoY29uZCksIG1zZykKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXn5+fn5+fn5+fn5+fn5+fn5+Cj4gLi9pbmNsdWRlL2xpbnV4L2JpdGZpZWxkLmg6 NDk6Mzogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIAo+ICdCVUlMRF9CVUdfT05fTVNHJwo+ ICAgIEJVSUxEX0JVR19PTl9NU0coX19idWlsdGluX2NvbnN0YW50X3AoX3ZhbCkgPyAgXAo+ICAg IF5+fn5+fn5+fn5+fn5+fn4KPiAuL2luY2x1ZGUvbGludXgvYml0ZmllbGQuaDo4MTozOiBub3Rl OiBpbiBleHBhbnNpb24gb2YgbWFjcm8gCj4gJ19fQkZfRklFTERfQ0hFQ0snCj4gICAgX19CRl9G SUVMRF9DSEVDSyhfbWFzaywgMFVMTCwgX3ZhbCwgIkZJRUxEX1BSRVA6ICIpOyBcCj4gICAgXn5+ fn5+fn5+fn5+fn5+fgo+IGRyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvbWFjLmM6MjYz MTo0OiBub3RlOiBpbiBleHBhbnNpb24gb2YKPiBtYWNybyAnRklFTERfUFJFUCcKPiAgICAgRklF TERfUFJFUChXTUlfUEVFUl9OU1NfODBfODBNSFpfTUFTSywgKHJ4X25zcyAtIDEpKTsKPiAgICAg Xn5+fn5+fn5+fgo+IC4vaW5jbHVkZS9saW51eC9jb21waWxlci5oOjM1MDozODogZXJyb3I6IGNh bGwgdG8KPiAnX19jb21waWxldGltZV9hc3NlcnRfMjYyNycgZGVjbGFyZWQgd2l0aCBhdHRyaWJ1 dGUgZXJyb3I6Cj4gQlVJTERfQlVHX09OIGZhaWxlZDogKCgoKCgofigoKDBVTCkpKSkgLSAoKCgo MVVMKSkpIDw8ICgwKSkgKyAxKSAmCj4gKH4oKCgwVUwpKSkgPj4gKDY0IC0gMSAtICgyKSkpKSkg KyAoMVVMTCA8PAo+IChfX2J1aWx0aW5fZmZzbGwoKCgofigoKDBVTCkpKSkgLSAoKCgoMVVMKSkp IDw8ICgwKSkgKyAxKSAmCj4gKH4oKCgwVUwpKSkgPj4gKDY0IC0gMSAtICgyKSkpKSkgLSAxKSkp ICYgKCgoKCgofigoKDBVTCkpKSkgLQo+ICgoKCgxVUwpKSkgPDwgKDApKSArIDEpICYgKH4oKCgw VUwpKSkgPj4gKDY0IC0gMSAtICgyKSkpKSkgKyAoMVVMTCA8PAo+IChfX2J1aWx0aW5fZmZzbGwo KCgofigoKDBVTCkpKSkgLSAoKCgoMVVMKSkpIDw8ICgwKSkgKyAxKSAmCj4gKH4oKCgwVUwpKSkg Pj4gKDY0IC0gMSAtICgyKSkpKSkgLSAxKSkpIC0gMSkpICE9IDAKPiAgIF9jb21waWxldGltZV9h c3NlcnQoY29uZGl0aW9uLCBtc2csIF9fY29tcGlsZXRpbWVfYXNzZXJ0XywgX19MSU5FX18pCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCj4gLi9pbmNsdWRlL2xpbnV4 L2NvbXBpbGVyLmg6MzMxOjQ6IG5vdGU6IGluIGRlZmluaXRpb24gb2YgbWFjcm8KPiAnX19jb21w aWxldGltZV9hc3NlcnQnCj4gICAgIHByZWZpeCAjIyBzdWZmaXgoKTsgICAgXAo+ICAgICBefn5+ fn4KPiAuL2luY2x1ZGUvbGludXgvY29tcGlsZXIuaDozNTA6Mjogbm90ZTogaW4gZXhwYW5zaW9u IG9mIG1hY3JvCj4gJ19jb21waWxldGltZV9hc3NlcnQnCj4gICBfY29tcGlsZXRpbWVfYXNzZXJ0 KGNvbmRpdGlvbiwgbXNnLCBfX2NvbXBpbGV0aW1lX2Fzc2VydF8sIF9fTElORV9fKQo+ICAgXn5+ fn5+fn5+fn5+fn5+fn5+fgo+IC4vaW5jbHVkZS9saW51eC9idWlsZF9idWcuaDozOTozNzogbm90 ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvCj4gJ2NvbXBpbGV0aW1lX2Fzc2VydCcKPiAgI2RlZmlu ZSBCVUlMRF9CVUdfT05fTVNHKGNvbmQsIG1zZykgY29tcGlsZXRpbWVfYXNzZXJ0KCEoY29uZCks IG1zZykKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+ fn5+fn5+Cj4gLi9pbmNsdWRlL2xpbnV4L2JpdGZpZWxkLmg6NDk6Mzogbm90ZTogaW4gZXhwYW5z aW9uIG9mIG1hY3JvIAo+ICdCVUlMRF9CVUdfT05fTVNHJwo+ICAgIEJVSUxEX0JVR19PTl9NU0co X19idWlsdGluX2NvbnN0YW50X3AoX3ZhbCkgPyAgXAo+ICAgIF5+fn5+fn5+fn5+fn5+fn4KPiAu L2luY2x1ZGUvbGludXgvYml0ZmllbGQuaDo4MTozOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFj cm8gCj4gJ19fQkZfRklFTERfQ0hFQ0snCj4gICAgX19CRl9GSUVMRF9DSEVDSyhfbWFzaywgMFVM TCwgX3ZhbCwgIkZJRUxEX1BSRVA6ICIpOyBcCj4gICAgXn5+fn5+fn5+fn5+fn5+fgo+IGRyaXZl cnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvbWFjLmM6MjYyNzo0OiBub3RlOiBpbiBleHBhbnNp b24gb2YKPiBtYWNybyAnRklFTERfUFJFUCcKPiAgICAgRklFTERfUFJFUChXTUlfUEVFUl9OU1Nf MTYwTUhaX01BU0ssIChyeF9uc3MgLSAxKSk7Cj4gICAgIF5+fn5+fn5+fn4KPiBtYWtlWzVdOiAq KiogW2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvbWFjLm9dIEVycm9yIDEKPiBtYWtl WzVdOiAqKiogV2FpdGluZyBmb3IgdW5maW5pc2hlZCBqb2JzLi4uLgo+IG1ha2VbNF06ICoqKiBb ZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEwa10gRXJyb3IgMgo+IG1ha2VbM106ICoqKiBb ZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoXSBFcnJvciAyCj4gbWFrZVsyXTogKioqIFtkcml2ZXJz L25ldC93aXJlbGVzc10gRXJyb3IgMgo+IG1ha2VbMV06ICoqKiBbZHJpdmVycy9uZXRdIEVycm9y IDIKPiBtYWtlOiAqKiogW2RyaXZlcnNdIEVycm9yIDIKPiAKPiBQYXRjaCBzZXQgdG8gQ2hhbmdl cyBSZXF1ZXN0ZWQuCgpIaSBLYWxsZSwKCkkgY2hlY2tlZCB0aGUgYnVpbGQuIEJ1aWxkIHdhcyBz dWNjZXNzZnVsIHdpdGggR0NDIHZlcnNpb24gNC44LgpXaWxsIGZpeCB0aGUgZXJyb3IgYW5kIHVw ZGF0ZSB0aGUgcGF0Y2guCgpUaGFua3MsClNvd21peWEgU3JlZQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D791C2D0E5 for ; Thu, 26 Mar 2020 13:15:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F2482073E for ; Thu, 26 Mar 2020 13:15:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Dm3K602/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726359AbgCZNPN (ORCPT ); Thu, 26 Mar 2020 09:15:13 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:35543 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725994AbgCZNPN (ORCPT ); Thu, 26 Mar 2020 09:15:13 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1585228512; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=p8e+V1RjNThFUhCLpNoZ5DCB/JxOR/HQEKV9PjEzIJg=; b=Dm3K602/OtCxzl+U2L7dCVuL6BkQSBi6NZQt7mWoP17/eQvtto9oYlKkQS3SfjZtgAfaxQf2 P90y9Gc96oEwO2l9o4KzkDK9nXErftJyMV4PJxh9n2zh4BBUwYyDVpLPCgmFOne2fLOa1FJf OKmc/fBGUpgKqq8lKwFi14BYu+8= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e7caadb.7fc707a6c1f0-smtp-out-n03; Thu, 26 Mar 2020 13:15:07 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 708CAC43637; Thu, 26 Mar 2020 13:15:07 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: ssreeela) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9AB83C433D2; Thu, 26 Mar 2020 13:15:06 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 26 Mar 2020 18:45:06 +0530 From: ssreeela@codeaurora.org To: Kalle Valo Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Lei Wang , Sebastian Gottschall , Rick Wu Subject: Re: [PATCH] ath10k: enable VHT160 and VHT80+80 modes In-Reply-To: <20200326095907.5326BC433BA@smtp.codeaurora.org> References: <1585148169-2320-1-git-send-email-ssreeela@codeaurora.org> <20200326095907.5326BC433BA@smtp.codeaurora.org> Message-ID: <812e84a585ed3aeda9aa54f7d2b14e93@codeaurora.org> X-Sender: ssreeela@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-03-26 15:29, Kalle Valo wrote: > Sowmiya Sree Elavalagan wrote: > >> From: Lei Wang >> >> Set right channel frequencies in VHT160 mode according to the VHT160 >> interoperability workaround added as part of IEEE Std 802.11™-2016 in >> "Table 9-252—VHT Operation Information subfields", band_center_freq2 >> corresponds to CCFS1 in Table 9-253. Previous implementation >> (band_center_freq2 = 0 for VHT160) is only deprecated. >> >> Enable VHT80+80 mode and set the proper peer RX nss value for VHT160 >> and >> VHT80+80 mode. >> >> Based on patches by Sebastian Gottschall: >> >> https://lkml.kernel.org/r/20180704095444.662-1-s.gottschall@dd-wrt.com >> >> https://lkml.kernel.org/r/20180704120519.6479-1-s.gottschall@dd-wrt.com >> >> Tested: qca9984 with firmware ver 10.4-3.10-00047 >> >> Co-developed-by: Sebastian Gottschall >> Signed-off-by: Sebastian Gottschall >> Co-developed-by: Rick Wu >> Signed-off-by: Rick Wu >> Signed-off-by: Lei Wang >> Signed-off-by: Sowmiya Sree Elavalagan > > Fails to build on GCC 8.1. Did you test this? > > In file included from ./include/asm-generic/bug.h:5, > from ./arch/x86/include/asm/bug.h:83, > from ./include/linux/bug.h:5, > from ./include/net/mac80211.h:16, > from drivers/net/wireless/ath/ath10k/mac.h:10, > from drivers/net/wireless/ath/ath10k/mac.c:8: > In function 'ath10k_peer_assoc_h_vht', > inlined from 'ath10k_peer_assoc_prepare' at > drivers/net/wireless/ath/ath10k/mac.c:2790:2: > ./include/linux/compiler.h:350:38: error: call to > '__compiletime_assert_2631' declared with attribute error: > BUILD_BUG_ON failed: ((((((~(((0UL)))) - ((((1UL))) << (3)) + 1) & > (~(((0UL))) >> (64 - 1 - (5))))) + (1ULL << > (__builtin_ffsll((((~(((0UL)))) - ((((1UL))) << (3)) + 1) & > (~(((0UL))) >> (64 - 1 - (5))))) - 1))) & ((((((~(((0UL)))) - > ((((1UL))) << (3)) + 1) & (~(((0UL))) >> (64 - 1 - (5))))) + (1ULL << > (__builtin_ffsll((((~(((0UL)))) - ((((1UL))) << (3)) + 1) & > (~(((0UL))) >> (64 - 1 - (5))))) - 1))) - 1)) != 0 > _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) > ^ > ./include/linux/compiler.h:331:4: note: in definition of macro > '__compiletime_assert' > prefix ## suffix(); \ > ^~~~~~ > ./include/linux/compiler.h:350:2: note: in expansion of macro > '_compiletime_assert' > _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) > ^~~~~~~~~~~~~~~~~~~ > ./include/linux/build_bug.h:39:37: note: in expansion of macro > 'compiletime_assert' > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^~~~~~~~~~~~~~~~~~ > ./include/linux/bitfield.h:49:3: note: in expansion of macro > 'BUILD_BUG_ON_MSG' > BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \ > ^~~~~~~~~~~~~~~~ > ./include/linux/bitfield.h:81:3: note: in expansion of macro > '__BF_FIELD_CHECK' > __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \ > ^~~~~~~~~~~~~~~~ > drivers/net/wireless/ath/ath10k/mac.c:2631:4: note: in expansion of > macro 'FIELD_PREP' > FIELD_PREP(WMI_PEER_NSS_80_80MHZ_MASK, (rx_nss - 1)); > ^~~~~~~~~~ > ./include/linux/compiler.h:350:38: error: call to > '__compiletime_assert_2627' declared with attribute error: > BUILD_BUG_ON failed: ((((((~(((0UL)))) - ((((1UL))) << (0)) + 1) & > (~(((0UL))) >> (64 - 1 - (2))))) + (1ULL << > (__builtin_ffsll((((~(((0UL)))) - ((((1UL))) << (0)) + 1) & > (~(((0UL))) >> (64 - 1 - (2))))) - 1))) & ((((((~(((0UL)))) - > ((((1UL))) << (0)) + 1) & (~(((0UL))) >> (64 - 1 - (2))))) + (1ULL << > (__builtin_ffsll((((~(((0UL)))) - ((((1UL))) << (0)) + 1) & > (~(((0UL))) >> (64 - 1 - (2))))) - 1))) - 1)) != 0 > _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) > ^ > ./include/linux/compiler.h:331:4: note: in definition of macro > '__compiletime_assert' > prefix ## suffix(); \ > ^~~~~~ > ./include/linux/compiler.h:350:2: note: in expansion of macro > '_compiletime_assert' > _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) > ^~~~~~~~~~~~~~~~~~~ > ./include/linux/build_bug.h:39:37: note: in expansion of macro > 'compiletime_assert' > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^~~~~~~~~~~~~~~~~~ > ./include/linux/bitfield.h:49:3: note: in expansion of macro > 'BUILD_BUG_ON_MSG' > BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \ > ^~~~~~~~~~~~~~~~ > ./include/linux/bitfield.h:81:3: note: in expansion of macro > '__BF_FIELD_CHECK' > __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \ > ^~~~~~~~~~~~~~~~ > drivers/net/wireless/ath/ath10k/mac.c:2627:4: note: in expansion of > macro 'FIELD_PREP' > FIELD_PREP(WMI_PEER_NSS_160MHZ_MASK, (rx_nss - 1)); > ^~~~~~~~~~ > make[5]: *** [drivers/net/wireless/ath/ath10k/mac.o] Error 1 > make[5]: *** Waiting for unfinished jobs.... > make[4]: *** [drivers/net/wireless/ath/ath10k] Error 2 > make[3]: *** [drivers/net/wireless/ath] Error 2 > make[2]: *** [drivers/net/wireless] Error 2 > make[1]: *** [drivers/net] Error 2 > make: *** [drivers] Error 2 > > Patch set to Changes Requested. Hi Kalle, I checked the build. Build was successful with GCC version 4.8. Will fix the error and update the patch. Thanks, Sowmiya Sree