From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:907:9874:b0:a31:23a7:2a34 with SMTP id ko20csp948397ejc; Fri, 26 Jan 2024 07:31:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEXdPypzy0cRTvfvdJgwfqpAwUn2W/htUdmG+9n0sUuVn9qZmSWFmhxNo8UqqefUwGVOMpD X-Received: by 2002:a05:6820:1002:b0:59a:1536:67f5 with SMTP id v2-20020a056820100200b0059a153667f5mr175259oor.7.1706283078505; Fri, 26 Jan 2024 07:31:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706283078; cv=none; d=google.com; s=arc-20160816; b=Kb133vZiTjgHbazb8yW52P9Fy6QbXX8lup3Vu3ZLsLipKG3o9hapPDI3U5C7SMhOpl JHbGI0m36r2+5U3Wq07X3m3viJ1Ttcb+6GNw7hIWAZ0RvlYTqRLgNIlId6ykz0HO5G5y 2/GhsTCgLV11ekbJt5Gf8EQGzPwTrOn/aynv/Awjv98E7zy12Ca4apowXWV/oexDUk3C 0sHoToY8Ef8tygwHPcYBzx9zwlw6NnerVyKaLMmzlDe0RuT+uUJRHQCRRGFk5TtheYHA td/HumR4JEbmuDOlLu7Z0J3QjI3WWEZ4VUOO0hEvvJTNV0BoXAYptxQ3hw0+IbAWgpH8 +tkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:autocrypt:from:references:cc:to:content-language :subject:user-agent:mime-version:date:message-id:dkim-signature; bh=/5/L16msHzmOomODVoHlIH3CZ8C330sQ+zGa74Hg7iQ=; fh=gUwT78jNU3KQ46xkclJwrzua+F3Tx7+jKVy5HTrDdV8=; b=SvtPG3hgWtUCzW7CgnUqH2sbCYQpHo/IlWm/3VCVac8jVviFa89COGLuhfoKGMlbEU U00l08x/VRquacZqxmdOXegotL1FuXyKlIflZpnSxJrRN1AEQ4w9oEx9k/jCJbAm1SaJ RFqjm+uMlwn7ySyNh+EOO4+nhZMy3qWk5T1vd3KT3qpc4GPp7+C08+RBHlIuLF28PSwP P2AwniPPgTSxuGUJT1J523a7yqdkUA3vu+QyyJKXsUbgpoqO/eouPs+p1KJDnG8WrWJS /u416PsVWEZ+GjqYa2d9TqeKvirvq9ST6ui7hqE7PK1Ydb0mFMwjqudzWj8FZRJp5wSR Hd7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=C6zdBXcf; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 4-20020a0562140d6400b00684b831fb9csi1431444qvs.170.2024.01.26.07.31.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2024 07:31:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=C6zdBXcf; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTOAW-0007Bb-04; Fri, 26 Jan 2024 10:31:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTOAQ-00078U-Mr for qemu-devel@nongnu.org; Fri, 26 Jan 2024 10:30:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTOAP-0005d6-2N for qemu-devel@nongnu.org; Fri, 26 Jan 2024 10:30:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706283052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/5/L16msHzmOomODVoHlIH3CZ8C330sQ+zGa74Hg7iQ=; b=C6zdBXcf9dGK1Rpzrb3tOt0WnaCIeNnYdBGbKxvjzZBdiYtZDytd/FcZTJLvEC/R9bD2D7 rvT6Ah8oS0TbvjnFyHuIEBAY+ygPjcQ2FBBSJE8xkMJ6r5VU6GJSGO47FSb3Ko/yjczbf0 Wzm25f9W/2EzwBmF6ouixhtWO/dw6hQ= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-C3K7N-7ROHG23DmtrjC53g-1; Fri, 26 Jan 2024 10:30:50 -0500 X-MC-Unique: C3K7N-7ROHG23DmtrjC53g-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-783dc3f6017so47440885a.1 for ; Fri, 26 Jan 2024 07:30:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706283050; x=1706887850; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/5/L16msHzmOomODVoHlIH3CZ8C330sQ+zGa74Hg7iQ=; b=Hcccjeq7uxw0BqpV6pD5yutBbs1njpe8auF7x2j+s+5jmOj+cvlTVfXAyGHNa8c/T2 qKLRCXUFXu2ZGAd27RMgVUwHWFWcDhp3VEkDqTv4vnieoDf3jH3WQSM9AN+hzOd6vlYq BoVN3xxOq/kwlOw8IJcm6MBd3ffDrguM1LeU+A45lxO+v+SQryHD4Ij9KzJIC8631tOJ VWeIUkpCkXAdEcUTbYUt0+LQVR0OI9y2YVdYNvBp2Jd2dQCOAwHuOZfN6OEY+jRE5A5a /FM+hWXhPTxueFy5rx7SnA0gC9XuqYH9TceEb12j69SGHLdvY/CX7p+gI7gM2jxYL2mO 14AA== X-Gm-Message-State: AOJu0YwGFEVxRE9yPJl8grxCG1U8LXLx/yFKnneVavsBTpf+FPgpsyQ7 L/zLCsup4qLrDnDfvnn1k0DtAdxqQx/LEpy8PYPLgAZLFCWyQX/bhprSr9YUZJvnucq33k9f/ao fsJ9PzYT2qx/o6rjAEj+oWndOPSoQu1y6Hbp6qlTwm8vRLgv1Mf5/JVkrH+LG X-Received: by 2002:a05:620a:2916:b0:783:d882:b540 with SMTP id m22-20020a05620a291600b00783d882b540mr875695qkp.22.1706283050491; Fri, 26 Jan 2024 07:30:50 -0800 (PST) X-Received: by 2002:a05:620a:2916:b0:783:d882:b540 with SMTP id m22-20020a05620a291600b00783d882b540mr875683qkp.22.1706283050270; Fri, 26 Jan 2024 07:30:50 -0800 (PST) Received: from [192.168.0.9] (ip-109-43-176-119.web.vodafone.de. [109.43.176.119]) by smtp.gmail.com with ESMTPSA id a19-20020a05620a125300b00783273e2de8sm649472qkl.121.2024.01.26.07.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jan 2024 07:30:49 -0800 (PST) Message-ID: <814b552f-6720-4ef9-9c14-22f7c7ed020b@redhat.com> Date: Fri, 26 Jan 2024 16:30:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/46] hw/arm/virt: use pci_init_nic_devices() Content-Language: en-US To: David Woodhouse , qemu-devel@nongnu.org, Peter Maydell , qemu-arm@nongnu.org Cc: Richard Henderson , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Jason Wang , David Woodhouse References: <20240108204909.564514-1-dwmw2@infradead.org> <20240108204909.564514-10-dwmw2@infradead.org> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240108204909.564514-10-dwmw2@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.313, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: qN9d+JjMs1B6 On 08/01/2024 21.26, David Woodhouse wrote: > From: David Woodhouse > > Signed-off-by: David Woodhouse > --- > hw/arm/virt.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 2793121cb4..8cf9237001 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1454,9 +1454,7 @@ static void create_pcie(VirtMachineState *vms) > pci->bypass_iommu = vms->default_bus_bypass_iommu; > vms->bus = pci->bus; > if (vms->bus) { > - for (i = 0; i < nb_nics; i++) { > - pci_nic_init_nofail(&nd_table[i], pci->bus, mc->default_nic, NULL); > - } > + pci_init_nic_devices(pci->bus, mc->default_nic); > } > > nodename = vms->pciehb_nodename = g_strdup_printf("/pcie@%" PRIx64, base); Reviewed-by: Thomas Huth