From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7] kernel folder for Linux and BSD modules Date: Thu, 22 Mar 2018 11:48:08 +0100 Message-ID: <8159309.KFzbjhHU2K@xps> References: <1519200571-12620-1-git-send-email-hemant.agrawal@nxp.com> <5555093.mTJxmOdrSU@xps> <20180322102749.GA1916@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Hemant Agrawal , dev@dpdk.org To: Bruce Richardson Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 9235D201 for ; Thu, 22 Mar 2018 11:48:27 +0100 (CET) In-Reply-To: <20180322102749.GA1916@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/03/2018 11:27, Bruce Richardson: > On Wed, Mar 21, 2018 at 07:42:55PM +0100, Thomas Monjalon wrote: > > Hi, > > > > About the title, please start with a verb: > > move kernel modules directories > > > > 22/02/2018 07:09, Hemant Agrawal: > > > --- /dev/null > > > +++ b/kernel/freebsd/BSDmakefile.meson > > > @@ -0,0 +1,43 @@ > > > +# BSD LICENSE > > > +# > > > +# Copyright(c) 2017 Intel Corporation. All rights reserved. > > > +# All rights reserved. > > > +# > > > +# Redistribution and use in source and binary forms, with or without > > > +# modification, are permitted provided that the following conditions > > > +# are met: > > > > Why not SPDX here? > > Is it copied from somewhere else? > > > Yes, it's copied, and the change to the license tag was missed previously. > It can be done as part of this patch, or else we can do a separate patch > for it if you prefer. OK, so let's fix it after this patch is applied.