From: Stephen Boyd <sboyd@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>,
Shuah Khan <skhan@linuxfoundation.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
patches@lists.linux.dev, kunit-dev@googlegroups.com,
linux-kselftest@vger.kernel.org, devicetree@vger.kernel.org,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rafael J.Wysocki <rafael@kernel.org>,
Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Daniel Latypov <dlatypov@google.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Ripard <maxime@cerno.tech>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH v8 8/8] clk: Add KUnit tests for clks registered with struct clk_parent_data
Date: Wed, 09 Oct 2024 12:07:09 -0700 [thread overview]
Message-ID: <81668a9199b39fe46cefd256d3eac44c.sboyd@kernel.org> (raw)
In-Reply-To: <594e8e50-8322-480e-ae34-3f8e14f3fe18@roeck-us.net>
Quoting Guenter Roeck (2024-10-08 16:27:37)
> On 10/8/24 16:12, Stephen Boyd wrote:
> >
> > The best I can come up with then is to test for a NULL of_root when
> > CONFIG_ARM64 and CONFIG_ACPI are enabled, because the tests
> > intentionally don't work when both those configs are enabled and the
> > 'of_root' isn't populated. In all other cases the 'of_root' missing is a
> > bug. I'll probably make this into some sort of kunit helper function in
> > of_private.h and send it to DT maintainers.
>
> Sounds good. Thanks a lot for tracking this down.
>
> That makes me wonder though why only arm64 has that restriction. Both
> riscv and loongarch have ACPI enabled in their defconfig files but call
> unflatten_device_tree() unconditionally.
>
> Oh well ...
Some of the reason is described in the thread I linked earlier. In
particular, this email from Mark[1]. There's also more comments from
Mark on an earlier patchset[2]. Maybe arm64 will allow it later, and
then we'll be able to revert this skip patch.
[1] https://lore.kernel.org/all/Zd4dQpHO7em1ji67@FVFF77S0Q05N.cambridge.arm.com/
[2] https://lore.kernel.org/all/ZaZtbU9hre3YhZam@FVFF77S0Q05N/
prev parent reply other threads:[~2024-10-09 19:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 21:04 [PATCH v8 0/8] clk: Add kunit tests for fixed rate and parent data Stephen Boyd
2024-07-18 21:05 ` [PATCH v8 1/8] of/platform: Allow overlays to create platform devices from the root node Stephen Boyd
2024-07-29 22:37 ` Stephen Boyd
2024-07-18 21:05 ` [PATCH v8 2/8] of: Add test managed wrappers for of_overlay_apply()/of_node_put() Stephen Boyd
2024-07-29 22:37 ` Stephen Boyd
2024-07-18 21:05 ` [PATCH v8 3/8] dt-bindings: vendor-prefixes: Add "test" vendor for KUnit and friends Stephen Boyd
2024-07-29 22:37 ` Stephen Boyd
2024-07-18 21:05 ` [PATCH v8 4/8] of: Add a KUnit test for overlays and test managed APIs Stephen Boyd
2024-07-29 22:37 ` Stephen Boyd
2024-07-18 21:05 ` [PATCH v8 5/8] platform: Add test managed platform_device/driver APIs Stephen Boyd
2024-07-29 22:37 ` Stephen Boyd
2024-09-24 2:33 ` Guenter Roeck
2024-07-18 21:05 ` [PATCH v8 6/8] clk: Add test managed clk provider/consumer APIs Stephen Boyd
2024-07-29 22:37 ` Stephen Boyd
2024-07-18 21:05 ` [PATCH v8 7/8] clk: Add KUnit tests for clk fixed rate basic type Stephen Boyd
2024-07-29 22:37 ` Stephen Boyd
2024-07-18 21:05 ` [PATCH v8 8/8] clk: Add KUnit tests for clks registered with struct clk_parent_data Stephen Boyd
2024-07-29 22:38 ` Stephen Boyd
2024-09-27 4:14 ` Guenter Roeck
2024-09-27 4:39 ` Guenter Roeck
2024-09-27 16:19 ` Guenter Roeck
2024-09-27 20:45 ` Shuah Khan
2024-09-28 0:08 ` Guenter Roeck
2024-09-28 17:31 ` Guenter Roeck
2024-09-28 17:54 ` Shuah Khan
2024-09-28 19:27 ` Shuah Khan
2024-09-28 21:32 ` Guenter Roeck
2024-10-03 23:46 ` Stephen Boyd
2024-10-04 0:25 ` Guenter Roeck
2024-10-04 0:42 ` Stephen Boyd
2024-10-04 4:52 ` Guenter Roeck
2024-10-08 23:12 ` Stephen Boyd
2024-10-08 23:27 ` Guenter Roeck
2024-10-09 19:07 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81668a9199b39fe46cefd256d3eac44c.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=conor+dt@kernel.org \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dlatypov@google.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maxime@cerno.tech \
--cc=mturquette@baylibre.com \
--cc=patches@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=rmoar@google.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.