Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

[Thomas Monjalon <thomas@monjalon.net>]

17/04/2021 02:28, Min Hu (Connor):
> 
> 在 2021/4/17 0:28, Stephen Hemminger 写道:
> > On Fri, 16 Apr 2021 11:22:02 +0100
> > Kevin Traynor <ktraynor@redhat.com> wrote:
> > 
> >>> +	if (dev_conf == NULL) {
> >>> +		RTE_ETHDEV_LOG(ERR,
> >>> +			"Cannot configure ethdev port %u to NULL dev_conf\n",
> >>
> >> The others use a natural sounding names instead of argument name. If you
> >> wanted to match that it could be "..to NULL conf"
> > 
> > I would prefer that error messages don't try to be English sentences.
> > The wording ends up awkward. and overly wordy.
> > If function name is automatically included by RTE_ETHDEV_LOG() then
> > Just:
> > 		RTE_ETHDEV_LOG(ERR, "NULL ethdev")
> > should be enough for programmer to find/fix the problem
> > .
> Hi, Stephen,
> 	Your opinion is quit different from that of Andrew Rybchenko.
> 	Andrew does not support show function name in the log:
> 	"- log messages should be human readable (i.e. I'd avoid
>     usage of function name)"
> 
> 	@Andrew ,@Thoms, @Ferruh, @Kevin, so, what's your opinion ?

I prefer human readable messages which are unique enough to be "grepped".