From: David Howells <dhowells@redhat.com>
To: Paul Moore <paul.moore@hp.com>
Cc: dhowells@redhat.com, sds@tycho.nsa.gov, jmorris@namei.org,
selinux@tycho.nsa.gov
Subject: Re: [PATCH] Fix a potentially uninitialised variable in SELinux hooks
Date: Wed, 09 Jul 2008 23:39:02 +0100 [thread overview]
Message-ID: <8198.1215643142@redhat.com> (raw)
In-Reply-To: <200807091821.46296.paul.moore@hp.com>
Paul Moore <paul.moore@hp.com> wrote:
> I haven't checked but I'm pretty sure that would fix the problem you are
> seeing, yes?
Maybe. The problem, I think, is that the error handling path diverges from
the main path and then converges again, and the compiler can't tell which way
it's going to go.
Besides, this way eliminates an if-statement. I noticed that addrp was never
passed as NULL, but I was unsure as to whether this will always be the case.
David
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2008-07-09 22:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 16:10 [PATCH] Fix a potentially uninitialised variable in SELinux hooks David Howells
2008-07-09 22:21 ` Paul Moore
2008-07-09 22:39 ` David Howells [this message]
2008-07-09 22:47 ` Paul Moore
2008-07-09 23:12 ` David Howells
2008-07-10 1:23 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8198.1215643142@redhat.com \
--to=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=paul.moore@hp.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.