From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74AF6C001E0 for ; Mon, 23 Oct 2023 10:29:50 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.621271.967574 (Exim 4.92) (envelope-from ) id 1qusBg-0001xq-Lq; Mon, 23 Oct 2023 10:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 621271.967574; Mon, 23 Oct 2023 10:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qusBg-0001xj-Ix; Mon, 23 Oct 2023 10:29:32 +0000 Received: by outflank-mailman (input) for mailman id 621271; Mon, 23 Oct 2023 10:29:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qusBg-0001wQ-0W for xen-devel@lists.xenproject.org; Mon, 23 Oct 2023 10:29:32 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0d1af58e-718f-11ee-98d5-6d05b1d4d9a1; Mon, 23 Oct 2023 12:29:31 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id B13594EE0740; Mon, 23 Oct 2023 12:29:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d1af58e-718f-11ee-98d5-6d05b1d4d9a1 MIME-Version: 1.0 Date: Mon, 23 Oct 2023 12:29:30 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH][for-4.19 v4 6/8] xen/console: remove stub definition in consoled.h In-Reply-To: <4d229be8-6daf-c27e-c9c0-01af6e4862f3@suse.com> References: <98443e951c5c51fc0dbedf1e530d1c27e564e19e.1698053876.git.nicola.vetrini@bugseng.com> <4d229be8-6daf-c27e-c9c0-01af6e4862f3@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <81ad44447e3313711fddb5d6833b40de@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 23/10/2023 12:21, Jan Beulich wrote: > On 23.10.2023 11:56, Nicola Vetrini wrote: >> The stub definition of 'consoled_guest_tx' can be removed, since its >> its single caller uses the implementation built with PV_SHIM enabled. >> >> Fixes: 5ef49f185c2d ("x86/pv-shim: shadow PV console's page for L2 >> DomU") >> Signed-off-by: Nicola Vetrini > > Where did Stefano's R-b go? > > Jan I didn't notice it. Nothing has changed since, so it should be included -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)