From: Alex Riesen <raa.lkml@gmail.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Junio C Hamano <junkio@cox.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: Improve handling of "." and ".." in git-diff-*
Date: Tue, 23 Aug 2005 21:49:07 +0200 [thread overview]
Message-ID: <81b0412b050823124938d735bf@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0508162037080.3553@g5.osdl.org>
On 8/17/05, Linus Torvalds <torvalds@osdl.org> wrote:
> NOTE! This does _not_ handle ".." or "." in the _middle_ of a pathspec. If
> you have people who do
BTW, could this (below) be useful for something?
#include <string.h>
#include <stdio.h>
#include <stdlib.h>
// an analog of "cd path" from a directory "cwd".
char* pathexpand(const char* cwd, const char* path)
{
static const char SEP[] = "/";
if ( !*path ) // empty path -> "." (don't move)
path = ".";
if ( !*cwd || *SEP == *path ) // no cwd, or path begins with "/"
cwd = SEP;
int len = strlen(cwd);
char* out = (char*)malloc(len + 1 + strlen(path) + 1);
char* p = strcpy(out, cwd) + len;
if ( *SEP != p[-1] )
*p++ = *SEP;
for ( ; *path; ++path )
{
char * pl = p;
while ( *path && *SEP != *path )
*p++ = *path++;
*p = '\0';
if ( p == pl ) /* ..."//"... */
; // just ignore
/* ..."/./"... */
else if ( p - pl == 1 && '.' == *pl )
--p; // just ignore
/* ..."/../"... */
else if ( p - pl == 2 && '.' == pl[0] && '.' == pl[1] )
{
// drop last element of the resulting path
if ( --pl > out )
for ( --pl; pl > out && *SEP != *pl; --pl );
p = ++pl;
}
/* ..."/path/"... */
else if ( *path )
*p++ = *path; // just add the separator
if ( !*path )
break;
}
if ( p > out+1 && *SEP == p[-1] )
--p;
*p = '\0';
return out;
}
#ifdef CHECK_PATHEXPAND
static void check(const char * cwd, const char * path, const char * good)
{
static int n = 0;
printf("%-2d: %s$ cd %s", ++n, cwd, path);
char* t = pathexpand(cwd, path);
if ( strcmp(t, good) )
printf(" failed(%s)\n", t);
else
printf(" \t\t%s\n", t);
free(t);
}
int main(int argc, char** argv)
{
/* 1 */ check("/onelevel", "aa", "/onelevel/aa");
/* 2 */ check("/", "..", "/");
/* 3 */ check("/", "../..", "/");
/* 4 */ check("/one", "aa/../bb", "/one/bb");
/* 5 */ check("/one/two", "aa//bb", "/one/two/aa/bb");
/* 6 */ check("", "/aa//bb", "/aa/bb");
/* 7 */ check("/one/two", "", "/one/two");
/* 8 */ check("/one/two", "aa/..bb/x/../cc/", "/one/two/aa/..bb/cc");
/* 9 */ check("/one/two", "aa/x/././cc////", "/one/two/aa/x/cc");
/* 10 */ check("/one/two", "../../../../aa", "/aa");
return 0;
}
#endif
next prev parent reply other threads:[~2005-08-23 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-17 3:44 Improve handling of "." and ".." in git-diff-* Linus Torvalds
2005-08-17 3:52 ` Linus Torvalds
2005-08-23 19:49 ` Alex Riesen [this message]
2005-08-23 19:54 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b050823124938d735bf@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.