From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C2D3C433E2 for ; Thu, 17 Sep 2020 08:46:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11AE82075E for ; Thu, 17 Sep 2020 08:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600332361; bh=XYG6JGcwgkmjNbVGDa4h66QWAsy/bKbSi/BpwoM8ZUU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=s5cInOtInlPXqF/xqRvfuE8z/Up6vE5SDYkgpJ53nd9Aq4rFsXN1rgvHpnySR1Wfp lpr+jGqrmn+bnzznyxjgboYhx0V843q366ID07Z2qXm0ncrHPHn90SeJZBpUvF2YxH x7Ziiy95Dpr8dRBX4iJeUNAGAHW1tHSVQkq9JtYo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726285AbgIQIqA (ORCPT ); Thu, 17 Sep 2020 04:46:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:40376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726169AbgIQIp7 (ORCPT ); Thu, 17 Sep 2020 04:45:59 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8271F206A1; Thu, 17 Sep 2020 08:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600332358; bh=XYG6JGcwgkmjNbVGDa4h66QWAsy/bKbSi/BpwoM8ZUU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TvMRY2qOEraH4Rfb8k5hDT8yd1Lz4WxBT0oWNg/vfxujfyT7zAh5fVe5VXdROxz3V fjxL56HpXlT9rEhS1V6QbWFjKeNrhwuYJSiuF+sDqd0JJuxFbzdAnEjLioqFC2oPV/ EKZO8cw4Z4UVtE7Q9XSt5BlFS0Y6ujF7tV63c4UY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kIpYC-00Ca3q-N1; Thu, 17 Sep 2020 09:45:56 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 17 Sep 2020 09:45:56 +0100 From: Marc Zyngier To: Jon Hunter Cc: Linus Walleij , Marek Szyprowski , Linux ARM , linux-kernel@vger.kernel.org, Sumit Garg , kernel-team@android.com, Florian Fainelli , Russell King , Jason Cooper , Saravana Kannan , Andrew Lunn , Catalin Marinas , Gregory Clement , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Linux Samsung SOC , Thomas Gleixner , Will Deacon , Valentin Schneider , linux-tegra Subject: Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts In-Reply-To: References: <20200901144324.1071694-1-maz@kernel.org> <20200901144324.1071694-9-maz@kernel.org> <933bc43e-3cd7-10ec-b9ec-58afaa619fb7@nvidia.com> <3378cd07b92e87a24f1db75f708424ee@kernel.org> <049d62ac7de32590cb170714b47fb87d@kernel.org> User-Agent: Roundcube Webmail/1.4.8 Message-ID: <81cb16323baa1c81e7bc1e8156fa47b8@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: jonathanh@nvidia.com, linus.walleij@linaro.org, m.szyprowski@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sumit.garg@linaro.org, kernel-team@android.com, f.fainelli@gmail.com, linux@arm.linux.org.uk, jason@lakedaemon.net, saravanak@google.com, andrew@lunn.ch, catalin.marinas@arm.com, gregory.clement@bootlin.com, b.zolnierkie@samsung.com, krzk@kernel.org, linux-samsung-soc@vger.kernel.org, tglx@linutronix.de, will@kernel.org, Valentin.Schneider@arm.com, linux-tegra@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 2020-09-17 08:54, Jon Hunter wrote: > On 17/09/2020 08:50, Marc Zyngier wrote: >> Hi Linus, >> >> On 2020-09-17 08:40, Linus Walleij wrote: >>> On Wed, Sep 16, 2020 at 5:11 PM Marc Zyngier wrote: >>> >>>> Can you try the patch below and let me know? >>> >>> I tried this patch and now Ux500 WORKS. So this patch is definitely >>> something you should apply. >>> >>>> -                       if (is_frankengic()) >>>> -                               set_sgi_intid(irqstat); >>>> +                       this_cpu_write(sgi_intid, intid); >>> >>> This needs changing to irqstat to compile as pointed out by Jon. >>> >>> With that: >>> Tested-by: Linus Walleij >> >> Thanks a lot for that. >> >> Still need to understand why some of Jon's systems are left >> unbootable, >> despite having similar GIC implementations (Tegra194 and Tegra210 use >> the same GIC-400, and yet only one of the two boots correctly...). > > So far, I have only tested this patch on Tegra20. Let me try the other > failing boards this morning and see if those still fail. Tegra20 (if I remember well) is a dual A9 with the same GIC implementation as Ux500, hence requiring the source CPU bits to be written back. So this patch should have cured it, but didn't... /me puzzled. M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C862C433E2 for ; Thu, 17 Sep 2020 08:47:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1CC2206A1 for ; Thu, 17 Sep 2020 08:47:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vIHJWlrs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="TvMRY2qO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1CC2206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mC5Eckff6a1Qz43qqF/PRtqtapFK8stIETaSM4QW5Lo=; b=vIHJWlrssmQjJ1movXtTXdqfl cI5HRTUIvClR7UsGmoV7l80n5FdDJ3mJQJRAPYepNAz+ihKDHnP3TLtz3gNdOo+oJsSA3AKgNO9U3 OqSB7hSYd8MeO/ruKLLF8i5u8AMbF1njuv0IXsg//496DJ/EkJHspzvS5nSptos/BSxDlU8ZCxSNM tm+BNRLdW9SFRHB6QnZ/tMgBalM94jr4q3/Jf1qyGWrRmhSS39pfLWYLVJ3izt/0HPAUa0issJ05r BfLFUWQEkqRD+edJZdS5jb0rGT/dvgw0fi4ZuqW+1UITzFkqx4JOa6XMQ7SzJJPRM0hdQSIyw/Pd0 YdBkPnPnA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIpYH-0002Ov-G1; Thu, 17 Sep 2020 08:46:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIpYF-0002O4-6a for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 08:45:59 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8271F206A1; Thu, 17 Sep 2020 08:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600332358; bh=XYG6JGcwgkmjNbVGDa4h66QWAsy/bKbSi/BpwoM8ZUU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TvMRY2qOEraH4Rfb8k5hDT8yd1Lz4WxBT0oWNg/vfxujfyT7zAh5fVe5VXdROxz3V fjxL56HpXlT9rEhS1V6QbWFjKeNrhwuYJSiuF+sDqd0JJuxFbzdAnEjLioqFC2oPV/ EKZO8cw4Z4UVtE7Q9XSt5BlFS0Y6ujF7tV63c4UY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kIpYC-00Ca3q-N1; Thu, 17 Sep 2020 09:45:56 +0100 MIME-Version: 1.0 Date: Thu, 17 Sep 2020 09:45:56 +0100 From: Marc Zyngier To: Jon Hunter Subject: Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts In-Reply-To: References: <20200901144324.1071694-1-maz@kernel.org> <20200901144324.1071694-9-maz@kernel.org> <933bc43e-3cd7-10ec-b9ec-58afaa619fb7@nvidia.com> <3378cd07b92e87a24f1db75f708424ee@kernel.org> <049d62ac7de32590cb170714b47fb87d@kernel.org> User-Agent: Roundcube Webmail/1.4.8 Message-ID: <81cb16323baa1c81e7bc1e8156fa47b8@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: jonathanh@nvidia.com, linus.walleij@linaro.org, m.szyprowski@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sumit.garg@linaro.org, kernel-team@android.com, f.fainelli@gmail.com, linux@arm.linux.org.uk, jason@lakedaemon.net, saravanak@google.com, andrew@lunn.ch, catalin.marinas@arm.com, gregory.clement@bootlin.com, b.zolnierkie@samsung.com, krzk@kernel.org, linux-samsung-soc@vger.kernel.org, tglx@linutronix.de, will@kernel.org, Valentin.Schneider@arm.com, linux-tegra@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_044559_358275_DA722491 X-CRM114-Status: GOOD ( 16.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , Florian Fainelli , Russell King , Jason Cooper , Saravana Kannan , Andrew Lunn , Catalin Marinas , Linus Walleij , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Valentin Schneider , Will Deacon , Linux Samsung SOC , linux-tegra , Thomas Gleixner , kernel-team@android.com, Gregory Clement , Linux ARM , Marek Szyprowski Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0wOS0xNyAwODo1NCwgSm9uIEh1bnRlciB3cm90ZToKPiBPbiAxNy8wOS8yMDIwIDA4 OjUwLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+IEhpIExpbnVzLAo+PiAKPj4gT24gMjAyMC0wOS0x NyAwODo0MCwgTGludXMgV2FsbGVpaiB3cm90ZToKPj4+IE9uIFdlZCwgU2VwIDE2LCAyMDIwIGF0 IDU6MTEgUE0gTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4+PiAKPj4+PiBD YW4geW91IHRyeSB0aGUgcGF0Y2ggYmVsb3cgYW5kIGxldCBtZSBrbm93Pwo+Pj4gCj4+PiBJIHRy aWVkIHRoaXMgcGF0Y2ggYW5kIG5vdyBVeDUwMCBXT1JLUy4gU28gdGhpcyBwYXRjaCBpcyBkZWZp bml0ZWx5Cj4+PiBzb21ldGhpbmcgeW91IHNob3VsZCBhcHBseS4KPj4+IAo+Pj4+IC3CoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoaXNfZnJhbmtlbmdpYygp KQo+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgc2V0X3NnaV9pbnRpZChpcnFzdGF0KTsKPj4+PiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdGhpc19jcHVfd3JpdGUoc2dpX2ludGlkLCBp bnRpZCk7Cj4+PiAKPj4+IFRoaXMgbmVlZHMgY2hhbmdpbmcgdG8gaXJxc3RhdCB0byBjb21waWxl IGFzIHBvaW50ZWQgb3V0IGJ5IEpvbi4KPj4+IAo+Pj4gV2l0aCB0aGF0Ogo+Pj4gVGVzdGVkLWJ5 OiBMaW51cyBXYWxsZWlqIDxsaW51cy53YWxsZWlqQGxpbmFyby5vcmc+Cj4+IAo+PiBUaGFua3Mg YSBsb3QgZm9yIHRoYXQuCj4+IAo+PiBTdGlsbCBuZWVkIHRvIHVuZGVyc3RhbmQgd2h5IHNvbWUg b2YgSm9uJ3Mgc3lzdGVtcyBhcmUgbGVmdCAKPj4gdW5ib290YWJsZSwKPj4gZGVzcGl0ZSBoYXZp bmcgc2ltaWxhciBHSUMgaW1wbGVtZW50YXRpb25zIChUZWdyYTE5NCBhbmQgVGVncmEyMTAgdXNl Cj4+IHRoZSBzYW1lIEdJQy00MDAsIGFuZCB5ZXQgb25seSBvbmUgb2YgdGhlIHR3byBib290cyBj b3JyZWN0bHkuLi4pLgo+IAo+IFNvIGZhciwgSSBoYXZlIG9ubHkgdGVzdGVkIHRoaXMgcGF0Y2gg b24gVGVncmEyMC4gTGV0IG1lIHRyeSB0aGUgb3RoZXIKPiBmYWlsaW5nIGJvYXJkcyB0aGlzIG1v cm5pbmcgYW5kIHNlZSBpZiB0aG9zZSBzdGlsbCBmYWlsLgoKVGVncmEyMCAoaWYgSSByZW1lbWJl ciB3ZWxsKSBpcyBhIGR1YWwgQTkgd2l0aCB0aGUgc2FtZSBHSUMgCmltcGxlbWVudGF0aW9uCmFz IFV4NTAwLCBoZW5jZSByZXF1aXJpbmcgdGhlIHNvdXJjZSBDUFUgYml0cyB0byBiZSB3cml0dGVu IGJhY2suIFNvIAp0aGlzCnBhdGNoIHNob3VsZCBoYXZlIGN1cmVkIGl0LCBidXQgZGlkbid0Li4u CgovbWUgcHV6emxlZC4KCiAgICAgICAgIE0uCi0tIApKYXp6IGlzIG5vdCBkZWFkLiBJdCBqdXN0 IHNtZWxscyBmdW5ueS4uLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=