From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24C76C433E2 for ; Thu, 10 Sep 2020 10:17:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAC992078E for ; Thu, 10 Sep 2020 10:17:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TyMbFj/C" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730774AbgIJKQp (ORCPT ); Thu, 10 Sep 2020 06:16:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730260AbgIJKQi (ORCPT ); Thu, 10 Sep 2020 06:16:38 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 656B6C061756; Thu, 10 Sep 2020 03:16:38 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id s13so5065195wmh.4; Thu, 10 Sep 2020 03:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=TyMbFj/CCKS/yEhzmJyx0SXASPCumWs129eaMWwliNPHoe9nGlJZk2Tsw17ABtL/mL mWke72l5dRMmrFg9ieYmDr1jVfXiMwSmIMEMsNuXAYrMDmbRSlu2SEhpSFeukLVe3cg9 +5O+wBu+Jx7JfEyF9JNwdrWebHIVozT6N0VTqxSNEjrIsLOZ3R3dejl3APk21PLF2Oj8 +Kb8ACZuKGttnfzoDexc2yloyF3/YUcCQzcDsr90PZvO0KOXZEocClY8eSC4NnFPV4xO lvhsU6vpfnm+pvKWrckJN/8r5bLtL/kaV4lfgkeSIGRnLzVQeQ+BBL7u23nOrwhO07G+ JHEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=pmUw8PMCpmIHzSROi++DPz4KjuYgWtg1+Y5TE231Bqiqr8R2N1C3xqoxsiwBj6o1cg uH2BXtjGnMGGoluHj644z5xr7xlqF6U2gftY836V0P2i1eGVJRbd6Kt5NRdxnuMIEUiL l2iyGGPzmqplYZFS9cH521ZnO3ebnALHjbVC/Yy86VDwVom/j1SkB7EzjdV3z887JSV1 vBn2sxOKogw/Qr4Wwks6/Tsd6y+ZPpXYP0rtp5M7H0Cz9R+tTExVNwpFLc4afNM8kBHv sPRTlUxnMhVTJVsmuIxtZtgT2oyddp39osiyXrTv8c0GKDU7rTuLb07sCHlL7FBgK0nz qKBw== X-Gm-Message-State: AOAM531fehkY9RO3xn+p429hIZbAH2vvrEoH04VI6Oae8Aw4ljanDWzg xuso8Ww0yrtKmBUnjJW0R1g= X-Google-Smtp-Source: ABdhPJxz+CTfYBRsr9wPZ8ehDJQEmTq++yYJr4Xo0s0U0R6hQKoUpOmBLcC8LM7TIOPThVoU3WYKbg== X-Received: by 2002:a1c:234b:: with SMTP id j72mr7837172wmj.153.1599732997083; Thu, 10 Sep 2020 03:16:37 -0700 (PDT) Received: from ziggy.stardust ([213.195.113.201]) by smtp.gmail.com with ESMTPSA id a127sm2936155wmh.34.2020.09.10.03.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2020 03:16:36 -0700 (PDT) Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; To: Joe Perches , LKML , Jiri Kosina Cc: linux-wireless@vger.kernel.org, linux-fbdev@vger.kernel.org, oss-drivers@netronome.com, nouveau@lists.freedesktop.org, alsa-devel , dri-devel@lists.freedesktop.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, linux-atm-general@lists.sourceforge.net, linux-afs@lists.infradead.org, coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, Kees Cook , linux-media@vger.kernel.org, linux-pm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-sctp@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, storagedev@microchip.com, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, Nick Desaulniers , linux-mips@vger.kernel.org, iommu@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: From: Matthias Brugger Message-ID: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> Date: Thu, 10 Sep 2020 12:16:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Date: Thu, 10 Sep 2020 10:16:33 +0000 Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; Message-Id: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dccp@vger.kernel.org On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; Date: Thu, 10 Sep 2020 12:16:33 +0200 Message-ID: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joe Perches , LKML , Jiri Kosina Cc: linux-fbdev@vger.kernel.org, oss-drivers@netronome.com, nouveau@lists.freedesktop.org, alsa-devel , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org, linux-afs@lists.infradead.org, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, linux-atm-general@lists.sourceforge.net, kvmarm@lists.cs.columbia.edu, coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, Kees Cook , linux-media@vger.kernel.org, linux-pm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.in List-Id: dm-devel.ids On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Date: Thu, 10 Sep 2020 12:16:33 +0200 Subject: [Intel-wired-lan] [trivial PATCH] treewide: Convert switch/case fallthrough; to break; In-Reply-To: References: Message-ID: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 349B7C43461 for ; Thu, 10 Sep 2020 10:16:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6BC520BED for ; Thu, 10 Sep 2020 10:16:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TyMbFj/C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6BC520BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 41C7A89DFE; Thu, 10 Sep 2020 10:16:39 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64FFA89DFE; Thu, 10 Sep 2020 10:16:38 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id z9so5237876wmk.1; Thu, 10 Sep 2020 03:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=TyMbFj/CCKS/yEhzmJyx0SXASPCumWs129eaMWwliNPHoe9nGlJZk2Tsw17ABtL/mL mWke72l5dRMmrFg9ieYmDr1jVfXiMwSmIMEMsNuXAYrMDmbRSlu2SEhpSFeukLVe3cg9 +5O+wBu+Jx7JfEyF9JNwdrWebHIVozT6N0VTqxSNEjrIsLOZ3R3dejl3APk21PLF2Oj8 +Kb8ACZuKGttnfzoDexc2yloyF3/YUcCQzcDsr90PZvO0KOXZEocClY8eSC4NnFPV4xO lvhsU6vpfnm+pvKWrckJN/8r5bLtL/kaV4lfgkeSIGRnLzVQeQ+BBL7u23nOrwhO07G+ JHEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=nH0yUAovvhubPl6sBUwBrs2sJB+5Xq2akRghDHpweg6/kgxahhKiBNCcRHONYke6JV TNaI8PJRrI5Quu9Yhvo7PqDIhsMswRX7d0/zm0oRMLnRxOm1roeOJhNfS8RtqfYco6rJ 6kYa887RZZ3IZ1PMCm3uj1SOFkhSYUPRXncTlhUBMOJP5vX4UNRVLu0DS7zo7/0fnIpg BR8BbfaMHa+yM0Xao5p7gMjZuLtNoyAwWZtFygVSXsWfOOIte6c21Rm/4+S6wTB3DGgU 8FMgtFVSo/iYmnYHOGZICPDyghAkI9f1bgCxoX7s1HyaWymlnpjmbYAg4a520ZLxCMEs 6krQ== X-Gm-Message-State: AOAM533qjl2gqhCvSs7SKZD+9zpK27R1z3zvIpXmsqGQFyc0nIsW00k8 hg5xcXNj8Kjst3KW/ekQrpA= X-Google-Smtp-Source: ABdhPJxz+CTfYBRsr9wPZ8ehDJQEmTq++yYJr4Xo0s0U0R6hQKoUpOmBLcC8LM7TIOPThVoU3WYKbg== X-Received: by 2002:a1c:234b:: with SMTP id j72mr7837172wmj.153.1599732997083; Thu, 10 Sep 2020 03:16:37 -0700 (PDT) Received: from ziggy.stardust ([213.195.113.201]) by smtp.gmail.com with ESMTPSA id a127sm2936155wmh.34.2020.09.10.03.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2020 03:16:36 -0700 (PDT) To: Joe Perches , LKML , Jiri Kosina References: From: Matthias Brugger Message-ID: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> Date: Thu, 10 Sep 2020 12:16:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break; X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, oss-drivers@netronome.com, nouveau@lists.freedesktop.org, alsa-devel , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org, linux-afs@lists.infradead.org, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, linux-atm-general@lists.sourceforge.net, kvmarm@lists.cs.columbia.edu, coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, Kees Cook , linux-media@vger.kernel.org, linux-pm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, storagedev@microchip.com, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nick Desaulniers , linux-nfs@vger.kernel.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sctp@vger.kernel.org, iommu@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4988EC433E2 for ; Thu, 10 Sep 2020 11:01:35 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id B078B214F1 for ; Thu, 10 Sep 2020 11:01:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TyMbFj/C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B078B214F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 456934B44B; Thu, 10 Sep 2020 07:01:34 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@gmail.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tXcxNhPILgPb; Thu, 10 Sep 2020 07:01:33 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id F140A4B478; Thu, 10 Sep 2020 07:01:30 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 19B474B325 for ; Thu, 10 Sep 2020 06:16:39 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NF1fyGQeTDbq for ; Thu, 10 Sep 2020 06:16:38 -0400 (EDT) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 276584B324 for ; Thu, 10 Sep 2020 06:16:38 -0400 (EDT) Received: by mail-wm1-f66.google.com with SMTP id e17so5065532wme.0 for ; Thu, 10 Sep 2020 03:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=TyMbFj/CCKS/yEhzmJyx0SXASPCumWs129eaMWwliNPHoe9nGlJZk2Tsw17ABtL/mL mWke72l5dRMmrFg9ieYmDr1jVfXiMwSmIMEMsNuXAYrMDmbRSlu2SEhpSFeukLVe3cg9 +5O+wBu+Jx7JfEyF9JNwdrWebHIVozT6N0VTqxSNEjrIsLOZ3R3dejl3APk21PLF2Oj8 +Kb8ACZuKGttnfzoDexc2yloyF3/YUcCQzcDsr90PZvO0KOXZEocClY8eSC4NnFPV4xO lvhsU6vpfnm+pvKWrckJN/8r5bLtL/kaV4lfgkeSIGRnLzVQeQ+BBL7u23nOrwhO07G+ JHEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=UzoJ0nJObRk5/OA/cwzPJvDVdguoj39ioSFL0LLKEPlQHLAMuONLE0oNsQQzCCFWAm Kef0CcKS0eomAlwNI73SkMzq7TxnU351SKAsZCZohoF4xiuDpvXws6vE2/IvRub+uyxk oKlhV4UOpwQcfaS0TdY9HZ2uIdaC+0HTgBroJpS2gHNr/9c8en8QNv44mXhcwTqZVpe5 D4LAf5qkTUP49d5Rhpr5FSjdhM3LA1ybRCYzjy99N3Low7WCaSuWSpiwb8DN6wGtKFsB Z7um1tbhUjzAEqYEsgRJz08Nq/aTEXMOUqOkAmV2CNPO4H8Z8UXv1AnaLZNCIqX5sq6p yYrw== X-Gm-Message-State: AOAM5308DPgBMEQ9CP+Y9aOH2mA6riyMfy4NOwTRBPA3OymIiqiGoMWc S6hbwX/GNWZc0U/VakDIkHg= X-Google-Smtp-Source: ABdhPJxz+CTfYBRsr9wPZ8ehDJQEmTq++yYJr4Xo0s0U0R6hQKoUpOmBLcC8LM7TIOPThVoU3WYKbg== X-Received: by 2002:a1c:234b:: with SMTP id j72mr7837172wmj.153.1599732997083; Thu, 10 Sep 2020 03:16:37 -0700 (PDT) Received: from ziggy.stardust ([213.195.113.201]) by smtp.gmail.com with ESMTPSA id a127sm2936155wmh.34.2020.09.10.03.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2020 03:16:36 -0700 (PDT) Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; To: Joe Perches , LKML , Jiri Kosina References: From: Matthias Brugger Message-ID: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> Date: Thu, 10 Sep 2020 12:16:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mailman-Approved-At: Thu, 10 Sep 2020 07:01:29 -0400 Cc: linux-fbdev@vger.kernel.org, oss-drivers@netronome.com, nouveau@lists.freedesktop.org, alsa-devel , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org, linux-afs@lists.infradead.org, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, linux-atm-general@lists.sourceforge.net, kvmarm@lists.cs.columbia.edu, coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, Kees Cook , linux-media@vger.kernel.org, linux-pm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, storagedev@microchip.com, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nick Desaulniers , linux-nfs@vger.kernel.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sctp@vger.kernel.org, iommu@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Date: Thu, 10 Sep 2020 10:16:33 +0000 Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; Message-Id: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches , LKML , Jiri Kosina Cc: linux-wireless@vger.kernel.org, linux-fbdev@vger.kernel.org, oss-drivers@netronome.com, nouveau@lists.freedesktop.org, alsa-devel , dri-devel@lists.freedesktop.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, linux-atm-general@lists.sourceforge.net, linux-afs@lists.infradead.org, coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, Kees Cook , linux-media@vger.kernel.org, linux-pm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-sctp@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, storagedev@microchip.com, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, Nick Desaulniers , linux-mips@vger.kernel.org, iommu@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A200DC433E2 for ; Thu, 10 Sep 2020 10:16:45 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A72E21556 for ; Thu, 10 Sep 2020 10:16:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TyMbFj/C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A72E21556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id A6276875BB; Thu, 10 Sep 2020 10:16:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id brbPiD9j7f0a; Thu, 10 Sep 2020 10:16:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id C91EF875B7; Thu, 10 Sep 2020 10:16:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AF51BC0859; Thu, 10 Sep 2020 10:16:41 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 25410C0051 for ; Thu, 10 Sep 2020 10:16:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 027B22E189 for ; Thu, 10 Sep 2020 10:16:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tI7usHdSuDpn for ; Thu, 10 Sep 2020 10:16:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by silver.osuosl.org (Postfix) with ESMTPS id 9F49220516 for ; Thu, 10 Sep 2020 10:16:38 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id s13so5065193wmh.4 for ; Thu, 10 Sep 2020 03:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=TyMbFj/CCKS/yEhzmJyx0SXASPCumWs129eaMWwliNPHoe9nGlJZk2Tsw17ABtL/mL mWke72l5dRMmrFg9ieYmDr1jVfXiMwSmIMEMsNuXAYrMDmbRSlu2SEhpSFeukLVe3cg9 +5O+wBu+Jx7JfEyF9JNwdrWebHIVozT6N0VTqxSNEjrIsLOZ3R3dejl3APk21PLF2Oj8 +Kb8ACZuKGttnfzoDexc2yloyF3/YUcCQzcDsr90PZvO0KOXZEocClY8eSC4NnFPV4xO lvhsU6vpfnm+pvKWrckJN/8r5bLtL/kaV4lfgkeSIGRnLzVQeQ+BBL7u23nOrwhO07G+ JHEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=nUgubN1CAXKDUn43VDOTvS8NTgkns+ZTPQiphzCSx1RYOIutRHmtErM4kyKMaYDA/W DNHQTudu9QqWfV9uB6UrDiPrBRECov22xwr9LmeE33QJ9tYjS7UkTEigpJUaqJ89VY/f gXpjiZy/5KR4ddBFhMLUfTDPDSNi+5sSI1gIEphy6YQN3WmbM0Owdh8kQxvL+mY+qLRG Kf9qZgl7OdA2jWycKHdo+16RUMXpstxFwW6yCIv6qVLLbaWv/9r+OUmpdjPwWj0b6Cn7 aB29X6VRuOtGREdq6Sid1HLIG2N/4X+vEEKHkyDcpDONVCfI2XktSpMdExjuzji0Wa2t Qn3g== X-Gm-Message-State: AOAM531u/o9QLZBXWtfKKsy/5hna7JminlIHoIWb/FWJtfczDTIn0wkL 5WRhXcC6yNK/Hb2BAZQGzsw= X-Google-Smtp-Source: ABdhPJxz+CTfYBRsr9wPZ8ehDJQEmTq++yYJr4Xo0s0U0R6hQKoUpOmBLcC8LM7TIOPThVoU3WYKbg== X-Received: by 2002:a1c:234b:: with SMTP id j72mr7837172wmj.153.1599732997083; Thu, 10 Sep 2020 03:16:37 -0700 (PDT) Received: from ziggy.stardust ([213.195.113.201]) by smtp.gmail.com with ESMTPSA id a127sm2936155wmh.34.2020.09.10.03.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2020 03:16:36 -0700 (PDT) Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; To: Joe Perches , LKML , Jiri Kosina References: From: Matthias Brugger Message-ID: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> Date: Thu, 10 Sep 2020 12:16:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: linux-fbdev@vger.kernel.org, oss-drivers@netronome.com, nouveau@lists.freedesktop.org, alsa-devel , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org, linux-afs@lists.infradead.org, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, linux-atm-general@lists.sourceforge.net, kvmarm@lists.cs.columbia.edu, coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, Kees Cook , linux-media@vger.kernel.org, linux-pm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, storagedev@microchip.com, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nick Desaulniers , linux-nfs@vger.kernel.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sctp@vger.kernel.org, iommu@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B4C4C43461 for ; Thu, 10 Sep 2020 10:16:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDA2D21D7E for ; Thu, 10 Sep 2020 10:16:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qMIl93kp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TyMbFj/C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDA2D21D7E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6HVpLc0DUJn5w0rOtv3WSSaKsrq8xuwe+Xk6C4AWfXQ=; b=qMIl93kp1GZ4vl7yODoh/2DYM S6uYins63xDmJ2FgsHssP59ZuySycElXmMI9XjoNpkKgG/Mf6zwdqedX4MZphZQhHebwLoGiTHAUW 9gX3fqtXEoXdSsVoPMBkoycSh54sdPV2IW1ld9Xj51aPyHaMlgxweQuR6C8TIgVN//PCJ084eHeyH gUz5d0W0rlVg8+qQ0y9jzF6yeknCJ3G6svBZkaDJ1gU+ekGAFUanB37dHO3QMaeCoHP9mnj561Dbk 5IqULqMMFFSZKm+wjvuddKlnxhBWCo8Kdhq3xZwSDSNQbGgHst4OqQ278t1o9yd/wLgX+EBX5Pl3o txYY8Evqw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGJdG-0000mI-Jl; Thu, 10 Sep 2020 10:16:46 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGJd9-0000in-Ol; Thu, 10 Sep 2020 10:16:40 +0000 Received: by mail-wm1-x341.google.com with SMTP id q9so5076340wmj.2; Thu, 10 Sep 2020 03:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=TyMbFj/CCKS/yEhzmJyx0SXASPCumWs129eaMWwliNPHoe9nGlJZk2Tsw17ABtL/mL mWke72l5dRMmrFg9ieYmDr1jVfXiMwSmIMEMsNuXAYrMDmbRSlu2SEhpSFeukLVe3cg9 +5O+wBu+Jx7JfEyF9JNwdrWebHIVozT6N0VTqxSNEjrIsLOZ3R3dejl3APk21PLF2Oj8 +Kb8ACZuKGttnfzoDexc2yloyF3/YUcCQzcDsr90PZvO0KOXZEocClY8eSC4NnFPV4xO lvhsU6vpfnm+pvKWrckJN/8r5bLtL/kaV4lfgkeSIGRnLzVQeQ+BBL7u23nOrwhO07G+ JHEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=otNNKJ5MLUewBFGa9tsqv2ILTTX/tf/p6k4v9+dxpo7MRzdzDTlE5HKVnMLF2D4QO8 +uQJIHAb7a4KTolnjqwE2CuGZalwTFHBdOsyOcxC5Q/UkvffI0mt6NGtULO16y1L/iB2 jtWuMkOst61JEtlREWP/Ehf46WrvYbRsahfInbak08f7gc7DIxB+g9iLyKmQLaj/hNkQ LJ07/Tx2z6RMzoXvUSuAlioStlIQ3kb1ExDUsZrawf6zNZfj5I1UAFRIVJLnarqhN8pl 15oOVe9940yoEg5h7fe8z376UQimtsZYTWQv+E6KhbB3OI7qreeAoYM/VVCUAek4Sodl OC9A== X-Gm-Message-State: AOAM530DCQ7beeB0HOqn8gbGXA30kXIORzHyyPpcZ+vE/Fn2NBjFyEXh SWawOgPXlP4NpeLVi1WHmJ8= X-Google-Smtp-Source: ABdhPJxz+CTfYBRsr9wPZ8ehDJQEmTq++yYJr4Xo0s0U0R6hQKoUpOmBLcC8LM7TIOPThVoU3WYKbg== X-Received: by 2002:a1c:234b:: with SMTP id j72mr7837172wmj.153.1599732997083; Thu, 10 Sep 2020 03:16:37 -0700 (PDT) Received: from ziggy.stardust ([213.195.113.201]) by smtp.gmail.com with ESMTPSA id a127sm2936155wmh.34.2020.09.10.03.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2020 03:16:36 -0700 (PDT) Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; To: Joe Perches , LKML , Jiri Kosina References: From: Matthias Brugger Message-ID: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> Date: Thu, 10 Sep 2020 12:16:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_061639_865898_8F58C388 X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, oss-drivers@netronome.com, nouveau@lists.freedesktop.org, alsa-devel , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org, linux-afs@lists.infradead.org, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, linux-atm-general@lists.sourceforge.net, kvmarm@lists.cs.columbia.edu, coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, Kees Cook , linux-media@vger.kernel.org, linux-pm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, storagedev@microchip.com, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nick Desaulniers , linux-nfs@vger.kernel.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sctp@vger.kernel.org, iommu@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381FAC43461 for ; Thu, 10 Sep 2020 10:17:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8C2A2078E for ; Thu, 10 Sep 2020 10:17:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c1Rzg0b9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TyMbFj/C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8C2A2078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gRKLgt5LCh83Mx/zu656Q9jHdspKkO5HY9yPBhj0Hv0=; b=c1Rzg0b95lWOddQ8/jO3dB9aW VuopxHgMXHs1zFM6RdWDD5xHXJc+hSJ2Hrehhk/lghGNGis5qlCdfOje5BMu0FWUWPg3ZxZUYEsKG POUezWV21AjDcvBw6Is2QvwFZtbrThdl53aVMxWPPc0hHKTMfQpHSMQntHcet1JUDkK0zPtprcRL4 A4OkbWDSjXLhThGZfvmRD/EkfFLFMZeTQq2EazWu7LoYDj8n+2JIiFN8oKHxsyHO1h5gaYvUbRSjH EWvDwqLbVjTsqeHr04Cf7ohRX99m/FVidr79I89pspvbaIu8/YM2gqPQuQf/1/NZUxQA3nRCYh0SI fBW8TZJfA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGJdI-0000mv-7w; Thu, 10 Sep 2020 10:16:48 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGJd9-0000in-Ol; Thu, 10 Sep 2020 10:16:40 +0000 Received: by mail-wm1-x341.google.com with SMTP id q9so5076340wmj.2; Thu, 10 Sep 2020 03:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=TyMbFj/CCKS/yEhzmJyx0SXASPCumWs129eaMWwliNPHoe9nGlJZk2Tsw17ABtL/mL mWke72l5dRMmrFg9ieYmDr1jVfXiMwSmIMEMsNuXAYrMDmbRSlu2SEhpSFeukLVe3cg9 +5O+wBu+Jx7JfEyF9JNwdrWebHIVozT6N0VTqxSNEjrIsLOZ3R3dejl3APk21PLF2Oj8 +Kb8ACZuKGttnfzoDexc2yloyF3/YUcCQzcDsr90PZvO0KOXZEocClY8eSC4NnFPV4xO lvhsU6vpfnm+pvKWrckJN/8r5bLtL/kaV4lfgkeSIGRnLzVQeQ+BBL7u23nOrwhO07G+ JHEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=otNNKJ5MLUewBFGa9tsqv2ILTTX/tf/p6k4v9+dxpo7MRzdzDTlE5HKVnMLF2D4QO8 +uQJIHAb7a4KTolnjqwE2CuGZalwTFHBdOsyOcxC5Q/UkvffI0mt6NGtULO16y1L/iB2 jtWuMkOst61JEtlREWP/Ehf46WrvYbRsahfInbak08f7gc7DIxB+g9iLyKmQLaj/hNkQ LJ07/Tx2z6RMzoXvUSuAlioStlIQ3kb1ExDUsZrawf6zNZfj5I1UAFRIVJLnarqhN8pl 15oOVe9940yoEg5h7fe8z376UQimtsZYTWQv+E6KhbB3OI7qreeAoYM/VVCUAek4Sodl OC9A== X-Gm-Message-State: AOAM530DCQ7beeB0HOqn8gbGXA30kXIORzHyyPpcZ+vE/Fn2NBjFyEXh SWawOgPXlP4NpeLVi1WHmJ8= X-Google-Smtp-Source: ABdhPJxz+CTfYBRsr9wPZ8ehDJQEmTq++yYJr4Xo0s0U0R6hQKoUpOmBLcC8LM7TIOPThVoU3WYKbg== X-Received: by 2002:a1c:234b:: with SMTP id j72mr7837172wmj.153.1599732997083; Thu, 10 Sep 2020 03:16:37 -0700 (PDT) Received: from ziggy.stardust ([213.195.113.201]) by smtp.gmail.com with ESMTPSA id a127sm2936155wmh.34.2020.09.10.03.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2020 03:16:36 -0700 (PDT) Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; To: Joe Perches , LKML , Jiri Kosina References: From: Matthias Brugger Message-ID: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> Date: Thu, 10 Sep 2020 12:16:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_061639_865898_8F58C388 X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, oss-drivers@netronome.com, nouveau@lists.freedesktop.org, alsa-devel , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org, linux-afs@lists.infradead.org, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, linux-atm-general@lists.sourceforge.net, kvmarm@lists.cs.columbia.edu, coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, Kees Cook , linux-media@vger.kernel.org, linux-pm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, storagedev@microchip.com, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nick Desaulniers , linux-nfs@vger.kernel.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sctp@vger.kernel.org, iommu@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C8EFC433E2 for ; Thu, 10 Sep 2020 10:18:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 562962078E for ; Thu, 10 Sep 2020 10:18:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TyMbFj/C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 562962078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BnFGM0CnGzDqY1 for ; Thu, 10 Sep 2020 20:18:35 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=matthias.bgg@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=TyMbFj/C; dkim-atps=neutral Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BnFDG676mzDqXw for ; Thu, 10 Sep 2020 20:16:43 +1000 (AEST) Received: by mail-wm1-x342.google.com with SMTP id l9so5223930wme.3 for ; Thu, 10 Sep 2020 03:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=TyMbFj/CCKS/yEhzmJyx0SXASPCumWs129eaMWwliNPHoe9nGlJZk2Tsw17ABtL/mL mWke72l5dRMmrFg9ieYmDr1jVfXiMwSmIMEMsNuXAYrMDmbRSlu2SEhpSFeukLVe3cg9 +5O+wBu+Jx7JfEyF9JNwdrWebHIVozT6N0VTqxSNEjrIsLOZ3R3dejl3APk21PLF2Oj8 +Kb8ACZuKGttnfzoDexc2yloyF3/YUcCQzcDsr90PZvO0KOXZEocClY8eSC4NnFPV4xO lvhsU6vpfnm+pvKWrckJN/8r5bLtL/kaV4lfgkeSIGRnLzVQeQ+BBL7u23nOrwhO07G+ JHEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=jX8QhaDtJvVyTXi4XlI3ad3i186uryzm4qcNkzTV3mrhNLGfEwSwRVWBtDAH/hEw1O M26fiWm6Qnpl2yZe8GEnp2WAi3pkIOk2A7G9sd6Zgt5hEWTM4kDSu0ZOFsPyYd7wCuTY rTBBE3KywagPsi5snzj3t7SJy2ftJvbLl5qU+q6pqIxFWDvX7o4R4OLyurVmebhyF0vc 6bS6dz6SHnajUVoIlIuR4U2cduJz9ag8bsxCnu/kaldMjLROCQ9R3pSUY9Ghc6LH+G/P ebPKzPjB+EcycyPUZ9AU0Pqevizo3IvhJCmR99NibPGpQqcaQCzpBpOq/NVbY0pvTvIi sz/w== X-Gm-Message-State: AOAM530WTX7CoxxYD3IF2nekz83sP+Rank+urCr3cLo4ccfzplutsGAk ALRnY8n4WtCTSOk/4iT1Wmvfl05QCE5gXA== X-Google-Smtp-Source: ABdhPJxz+CTfYBRsr9wPZ8ehDJQEmTq++yYJr4Xo0s0U0R6hQKoUpOmBLcC8LM7TIOPThVoU3WYKbg== X-Received: by 2002:a1c:234b:: with SMTP id j72mr7837172wmj.153.1599732997083; Thu, 10 Sep 2020 03:16:37 -0700 (PDT) Received: from ziggy.stardust ([213.195.113.201]) by smtp.gmail.com with ESMTPSA id a127sm2936155wmh.34.2020.09.10.03.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2020 03:16:36 -0700 (PDT) Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; To: Joe Perches , LKML , Jiri Kosina References: From: Matthias Brugger Message-ID: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> Date: Thu, 10 Sep 2020 12:16:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, oss-drivers@netronome.com, nouveau@lists.freedesktop.org, alsa-devel , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org, linux-afs@lists.infradead.org, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, linux-atm-general@lists.sourceforge.net, kvmarm@lists.cs.columbia.edu, coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, Kees Cook , linux-media@vger.kernel.org, linux-pm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, storagedev@microchip.com, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nick Desaulniers , linux-nfs@vger.kernel.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sctp@vger.kernel.org, iommu@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 455C2C43461 for ; Thu, 10 Sep 2020 10:18:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D07BD2078E for ; Thu, 10 Sep 2020 10:18:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BBnE8OLD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TyMbFj/C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D07BD2078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1XMxarM4Zn7OzDPWkpBj1Nv+aSgohFDgKFLWrgYex4Q=; b=BBnE8OLDoinFgtN/NCqlH5Nuq C+i4MuG/PnQsLZVC0ESUA69Ls93ZIPx96kZEiU9piZBQXaI9i6cSixnnUaQBDTllNBltKh2GEJUbG aQSJWn2pO54HcN7W7xv2V8thBbCbYKGDfd+WekcmXmpvVtn0yGWWoGRJlv1/K3zwmxdDmDqI139K2 giAkhK7pFszFqjvoY/H5n/CA2HqlE6QyTh1lSQU1w+57egPFV7zNQjivd32hgYODOuJrreiEaoIQs uErVw9rFrXbG1QByuq8xaR5pfWKbp073+4n/XbLfVE5aBaaknlnjyYvtRqzrjHj17bcth1dMIuoge 6wFxglPpw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGJdC-0000k3-VR; Thu, 10 Sep 2020 10:16:43 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGJd9-0000in-Ol; Thu, 10 Sep 2020 10:16:40 +0000 Received: by mail-wm1-x341.google.com with SMTP id q9so5076340wmj.2; Thu, 10 Sep 2020 03:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=TyMbFj/CCKS/yEhzmJyx0SXASPCumWs129eaMWwliNPHoe9nGlJZk2Tsw17ABtL/mL mWke72l5dRMmrFg9ieYmDr1jVfXiMwSmIMEMsNuXAYrMDmbRSlu2SEhpSFeukLVe3cg9 +5O+wBu+Jx7JfEyF9JNwdrWebHIVozT6N0VTqxSNEjrIsLOZ3R3dejl3APk21PLF2Oj8 +Kb8ACZuKGttnfzoDexc2yloyF3/YUcCQzcDsr90PZvO0KOXZEocClY8eSC4NnFPV4xO lvhsU6vpfnm+pvKWrckJN/8r5bLtL/kaV4lfgkeSIGRnLzVQeQ+BBL7u23nOrwhO07G+ JHEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=otNNKJ5MLUewBFGa9tsqv2ILTTX/tf/p6k4v9+dxpo7MRzdzDTlE5HKVnMLF2D4QO8 +uQJIHAb7a4KTolnjqwE2CuGZalwTFHBdOsyOcxC5Q/UkvffI0mt6NGtULO16y1L/iB2 jtWuMkOst61JEtlREWP/Ehf46WrvYbRsahfInbak08f7gc7DIxB+g9iLyKmQLaj/hNkQ LJ07/Tx2z6RMzoXvUSuAlioStlIQ3kb1ExDUsZrawf6zNZfj5I1UAFRIVJLnarqhN8pl 15oOVe9940yoEg5h7fe8z376UQimtsZYTWQv+E6KhbB3OI7qreeAoYM/VVCUAek4Sodl OC9A== X-Gm-Message-State: AOAM530DCQ7beeB0HOqn8gbGXA30kXIORzHyyPpcZ+vE/Fn2NBjFyEXh SWawOgPXlP4NpeLVi1WHmJ8= X-Google-Smtp-Source: ABdhPJxz+CTfYBRsr9wPZ8ehDJQEmTq++yYJr4Xo0s0U0R6hQKoUpOmBLcC8LM7TIOPThVoU3WYKbg== X-Received: by 2002:a1c:234b:: with SMTP id j72mr7837172wmj.153.1599732997083; Thu, 10 Sep 2020 03:16:37 -0700 (PDT) Received: from ziggy.stardust ([213.195.113.201]) by smtp.gmail.com with ESMTPSA id a127sm2936155wmh.34.2020.09.10.03.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2020 03:16:36 -0700 (PDT) Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; To: Joe Perches , LKML , Jiri Kosina References: From: Matthias Brugger Message-ID: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> Date: Thu, 10 Sep 2020 12:16:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_061639_865898_8F58C388 X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, oss-drivers@netronome.com, nouveau@lists.freedesktop.org, alsa-devel , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org, linux-afs@lists.infradead.org, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, linux-atm-general@lists.sourceforge.net, kvmarm@lists.cs.columbia.edu, coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, Kees Cook , linux-media@vger.kernel.org, linux-pm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, storagedev@microchip.com, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nick Desaulniers , linux-nfs@vger.kernel.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sctp@vger.kernel.org, iommu@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D8EC433E2 for ; Thu, 10 Sep 2020 10:16:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 831352078E for ; Thu, 10 Sep 2020 10:16:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TyMbFj/C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 831352078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A76026E8F1; Thu, 10 Sep 2020 10:16:39 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64FFA89DFE; Thu, 10 Sep 2020 10:16:38 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id z9so5237876wmk.1; Thu, 10 Sep 2020 03:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=TyMbFj/CCKS/yEhzmJyx0SXASPCumWs129eaMWwliNPHoe9nGlJZk2Tsw17ABtL/mL mWke72l5dRMmrFg9ieYmDr1jVfXiMwSmIMEMsNuXAYrMDmbRSlu2SEhpSFeukLVe3cg9 +5O+wBu+Jx7JfEyF9JNwdrWebHIVozT6N0VTqxSNEjrIsLOZ3R3dejl3APk21PLF2Oj8 +Kb8ACZuKGttnfzoDexc2yloyF3/YUcCQzcDsr90PZvO0KOXZEocClY8eSC4NnFPV4xO lvhsU6vpfnm+pvKWrckJN/8r5bLtL/kaV4lfgkeSIGRnLzVQeQ+BBL7u23nOrwhO07G+ JHEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DqY3ytm1lW24L4dBr5ZhfVe1Kl4JG7b6aElJixa0DtQ=; b=nH0yUAovvhubPl6sBUwBrs2sJB+5Xq2akRghDHpweg6/kgxahhKiBNCcRHONYke6JV TNaI8PJRrI5Quu9Yhvo7PqDIhsMswRX7d0/zm0oRMLnRxOm1roeOJhNfS8RtqfYco6rJ 6kYa887RZZ3IZ1PMCm3uj1SOFkhSYUPRXncTlhUBMOJP5vX4UNRVLu0DS7zo7/0fnIpg BR8BbfaMHa+yM0Xao5p7gMjZuLtNoyAwWZtFygVSXsWfOOIte6c21Rm/4+S6wTB3DGgU 8FMgtFVSo/iYmnYHOGZICPDyghAkI9f1bgCxoX7s1HyaWymlnpjmbYAg4a520ZLxCMEs 6krQ== X-Gm-Message-State: AOAM533qjl2gqhCvSs7SKZD+9zpK27R1z3zvIpXmsqGQFyc0nIsW00k8 hg5xcXNj8Kjst3KW/ekQrpA= X-Google-Smtp-Source: ABdhPJxz+CTfYBRsr9wPZ8ehDJQEmTq++yYJr4Xo0s0U0R6hQKoUpOmBLcC8LM7TIOPThVoU3WYKbg== X-Received: by 2002:a1c:234b:: with SMTP id j72mr7837172wmj.153.1599732997083; Thu, 10 Sep 2020 03:16:37 -0700 (PDT) Received: from ziggy.stardust ([213.195.113.201]) by smtp.gmail.com with ESMTPSA id a127sm2936155wmh.34.2020.09.10.03.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2020 03:16:36 -0700 (PDT) Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; To: Joe Perches , LKML , Jiri Kosina References: From: Matthias Brugger Message-ID: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> Date: Thu, 10 Sep 2020 12:16:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, oss-drivers@netronome.com, nouveau@lists.freedesktop.org, alsa-devel , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org, linux-afs@lists.infradead.org, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, linux-atm-general@lists.sourceforge.net, kvmarm@lists.cs.columbia.edu, coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, Kees Cook , linux-media@vger.kernel.org, linux-pm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, storagedev@microchip.com, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nick Desaulniers , linux-nfs@vger.kernel.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sctp@vger.kernel.org, iommu@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 09/09/2020 22:06, Joe Perches wrote: > diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c > index 09f931d4598c..778be26d329f 100644 > --- a/drivers/net/wireless/mediatek/mt7601u/dma.c > +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c > @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "rx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } > > @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb) > case -ESHUTDOWN: > case -ENOENT: > return; > + case 0: > + break; > default: > dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", > urb->status); > - fallthrough; > - case 0: > break; > } Reviewed-by: Matthias Brugger _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel