All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <Okaya@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Vasily Gorbik <gor@linux.ibm.com>, Adrian Reber <adrian@lisas.de>,
	Richard Guy Briggs <rgb@redhat.com>
Subject: Re: [PATCH v1] init: Do not select DEBUG_KERNEL by default
Date: Wed, 10 Apr 2019 18:29:23 -0400	[thread overview]
Message-ID: <81ef488c-ab39-59db-86e7-e36391caebd8@kernel.org> (raw)
In-Reply-To: <CAGXu5j+Qz4RTeXR8UYqoYnQtLf42QLn5duUue_OmdKQKq7MeZw@mail.gmail.com>

On 4/10/2019 6:28 PM, Kees Cook wrote:
> diff --git a/init/Kconfig b/init/Kconfig
> index c9386a365eea..7ce4a60ab3e9 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1188,8 +1188,6 @@ config BPF
> 
>   menuconfig EXPERT
>          bool "Configure standard kernel features (expert users)"
> -       # Unhide debug options, to make the on-by-default options visible
> -       select DEBUG_KERNEL
>          help
>            This option allows certain base kernel options and settings
>             to be disabled or tweaked. This is for specialized
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index d4df5b24d75e..6a9bc118b64a 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -433,6 +433,7 @@ config MAGIC_SYSRQ_SERIAL
> 
>   config DEBUG_KERNEL
>          bool "Kernel debugging"
> +       default EXPERT
>          help
>            Say Y here if you are developing drivers or trying to debug and
>            identify kernel problems.

Got it. Thanks. I'll test and respin v2.

      reply	other threads:[~2019-04-10 22:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10 21:26 [PATCH v1] init: Do not select DEBUG_KERNEL by default Sinan Kaya
2019-04-10 21:45 ` Kees Cook
2019-04-10 21:53   ` Sinan Kaya
2019-04-10 22:04     ` Mathieu Desnoyers
2019-04-10 22:07       ` Kees Cook
2019-04-10 22:04     ` Kees Cook
2019-04-10 22:18       ` Sinan Kaya
2019-04-10 22:21         ` Kees Cook
2019-04-10 22:25           ` Sinan Kaya
2019-04-10 22:28             ` Kees Cook
2019-04-10 22:29               ` Sinan Kaya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81ef488c-ab39-59db-86e7-e36391caebd8@kernel.org \
    --to=okaya@kernel.org \
    --cc=adrian@lisas.de \
    --cc=akpm@linux-foundation.org \
    --cc=gor@linux.ibm.com \
    --cc=hannes@cmpxchg.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=npiggin@gmail.com \
    --cc=peterz@infradead.org \
    --cc=rgb@redhat.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.