From: Kever Yang <kever.yang@rock-chips.com>
To: Quentin Schulz <foss+uboot@0leil.net>,
Klaus Goger <klaus.goger@cherry.de>,
Heiko Stuebner <heiko.stuebner@cherry.de>,
Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH] rockchip: theobroma-systems: use HAVE_VENDOR_COMMON_LIB to simplify Makefile
Date: Wed, 5 Feb 2025 11:13:17 +0800 [thread overview]
Message-ID: <82002bf1-ce13-4e5a-8efc-256e4c237aa9@rock-chips.com> (raw)
In-Reply-To: <20250129-tsd-have_vendor_common_lib-v1-1-631525b51458@cherry.de>
On 2025/1/29 23:24, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@cherry.de>
>
> The build system uses HAVE_VENDOR_COMMON_LIB to automatically include
> board/$(VENDOR)/common/Makefile, therefore let's use that to implicitly
> include board/theobroma-systems/common/Makefile and compile the common.c
> file when building proper.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> board/theobroma-systems/common/Makefile | 9 +++++++++
> board/theobroma-systems/jaguar_rk3588/Makefile | 3 ---
> board/theobroma-systems/puma_rk3399/Makefile | 3 ---
> board/theobroma-systems/ringneck_px30/Makefile | 3 ---
> board/theobroma-systems/tiger_rk3588/Makefile | 3 ---
> 5 files changed, 9 insertions(+), 12 deletions(-)
>
> diff --git a/board/theobroma-systems/common/Makefile b/board/theobroma-systems/common/Makefile
> new file mode 100644
> index 0000000000000000000000000000000000000000..c1cadb4b913e8da8bc182f8142b16b2443891343
> --- /dev/null
> +++ b/board/theobroma-systems/common/Makefile
> @@ -0,0 +1,9 @@
> +#
> +# Copyright (c) 2025 Cherry Embedded Solutions GmbH
> +#
> +# SPDX-License-Identifier: GPL-2.0+
> +#
> +
> +ifneq ($(CONFIG_XPL_BUILD),y)
> +obj-y += common.o
> +endif
> diff --git a/board/theobroma-systems/jaguar_rk3588/Makefile b/board/theobroma-systems/jaguar_rk3588/Makefile
> index d43bf194b687cacc556491ecc9041c4da8fd207c..38b73d2846c48f8afad31349d0cf3c593969366e 100644
> --- a/board/theobroma-systems/jaguar_rk3588/Makefile
> +++ b/board/theobroma-systems/jaguar_rk3588/Makefile
> @@ -5,6 +5,3 @@
> #
>
> obj-y += jaguar_rk3588.o
> -ifneq ($(CONFIG_XPL_BUILD),y)
> -obj-y += ../common/common.o
> -endif
> diff --git a/board/theobroma-systems/puma_rk3399/Makefile b/board/theobroma-systems/puma_rk3399/Makefile
> index 2256e72cda1986ffa9502447a5d7d975eaea504b..d962b56f11123afe4573b64b0d8728fc0a0aa576 100644
> --- a/board/theobroma-systems/puma_rk3399/Makefile
> +++ b/board/theobroma-systems/puma_rk3399/Makefile
> @@ -5,6 +5,3 @@
> #
>
> obj-y += puma-rk3399.o
> -ifneq ($(CONFIG_XPL_BUILD),y)
> -obj-y += ../common/common.o
> -endif
> diff --git a/board/theobroma-systems/ringneck_px30/Makefile b/board/theobroma-systems/ringneck_px30/Makefile
> index 4d108f2d011f07d0fff141158af39a55726348f7..31ada1a69422cdb7bb85bc6c737e2a98187bc62c 100644
> --- a/board/theobroma-systems/ringneck_px30/Makefile
> +++ b/board/theobroma-systems/ringneck_px30/Makefile
> @@ -5,6 +5,3 @@
> #
>
> obj-y += ringneck-px30.o
> -ifneq ($(CONFIG_XPL_BUILD),y)
> -obj-y += ../common/common.o
> -endif
> diff --git a/board/theobroma-systems/tiger_rk3588/Makefile b/board/theobroma-systems/tiger_rk3588/Makefile
> index 94b0859eb356c31c3358c453ae46ea8cc64a50c0..900647735fb129fc9252a1cb14ed19d74e8026a0 100644
> --- a/board/theobroma-systems/tiger_rk3588/Makefile
> +++ b/board/theobroma-systems/tiger_rk3588/Makefile
> @@ -5,6 +5,3 @@
> #
>
> obj-y += tiger_rk3588.o
> -ifneq ($(CONFIG_XPL_BUILD),y)
> -obj-y += ../common/common.o
> -endif
>
> ---
> base-commit: a2b489b170f8382f746202c36616eaf2bc38fe86
> change-id: 20250129-tsd-have_vendor_common_lib-42c4dd70c3e4
>
> Best regards,
prev parent reply other threads:[~2025-02-05 3:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 15:24 [PATCH] rockchip: theobroma-systems: use HAVE_VENDOR_COMMON_LIB to simplify Makefile Quentin Schulz
2025-02-05 3:13 ` Kever Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82002bf1-ce13-4e5a-8efc-256e4c237aa9@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=foss+uboot@0leil.net \
--cc=heiko.stuebner@cherry.de \
--cc=klaus.goger@cherry.de \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.