From: vadim.fedorenko@linux.dev
To: "Eric Joyner" <eric.joyner@amd.com>, netdev@vger.kernel.org
Cc: "Brett Creeley" <brett.creeley@amd.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Nikhil P . Rao" <nikhil.rao@amd.com>
Subject: Re: [PATCH net-next] ionic: Add .get_fec_stats ethtool handler
Date: Fri, 14 Aug 2026 12:14:28 +0000 [thread overview]
Message-ID: <8213af42c3779472a1e1480a8a3fbbcfde6fe03f@linux.dev> (raw)
In-Reply-To: <a834d76e-9b31-4241-9442-0a69ab96cfc1@amd.com>
On 14/08/2026 05:42, Eric Joyner wrote:
> On 8/4/2026 3:27 AM, Vadim Fedorenko wrote:
>> Caution: This message originated from an External Source. Use proper caution
>> when opening attachments, clicking links, or responding.
>>
>>
>> On 31/07/2026 22:40, Eric Joyner wrote:
>>> Reports FEC statistics totals and an 802.3ck FEC histogram. Per-lane counts
>>> currently aren't supported, and the only expected histogram format from
>>> firmware is the one with 16 bins from RS(544,514) FEC.
>>
>> does it mean the FW will return IONIC_STAT_INVALID for 100G CWDM4 mode
>> on newest devices?
>>
>>
> > The only device we have that supports reporting these FEC histograms doesn't
> have a PHY that supports 100G CWDM4; the IP block for it only supports PAM4
> media types and not NRZ. So for now, it would return IONIC_STAT_INVALID for
> that mode.
> > Though, I don't know if that'll be the case for future devices; maybe they will
> support FEC histogram stat collection with NRZ media that has fewer than 16
> histogram bins. I just don't know if it's worth supporting that possibility
> right now since I don't know when or if that will happen.
Ok, thanks for explaining.
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
prev parent reply other threads:[~2026-08-14 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 21:40 [PATCH net-next] ionic: Add .get_fec_stats ethtool handler Eric Joyner
2026-08-04 10:27 ` Vadim Fedorenko
2026-08-14 4:42 ` Eric Joyner
2026-08-14 12:14 ` vadim.fedorenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8213af42c3779472a1e1480a8a3fbbcfde6fe03f@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.joyner@amd.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikhil.rao@amd.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.