Re: [PATCH 3/4] drm/xe/pcode: Improve pcode timeout logging

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 8/6/2026 1:00 PM, Mallesh Koujalagi wrote:
> Use xe_log_err() for pcode timeout errors instead of drm_err(). This

s/pcode/PCODE ?
> adds PCODE component tag, making timeout issues easier to detect and
> track with automated tools.
> 
> Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pcode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
> index c492737242d3..b5a59a227167 100644
> --- a/drivers/gpu/drm/xe/xe_pcode.c
> +++ b/drivers/gpu/drm/xe/xe_pcode.c
> @@ -220,8 +220,8 @@ int xe_pcode_request(struct xe_tile *tile, u32 mbox, u32 request,
>  	 * requests, and for any quirks of the PCODE firmware that delays
>  	 * the request completion.
>  	 */
> -	drm_err(&tile_to_xe(tile)->drm,
> -		"PCODE timeout, retrying with preemption disabled\n");
> +	xe_log_err(tile, PCODE, -ETIMEDOUT,
> +		   "PCODE timeout, retrying with preemption disabled\n");

drop the "PCODE" prefix, as xe_log_err() will decorate dmesg with "PCODE: " for you

>  	preempt_disable();
>  	ret = pcode_try_request(tile, mbox, request, reply_mask, reply, &status,
>  				true, 50 * 1000, true);