All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Sven Eckelmann <sven.eckelmann@openmesh.com>
Cc: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>,
	akolli@codeaurora.org,
	Tamizh chelvam <tamizhchelvam@codeaurora.org>,
	ath10k@lists.infradead.org, shashidhar.lakkavalli@openmesh.com
Subject: Re: QCA4019: calibration files and board files
Date: Tue, 28 Feb 2017 19:22:32 -0800	[thread overview]
Message-ID: <821ad665d0934c58fc8b3c830e119433@codeaurora.org> (raw)
In-Reply-To: <1884460.SDYHzsflKl@bentobox>

On 2017-02-27 23:58, Sven Eckelmann wrote:
> It looks to me now that this information is contradicting your 
> implementation
> (which now loads the data from 0:ART partition [1] like pre-cal data 
> [2] and
> then loads the board-2.bin [3]).
> 
Both reading from ART and loading pre-cal data file are same.

> I have doubt regarding his explanation but I got no actual spec - only
> information which seems to be contradicting (or to vague) . Is is 
> possible
> to get some confirmation from you about whether the data from the 0:ART
> partition is pre-cal data or not and whether the board-2.bin should be
> used when the data from 0:ART is used.
> 
In QCA4019 platform, only radio specific calibration (pre-cal-data) is 
stored in flash.
Board specific contents are read from board-2.bin. For each radio 
appropriate board
data should be loaded. To fetch correct board data from board-2.bin 
bundle, pre-cal/radio
specific caldata should be loaded first to get proper board id.

> My understanding until now was that:
> 
>  * pre-cal data + board-2.bin info == actual calibration data
> 
Correct.

>  * pre-cal data == some incomplete calibration data from somewhere else
>                    (he never specified it - just that it exists)
>  * calibration data == incomplete calibration data from 0:ART
>                        (what I've described in the past as pre-cal 
> data)
>  * (pre-cal or calibration data) + board-2.bin info == actual 
> calibration data
> 
> Would be nice if this confusion could be cleared up by you.
> 
Following methods are used to read radio specific caldata.

1) In some platform which lags DT support, init.d script is used to read
the calibrations content from flash memory and write it in file system 
at boot time.
This is done by dd command.

2) DT entry “qcom,ath10k-pre-calibration-data" is used to pass 
calibration data
from flash to driver. But it needs CoreBSB support to transfer the 
contents from
flash to device tree.

qcom,pre-calibration-data ==> only radio specific calibration.
qcom,calibration-data ==> {radio specific + board specific calibration}.

3) Reading calibration data directly from ART partition by mtd_read 
operation. This one
can be removed from QSDK either by init script or by DT support.

"qcom,calibration-data" is used for qca988x on AP148 plaform. Here 
calibration data mean
both radio + board contents. Always calibration content are stored in 
ART partition.

-Rajkumar

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2017-03-01  3:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17 11:54 QCA4019: calibration files and board files Sven Eckelmann
2017-01-23  8:30 ` Sven Eckelmann
2017-01-30 16:36 ` Adrian Chadd
2017-01-31 10:12   ` Sven Eckelmann
2017-03-07  9:54   ` Sven Eckelmann
2017-03-07 16:30     ` Adrian Chadd
2017-03-09 10:59       ` Sven Eckelmann
2017-03-09 11:51         ` Valo, Kalle
2017-03-09 12:46           ` Sven Eckelmann
2017-03-09 12:54             ` Sven Eckelmann
2017-03-09 13:11             ` Christian Lamparter
2017-03-09 14:18               ` Waldemar Rymarkiewicz
2017-03-09 16:11                 ` Adrian Chadd
2017-02-08 11:03 ` Sven Eckelmann
2017-02-09 10:26   ` akolli
2017-02-09 10:44     ` Adrian Chadd
2017-02-28  7:58     ` Sven Eckelmann
2017-03-01  3:22       ` Rajkumar Manoharan [this message]
2017-03-01  7:32         ` Sven Eckelmann
2017-03-01 12:51         ` Christian Lamparter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=821ad665d0934c58fc8b3c830e119433@codeaurora.org \
    --to=rmanohar@codeaurora.org \
    --cc=akolli@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=mohammed@codeaurora.org \
    --cc=shashidhar.lakkavalli@openmesh.com \
    --cc=sven.eckelmann@openmesh.com \
    --cc=tamizhchelvam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.