From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:59517 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752993AbeB0KZh (ORCPT ); Tue, 27 Feb 2018 05:25:37 -0500 From: Laurent Pinchart To: Sergei Shtylyov Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v4 11/16] ARM: dts: r8a7791: Convert to new LVDS DT bindings Date: Tue, 27 Feb 2018 12:26:25 +0200 Message-ID: <8228792.JG3Xuh41Ml@avalon> In-Reply-To: <29b21328-c718-91a5-fc49-5034715f5539@cogentembedded.com> References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <20180220231046.32638-12-laurent.pinchart+renesas@ideasonboard.com> <29b21328-c718-91a5-fc49-5034715f5539@cogentembedded.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Sergei, On Friday, 23 February 2018 11:51:59 EET Sergei Shtylyov wrote: > On 2/21/2018 2:10 AM, Laurent Pinchart wrote: > > The internal LVDS encoder now has DT bindings separate from the DU. Port > > the device tree over to the new model. > > > > Signed-off-by: Laurent Pinchart > > > > [...] > > > diff --git a/arch/arm/boot/dts/r8a7791.dtsi > > b/arch/arm/boot/dts/r8a7791.dtsi index 008a260f86a5..8660f8a329c7 100644 > > --- a/arch/arm/boot/dts/r8a7791.dtsi > > +++ b/arch/arm/boot/dts/r8a7791.dtsi > > [...] > > > @@ -1126,6 +1123,33 @@ > > port@1 { > > reg = <1>; > > du_out_lvds0: endpoint { > > + remote-endpoint = <&lvds0_in>; > > + }; > > + }; > > + }; > > + }; > > + > > + lvds0: lvds@feb90000 { > > I suggest that we use the label "lvds" w/o #, compatible with the manual... The manual uses "LVDS" in some places (figure 25.1b or table 25.1 for instance) and LVDS0 in other (table 25.3 for instance). I don't think this is a big deal, and if we need to refer to the LVDS node by phandle, I'd rather use lvds0 consistently on all SoCs to make writing shared DT sources easier. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 11/16] ARM: dts: r8a7791: Convert to new LVDS DT bindings Date: Tue, 27 Feb 2018 12:26:25 +0200 Message-ID: <8228792.JG3Xuh41Ml@avalon> References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <20180220231046.32638-12-laurent.pinchart+renesas@ideasonboard.com> <29b21328-c718-91a5-fc49-5034715f5539@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id D47A26E0A5 for ; Tue, 27 Feb 2018 10:25:37 +0000 (UTC) In-Reply-To: <29b21328-c718-91a5-fc49-5034715f5539@cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sergei Shtylyov Cc: linux-renesas-soc@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgU2VyZ2VpLAoKT24gRnJpZGF5LCAyMyBGZWJydWFyeSAyMDE4IDExOjUxOjU5IEVFVCBTZXJn ZWkgU2h0eWx5b3Ygd3JvdGU6Cj4gT24gMi8yMS8yMDE4IDI6MTAgQU0sIExhdXJlbnQgUGluY2hh cnQgd3JvdGU6Cj4gPiBUaGUgaW50ZXJuYWwgTFZEUyBlbmNvZGVyIG5vdyBoYXMgRFQgYmluZGlu Z3Mgc2VwYXJhdGUgZnJvbSB0aGUgRFUuIFBvcnQKPiA+IHRoZSBkZXZpY2UgdHJlZSBvdmVyIHRv IHRoZSBuZXcgbW9kZWwuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IExhdXJlbnQgUGluY2hhcnQK PiA+IDxsYXVyZW50LnBpbmNoYXJ0K3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KPiAKPiBbLi4u XQo+IAo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL3I4YTc3OTEuZHRzaQo+ID4g Yi9hcmNoL2FybS9ib290L2R0cy9yOGE3NzkxLmR0c2kgaW5kZXggMDA4YTI2MGY4NmE1Li44NjYw ZjhhMzI5YzcgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9yOGE3NzkxLmR0c2kK PiA+ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL3I4YTc3OTEuZHRzaQo+IAo+IFsuLi5dCj4gCj4g PiBAQCAtMTEyNiw2ICsxMTIzLDMzIEBACj4gPiAgIAkJCXBvcnRAMSB7Cj4gPiAgIAkJCQlyZWcg PSA8MT47Cj4gPiAgIAkJCQlkdV9vdXRfbHZkczA6IGVuZHBvaW50IHsKPiA+ICsJCQkJCXJlbW90 ZS1lbmRwb2ludCA9IDwmbHZkczBfaW4+Owo+ID4gKwkJCQl9Owo+ID4gKwkJCX07Cj4gPiArCQl9 Owo+ID4gKwl9Owo+ID4gKwo+ID4gKwlsdmRzMDogbHZkc0BmZWI5MDAwMCB7Cj4gCj4gSSBzdWdn ZXN0IHRoYXQgd2UgdXNlIHRoZSBsYWJlbCAibHZkcyIgdy9vICMsIGNvbXBhdGlibGUgd2l0aCB0 aGUgbWFudWFsLi4uCgpUaGUgbWFudWFsIHVzZXMgIkxWRFMiIGluIHNvbWUgcGxhY2VzIChmaWd1 cmUgMjUuMWIgb3IgdGFibGUgMjUuMSBmb3IgCmluc3RhbmNlKSBhbmQgTFZEUzAgaW4gb3RoZXIg KHRhYmxlIDI1LjMgZm9yIGluc3RhbmNlKS4gSSBkb24ndCB0aGluayB0aGlzIGlzIAphIGJpZyBk ZWFsLCBhbmQgaWYgd2UgbmVlZCB0byByZWZlciB0byB0aGUgTFZEUyBub2RlIGJ5IHBoYW5kbGUs IEknZCByYXRoZXIgCnVzZSBsdmRzMCBjb25zaXN0ZW50bHkgb24gYWxsIFNvQ3MgdG8gbWFrZSB3 cml0aW5nIHNoYXJlZCBEVCBzb3VyY2VzIGVhc2llci4KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQ aW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==