From: Yonghong Song <yonghong.song@linux.dev>
To: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@kernel.org
Cc: kernel-team@meta.com
Subject: Re: [PATCH bpf-next] libbpf: call dup2() syscall directly
Date: Sat, 20 Jan 2024 22:24:33 -0800 [thread overview]
Message-ID: <82363db5-7a78-4dc6-b0aa-4bc44152d77b@linux.dev> (raw)
In-Reply-To: <20240119210201.1295511-1-andrii@kernel.org>
On 1/19/24 1:02 PM, Andrii Nakryiko wrote:
> We've ran into issues with using dup2() API in production setting, where
> libbpf is linked into large production environment and ends up calling
> uninteded custom implementations of dup2(). These custom implementations
> don't provide atomic FD replacement guarantees of dup2() syscall,
> leading to subtle and hard to debug issues.
>
> To prevent this in the future and guarantee that no libc implementation
> will do their own custom non-atomic dup2() implementation, call dup2()
> syscall directly with syscall(SYS_dup2).
>
> Note that some architectures don't seem to provide dup2 and have dup3
> instead. Try to detect and pick best syscall.
>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
next prev parent reply other threads:[~2024-01-21 6:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 21:02 [PATCH bpf-next] libbpf: call dup2() syscall directly Andrii Nakryiko
2024-01-19 21:18 ` Song Liu
2024-01-19 21:21 ` Andrii Nakryiko
2024-01-19 21:29 ` Andrii Nakryiko
2024-01-19 21:34 ` Song Liu
2024-01-19 21:42 ` Andrii Nakryiko
2024-01-21 6:24 ` Yonghong Song [this message]
2024-01-23 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82363db5-7a78-4dc6-b0aa-4bc44152d77b@linux.dev \
--to=yonghong.song@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.