From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Joe Damato <jdamato@fastly.com>, <davem@davemloft.net>,
<alexanderduyck@fb.com>, <netdev@vger.kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>
Subject: Re: [PATCH net-next 5/5] eth: fbnic: re-sort the objects in the Makefile
Date: Wed, 12 Feb 2025 17:17:04 +0100 [thread overview]
Message-ID: <8274ddab-51ca-40b3-84ec-29b2815048a6@intel.com> (raw)
In-Reply-To: <20250211143234.1733c071@kernel.org>
From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 11 Feb 2025 14:32:34 -0800
> On Tue, 11 Feb 2025 11:54:37 -0800 Joe Damato wrote:
>> Incredibly minor nit, do you want to remove the trailing '\' after
>> fbnic_txrx.o which is the new last line to keep the format
>> consistent with how it was previously?
>
> The point of having the comment is that the last real line can have the
> trailing \ and therefore will not need to be modified when an object is
> added after it :)
Nice idea :D
>
> Thanks for the reviews!
Series:
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Thanks,
Olek
next prev parent reply other threads:[~2025-02-12 16:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 18:13 [PATCH net-next 0/5] eth: fbnic: report software queue stats Jakub Kicinski
2025-02-11 18:13 ` [PATCH net-next 1/5] net: report csum_complete via qstats Jakub Kicinski
2025-02-11 19:34 ` Joe Damato
2025-02-11 18:13 ` [PATCH net-next 2/5] eth: fbnic: wrap tx queue stats in a struct Jakub Kicinski
2025-02-11 19:41 ` Joe Damato
2025-02-11 18:13 ` [PATCH net-next 3/5] eth: fbnic: report software Rx queue stats Jakub Kicinski
2025-02-11 19:49 ` Joe Damato
2025-02-11 18:13 ` [PATCH net-next 4/5] eth: fbnic: report software Tx " Jakub Kicinski
2025-02-11 19:52 ` Joe Damato
2025-02-11 18:13 ` [PATCH net-next 5/5] eth: fbnic: re-sort the objects in the Makefile Jakub Kicinski
2025-02-11 19:54 ` Joe Damato
2025-02-11 22:32 ` Jakub Kicinski
2025-02-12 16:17 ` Alexander Lobakin [this message]
2025-02-13 0:50 ` [PATCH net-next 0/5] eth: fbnic: report software queue stats patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8274ddab-51ca-40b3-84ec-29b2815048a6@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.