| Refresh |
This website lore-kernel.gnuweeb.org/all/8284e049104ad878e1722927ca2b345f@codeaurora.org/ is currently offline. Cloudflare\'s Always Online™ shows a snapshot of this web page from the Internet Archive\'s Wayback Machine. To check for the live version, click Refresh. |
From: merez@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Alexei Avshalom Lazar <ailizaro@codeaurora.org>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com,
linux-wireless-owner@vger.kernel.org
Subject: Re: [02/10] wil6210: set/get EDMG channel through debugfs
Date: Wed, 25 Apr 2018 11:58:51 +0300 [thread overview]
Message-ID: <8284e049104ad878e1722927ca2b345f@codeaurora.org> (raw)
In-Reply-To: <878t9dorzo.fsf@codeaurora.org>
On 2018-04-24 12:47, Kalle Valo wrote:
> merez@codeaurora.org writes:
>
>> On 2018-04-19 19:15, Kalle Valo wrote:
>>> Maya Erez <merez@codeaurora.org> wrote:
>>>
>>>> Setting EDMG channel through debugfs for connect and PCP start
>>>> commands.
>>> Why? And what is an EDMG channel?
>>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_log_does_not_answer_why
>>> I get bad vibes that this debugfs file is just a workaround for not
>>> adding this to nl80211, a proper commit log would not give me such
>>> vibes in the first place :)
>>
>> EDMG (Enhanced Directional Multi-Gigabit) is a new feature, part of
>> 11ad/11ay specification. In a nutshell it allows channel bonding of
>> 60Ghz channels.
>>
>> The debugfs is used for debug-only to allow forcing a channel, not
>> intended to replace NL API, which we are working to upstream such.
>
> But why cannot you do debugging via nl80211 as well?
Debugging via nl80211 is possible, but there are benefits in using the
debugfs interface:
- Debugfs allows forcing a specific channel, which is not always an
option with NL API
- Debug via nl80211 is less straight forward and requires development of
user-space application
and upgrade of the kernel version on the debug setups
If you believe that the duplication is not justified please drop this
patch.
--
Maya Erez
Qualcomm Israel, Inc. on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-04-25 8:58 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-12 8:08 [PATCH 00/10] wil6210 patches Maya Erez 2018-04-12 8:08 ` [PATCH 01/10] wil6210: disable tracing config option Maya Erez 2018-04-12 8:08 ` [PATCH 02/10] wil6210: set/get EDMG channel through debugfs Maya Erez 2018-04-19 16:15 ` [02/10] " Kalle Valo 2018-04-22 12:40 ` merez 2018-04-24 9:47 ` Kalle Valo 2018-04-25 8:58 ` merez [this message] 2018-05-08 15:17 ` Kalle Valo 2018-04-12 8:08 ` [PATCH 03/10] wil6210: align to latest auto generated wmi.h Maya Erez 2018-04-12 8:08 ` [PATCH 04/10] wil6210: fix call to wil6210_disconnect during unload Maya Erez 2018-04-12 8:08 ` [PATCH 05/10] wil6210: change reply_size arg to u16 in wmi_call Maya Erez 2018-04-12 8:08 ` [PATCH 06/10] wil6210: use country specific board file upon reg domain change Maya Erez 2018-04-12 8:08 ` [PATCH 07/10] wil6210: move WMI functionality out of wil_cfg80211_mgmt_tx Maya Erez 2018-04-12 8:08 ` [PATCH 08/10] wil6210: Initialize reply struct of the WMI commands Maya Erez 2018-04-12 8:08 ` [PATCH 09/10] wil6210: remove unused rx_reorder members Maya Erez 2018-04-12 8:08 ` [PATCH 10/10] wil6210: rate limit wil_rx_refill error Maya Erez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8284e049104ad878e1722927ca2b345f@codeaurora.org \
--to=merez@codeaurora.org \
--cc=ailizaro@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wil6210@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.