Re: [PATCH v6 12/12] drm/xe/vram: Report VRAM errors using structured xe_log API

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 12-10-2026 10:48 am, Dnyaneshwar Bhadane wrote:
> Replace drm_err()/drm_info() with xe_log_err_fatal()/xe_log_info()
> using the VRAM component tag. The "no CPU visible VRAM" error uses
> tile or device as the log location depending on the caller context.
>
> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>
> ---
> v2:
>   - Update the ternary condition (Mallesh)
> ---
>   drivers/gpu/drm/xe/xe_vram.c | 38 ++++++++++++++++++++++--------------
>   1 file changed, 23 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vram.c b/drivers/gpu/drm/xe/xe_vram.c
> index 73aef047eb38..772704dfe12f 100644
> --- a/drivers/gpu/drm/xe/xe_vram.c
> +++ b/drivers/gpu/drm/xe/xe_vram.c
> @@ -17,6 +17,7 @@
>   #include "xe_device.h"
>   #include "xe_force_wake.h"
>   #include "xe_gt_mcr.h"
> +#include "xe_log.h"
>   #include "xe_map.h"
>   #include "xe_migrate.h"
>   #include "xe_mmio.h"
> @@ -46,7 +47,8 @@ static int determine_lmem_bar_size(struct xe_device *xe, struct xe_vram_region *
>   	struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
>   
>   	if (!resource_is_valid(pdev, LMEM_BAR)) {
> -		drm_err(&xe->drm, "pci resource is not valid\n");
> +		xe_log_err_fatal(xe, VRAM, -ENXIO,
> +				 "PCI resource is not valid\n");
>   		return -ENXIO;
>   	}
>   
> @@ -227,17 +229,16 @@ struct xe_vram_region *xe_vram_region_alloc(struct xe_device *xe, u8 id, u32 pla
>   
>   static void print_vram_region_info(struct xe_device *xe, struct xe_vram_region *vram)
>   {
> -	struct drm_device *drm = &xe->drm;
>   
>   	if (vram->io_size < vram->usable_size)
> -		drm_info(drm, "Small BAR device\n");
> -
> -	drm_info(drm,
> -		 "VRAM[%u]: Actual physical size %pa, usable size exclude stolen %pa, CPU accessible size %pa\n",
> -		 vram->id, &vram->actual_physical_size, &vram->usable_size, &vram->io_size);
> -	drm_info(drm, "VRAM[%u]: DPA range: [%pa-%llx], io range: [%pa-%llx]\n",
> -		 vram->id, &vram->dpa_base, vram->dpa_base + (u64)vram->actual_physical_size,
> -		 &vram->io_start, vram->io_start + (u64)vram->io_size);
> +		xe_log_info(xe, VRAM, "Small BAR device\n");
> +
> +	xe_log_info(xe, VRAM,
> +		    "[%u]: Actual physical size %pa, usable size exclude stolen %pa, CPU accessible size %pa\n",
> +		    vram->id, &vram->actual_physical_size, &vram->usable_size, &vram->io_size);
> +	xe_log_info(xe, VRAM, "[%u]: DPA range: [%pa-%llx], io range: [%pa-%llx]\n",
> +		    vram->id, &vram->dpa_base, vram->dpa_base + (u64)vram->actual_physical_size,
> +		    &vram->io_start, vram->io_start + (u64)vram->io_size);
>   }
>   
>   static int vram_region_init(struct xe_device *xe, struct xe_vram_region *vram,
> @@ -255,8 +256,14 @@ static int vram_region_init(struct xe_device *xe, struct xe_vram_region *vram,
>   	vram->io_size = min_t(u64, usable_size, remain_io_size);
>   
>   	if (!vram->io_size) {
> -		drm_err(&xe->drm, "%s without any CPU visible VRAM. Aborting.\n",
> -			tile ? "Tile" : "Device");
> +		if (tile) {
> +			xe_log_err_fatal(tile, VRAM, -ENODEV,
> +					 "without any CPU visible VRAM. Aborting.\n");

Rephrase the message, out put looks like:

<3> xe 0000:03:00.0: [drm] *ERROR* SIGID=108 FATAL (-ENODEV) Tile0: 
VRAM: without any CPU visible VRAM. Aborting.

> +		} else {
> +			xe_log_err_fatal(xe, VRAM, -ENODEV,
> +					 "without any CPU visible VRAM. Aborting.\n");
Device is required right? and rephrase the message.
> +		}
> +
>   		return -ENODEV;
>   	}
>   
> @@ -321,7 +328,7 @@ int xe_vram_probe(struct xe_device *xe)
>   	err = determine_lmem_bar_size(xe, &lmem_bar);
>   	if (err)
>   		return err;
> -	drm_info(&xe->drm, "VISIBLE VRAM: %pa, %pa\n", &lmem_bar.io_start, &lmem_bar.io_size);
> +	xe_log_info(xe, VRAM, "VISIBLE VRAM: %pa, %pa\n", &lmem_bar.io_start, &lmem_bar.io_size);
>   
>   	remain_io_size = lmem_bar.io_size;
>   
> @@ -343,8 +350,9 @@ int xe_vram_probe(struct xe_device *xe)
>   			return err;
>   
>   		if (total_size > lmem_bar.io_size) {
> -			drm_info(&xe->drm, "VRAM: %pa is larger than resource %pa\n",
> -				 &total_size, &lmem_bar.io_size);
> +			xe_log_info(xe, VRAM,
> +				    "Total size %pa is larger than resource %pa\n",
> +				    &total_size, &lmem_bar.io_size);
>   		}
>   
>   		remain_io_size -= min_t(u64, tile->mem.vram->actual_physical_size, remain_io_size);