From: Nirmoy Das <nirmoy.das@linux.intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Cc: Chris Wilson <chris.p.wilson@linux.intel.com>,
Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [PATCH 1/2] drm/i915/gem: Do not look for the exact address in node
Date: Thu, 8 Aug 2024 18:11:58 +0200 [thread overview]
Message-ID: <82c5131c-6d85-4d57-bd1d-30e80b06d360@linux.intel.com> (raw)
In-Reply-To: <20240807100521.478266-2-andi.shyti@linux.intel.com>
On 8/7/2024 12:05 PM, Andi Shyti wrote:
> In preparation for the upcoming partial memory mapping feature,
> we want to make sure that when looking for a node we consider
> also the offset and not just the starting address of the virtual
> memory node.
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> index cac6d4184506..d3ee8ef7ea2f 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> @@ -1071,9 +1071,9 @@ int i915_gem_mmap(struct file *filp, struct vm_area_struct *vma)
>
> rcu_read_lock();
> drm_vma_offset_lock_lookup(dev->vma_offset_manager);
> - node = drm_vma_offset_exact_lookup_locked(dev->vma_offset_manager,
> - vma->vm_pgoff,
> - vma_pages(vma));
> + node = drm_vma_offset_lookup_locked(dev->vma_offset_manager,
> + vma->vm_pgoff,
> + vma_pages(vma));
> if (node && drm_vma_node_is_allowed(node, priv)) {
> /*
> * Skip 0-refcnted objects as it is in the process of being
next prev parent reply other threads:[~2024-08-08 16:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 10:05 [PATCH 0/2] Allow partial memory mapping for cpu memory Andi Shyti
2024-08-07 10:05 ` [PATCH 1/2] drm/i915/gem: Do not look for the exact address in node Andi Shyti
2024-08-08 16:11 ` Nirmoy Das [this message]
2024-08-07 10:05 ` [PATCH 2/2] drm/i915/gem: Calculate object page offset for partial memory mapping Andi Shyti
2024-08-08 16:11 ` Nirmoy Das
2024-08-07 11:13 ` ✓ Fi.CI.BAT: success for Allow partial memory mapping for cpu memory Patchwork
2024-08-07 22:30 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-08-08 0:10 ` ✓ Fi.CI.BAT: success for Allow partial memory mapping for cpu memory (rev2) Patchwork
2024-08-08 7:32 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-08-09 8:53 ` [PATCH 0/2] Allow partial memory mapping for cpu memory Daniel Vetter
2024-08-09 10:20 ` Andi Shyti
2024-08-12 9:11 ` Daniel Vetter
2024-08-12 11:51 ` Andi Shyti
2024-08-12 14:45 ` Daniel Vetter
2024-08-13 2:54 ` Matthew Brost
2024-08-13 14:09 ` Daniel Vetter
2024-08-13 19:08 ` Matthew Brost
2024-08-14 2:08 ` Matthew Brost
2024-08-19 14:17 ` Daniel Vetter
2024-08-19 15:31 ` Andi Shyti
2024-08-22 9:29 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82c5131c-6d85-4d57-bd1d-30e80b06d360@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=chris.p.wilson@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.