* [PATCH] drm/amdkfd: ratelimited override pte flags messages
@ 2023-09-28 22:22 Philip Yang
2023-09-29 18:30 ` Felix Kuehling
2023-10-02 10:24 ` Christian König
0 siblings, 2 replies; 4+ messages in thread
From: Philip Yang @ 2023-09-28 22:22 UTC (permalink / raw)
To: amd-gfx; +Cc: Philip Yang, Felix.Kuehling
Use ratelimited version of dev_dbg to avoid flooding dmesg log. No
functional change.
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 2 +-
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 16 ++++++++--------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
index 96d601e209b8..6d2878684287 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
@@ -848,7 +848,7 @@ static void amdgpu_vm_pte_update_flags(struct amdgpu_vm_update_params *params,
amdgpu_gmc_override_vm_pte_flags(adev, params->vm,
addr, &flags);
else
- dev_dbg(adev->dev,
+ dev_dbg_ratelimited(adev->dev,
"override_vm_pte_flags skipped: non-contiguous\n");
}
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index 6b15677c0314..ad0d63472e17 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
@@ -1244,7 +1244,7 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
* the DMA address.
*/
if (!adev->ram_is_direct_mapped) {
- dev_dbg(adev->dev, "RAM is not direct mapped\n");
+ dev_dbg_ratelimited(adev->dev, "RAM is not direct mapped\n");
return;
}
@@ -1253,7 +1253,7 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
*/
if ((*flags & AMDGPU_PTE_MTYPE_VG10_MASK) !=
AMDGPU_PTE_MTYPE_VG10(MTYPE_NC)) {
- dev_dbg(adev->dev, "MTYPE is not NC\n");
+ dev_dbg_ratelimited(adev->dev, "MTYPE is not NC\n");
return;
}
@@ -1264,7 +1264,7 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
if (adev->gmc.is_app_apu && vm->mem_id >= 0) {
local_node = adev->gmc.mem_partitions[vm->mem_id].numa.node;
} else {
- dev_dbg(adev->dev, "Only native mode APU is supported.\n");
+ dev_dbg_ratelimited(adev->dev, "Only native mode APU is supported.\n");
return;
}
@@ -1272,12 +1272,12 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
* page or NUMA nodes.
*/
if (!page_is_ram(addr >> PAGE_SHIFT)) {
- dev_dbg(adev->dev, "Page is not RAM.\n");
+ dev_dbg_ratelimited(adev->dev, "Page is not RAM.\n");
return;
}
nid = pfn_to_nid(addr >> PAGE_SHIFT);
- dev_dbg(adev->dev, "vm->mem_id=%d, local_node=%d, nid=%d\n",
- vm->mem_id, local_node, nid);
+ dev_dbg_ratelimited(adev->dev, "vm->mem_id=%d, local_node=%d, nid=%d\n",
+ vm->mem_id, local_node, nid);
if (nid == local_node) {
uint64_t old_flags = *flags;
unsigned int mtype_local = MTYPE_RW;
@@ -1289,8 +1289,8 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
*flags = (*flags & ~AMDGPU_PTE_MTYPE_VG10_MASK) |
AMDGPU_PTE_MTYPE_VG10(mtype_local);
- dev_dbg(adev->dev, "flags updated from %llx to %llx\n",
- old_flags, *flags);
+ dev_dbg_ratelimited(adev->dev, "flags updated from %llx to %llx\n",
+ old_flags, *flags);
}
}
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdkfd: ratelimited override pte flags messages
2023-09-28 22:22 [PATCH] drm/amdkfd: ratelimited override pte flags messages Philip Yang
@ 2023-09-29 18:30 ` Felix Kuehling
2023-10-02 10:24 ` Christian König
1 sibling, 0 replies; 4+ messages in thread
From: Felix Kuehling @ 2023-09-29 18:30 UTC (permalink / raw)
To: Philip Yang, amd-gfx
On 2023-09-28 18:22, Philip Yang wrote:
> Use ratelimited version of dev_dbg to avoid flooding dmesg log. No
> functional change.
>
> Signed-off-by: Philip Yang <Philip.Yang@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 16 ++++++++--------
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> index 96d601e209b8..6d2878684287 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> @@ -848,7 +848,7 @@ static void amdgpu_vm_pte_update_flags(struct amdgpu_vm_update_params *params,
> amdgpu_gmc_override_vm_pte_flags(adev, params->vm,
> addr, &flags);
> else
> - dev_dbg(adev->dev,
> + dev_dbg_ratelimited(adev->dev,
> "override_vm_pte_flags skipped: non-contiguous\n");
> }
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 6b15677c0314..ad0d63472e17 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -1244,7 +1244,7 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
> * the DMA address.
> */
> if (!adev->ram_is_direct_mapped) {
> - dev_dbg(adev->dev, "RAM is not direct mapped\n");
> + dev_dbg_ratelimited(adev->dev, "RAM is not direct mapped\n");
> return;
> }
>
> @@ -1253,7 +1253,7 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
> */
> if ((*flags & AMDGPU_PTE_MTYPE_VG10_MASK) !=
> AMDGPU_PTE_MTYPE_VG10(MTYPE_NC)) {
> - dev_dbg(adev->dev, "MTYPE is not NC\n");
> + dev_dbg_ratelimited(adev->dev, "MTYPE is not NC\n");
> return;
> }
>
> @@ -1264,7 +1264,7 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
> if (adev->gmc.is_app_apu && vm->mem_id >= 0) {
> local_node = adev->gmc.mem_partitions[vm->mem_id].numa.node;
> } else {
> - dev_dbg(adev->dev, "Only native mode APU is supported.\n");
> + dev_dbg_ratelimited(adev->dev, "Only native mode APU is supported.\n");
> return;
> }
>
> @@ -1272,12 +1272,12 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
> * page or NUMA nodes.
> */
> if (!page_is_ram(addr >> PAGE_SHIFT)) {
> - dev_dbg(adev->dev, "Page is not RAM.\n");
> + dev_dbg_ratelimited(adev->dev, "Page is not RAM.\n");
> return;
> }
> nid = pfn_to_nid(addr >> PAGE_SHIFT);
> - dev_dbg(adev->dev, "vm->mem_id=%d, local_node=%d, nid=%d\n",
> - vm->mem_id, local_node, nid);
> + dev_dbg_ratelimited(adev->dev, "vm->mem_id=%d, local_node=%d, nid=%d\n",
> + vm->mem_id, local_node, nid);
> if (nid == local_node) {
> uint64_t old_flags = *flags;
> unsigned int mtype_local = MTYPE_RW;
> @@ -1289,8 +1289,8 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
>
> *flags = (*flags & ~AMDGPU_PTE_MTYPE_VG10_MASK) |
> AMDGPU_PTE_MTYPE_VG10(mtype_local);
> - dev_dbg(adev->dev, "flags updated from %llx to %llx\n",
> - old_flags, *flags);
> + dev_dbg_ratelimited(adev->dev, "flags updated from %llx to %llx\n",
> + old_flags, *flags);
> }
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdkfd: ratelimited override pte flags messages
2023-09-28 22:22 [PATCH] drm/amdkfd: ratelimited override pte flags messages Philip Yang
2023-09-29 18:30 ` Felix Kuehling
@ 2023-10-02 10:24 ` Christian König
2023-10-02 13:51 ` Philip Yang
1 sibling, 1 reply; 4+ messages in thread
From: Christian König @ 2023-10-02 10:24 UTC (permalink / raw)
To: Philip Yang, amd-gfx; +Cc: Felix.Kuehling
Am 29.09.23 um 00:22 schrieb Philip Yang:
> Use ratelimited version of dev_dbg to avoid flooding dmesg log. No
> functional change.
>
> Signed-off-by: Philip Yang <Philip.Yang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 16 ++++++++--------
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> index 96d601e209b8..6d2878684287 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> @@ -848,7 +848,7 @@ static void amdgpu_vm_pte_update_flags(struct amdgpu_vm_update_params *params,
> amdgpu_gmc_override_vm_pte_flags(adev, params->vm,
> addr, &flags);
> else
> - dev_dbg(adev->dev,
> + dev_dbg_ratelimited(adev->dev,
> "override_vm_pte_flags skipped: non-contiguous\n");
I don't see any value in this in the first place. We should probably
drop the message altogether.
Christian.
> }
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 6b15677c0314..ad0d63472e17 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -1244,7 +1244,7 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
> * the DMA address.
> */
> if (!adev->ram_is_direct_mapped) {
> - dev_dbg(adev->dev, "RAM is not direct mapped\n");
> + dev_dbg_ratelimited(adev->dev, "RAM is not direct mapped\n");
> return;
> }
>
> @@ -1253,7 +1253,7 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
> */
> if ((*flags & AMDGPU_PTE_MTYPE_VG10_MASK) !=
> AMDGPU_PTE_MTYPE_VG10(MTYPE_NC)) {
> - dev_dbg(adev->dev, "MTYPE is not NC\n");
> + dev_dbg_ratelimited(adev->dev, "MTYPE is not NC\n");
> return;
> }
>
> @@ -1264,7 +1264,7 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
> if (adev->gmc.is_app_apu && vm->mem_id >= 0) {
> local_node = adev->gmc.mem_partitions[vm->mem_id].numa.node;
> } else {
> - dev_dbg(adev->dev, "Only native mode APU is supported.\n");
> + dev_dbg_ratelimited(adev->dev, "Only native mode APU is supported.\n");
> return;
> }
>
> @@ -1272,12 +1272,12 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
> * page or NUMA nodes.
> */
> if (!page_is_ram(addr >> PAGE_SHIFT)) {
> - dev_dbg(adev->dev, "Page is not RAM.\n");
> + dev_dbg_ratelimited(adev->dev, "Page is not RAM.\n");
> return;
> }
> nid = pfn_to_nid(addr >> PAGE_SHIFT);
> - dev_dbg(adev->dev, "vm->mem_id=%d, local_node=%d, nid=%d\n",
> - vm->mem_id, local_node, nid);
> + dev_dbg_ratelimited(adev->dev, "vm->mem_id=%d, local_node=%d, nid=%d\n",
> + vm->mem_id, local_node, nid);
> if (nid == local_node) {
> uint64_t old_flags = *flags;
> unsigned int mtype_local = MTYPE_RW;
> @@ -1289,8 +1289,8 @@ static void gmc_v9_0_override_vm_pte_flags(struct amdgpu_device *adev,
>
> *flags = (*flags & ~AMDGPU_PTE_MTYPE_VG10_MASK) |
> AMDGPU_PTE_MTYPE_VG10(mtype_local);
> - dev_dbg(adev->dev, "flags updated from %llx to %llx\n",
> - old_flags, *flags);
> + dev_dbg_ratelimited(adev->dev, "flags updated from %llx to %llx\n",
> + old_flags, *flags);
> }
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdkfd: ratelimited override pte flags messages
2023-10-02 10:24 ` Christian König
@ 2023-10-02 13:51 ` Philip Yang
0 siblings, 0 replies; 4+ messages in thread
From: Philip Yang @ 2023-10-02 13:51 UTC (permalink / raw)
To: Christian König, Philip Yang, amd-gfx; +Cc: Felix.Kuehling
[-- Attachment #1: Type: text/html, Size: 8371 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-02 13:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-28 22:22 [PATCH] drm/amdkfd: ratelimited override pte flags messages Philip Yang
2023-09-29 18:30 ` Felix Kuehling
2023-10-02 10:24 ` Christian König
2023-10-02 13:51 ` Philip Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.