From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [CI v2 v2 12/12] drm/i915/de: remove unnecessary generic wrappers
Date: Mon, 28 Oct 2024 22:07:30 +0200 [thread overview]
Message-ID: <82da66027a122b336278daa2c9a9eb39843082ba.1730146000.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1730146000.git.jani.nikula@intel.com>
With many of the intel_de_* callers switched over to struct
intel_display, we can remove some of the unnecessary generic wrappers.
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_de.h | 46 ++++++++++---------------
1 file changed, 18 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
index e017cd4a8168..bb51f974e9e2 100644
--- a/drivers/gpu/drm/i915/display/intel_de.h
+++ b/drivers/gpu/drm/i915/display/intel_de.h
@@ -32,7 +32,7 @@ __intel_de_read(struct intel_display *display, i915_reg_t reg)
#define intel_de_read(p,...) __intel_de_read(__to_intel_display(p), __VA_ARGS__)
static inline u8
-__intel_de_read8(struct intel_display *display, i915_reg_t reg)
+intel_de_read8(struct intel_display *display, i915_reg_t reg)
{
u8 val;
@@ -44,11 +44,10 @@ __intel_de_read8(struct intel_display *display, i915_reg_t reg)
return val;
}
-#define intel_de_read8(p,...) __intel_de_read8(__to_intel_display(p), __VA_ARGS__)
static inline u64
-__intel_de_read64_2x32(struct intel_display *display,
- i915_reg_t lower_reg, i915_reg_t upper_reg)
+intel_de_read64_2x32(struct intel_display *display,
+ i915_reg_t lower_reg, i915_reg_t upper_reg)
{
u64 val;
@@ -63,7 +62,6 @@ __intel_de_read64_2x32(struct intel_display *display,
return val;
}
-#define intel_de_read64_2x32(p,...) __intel_de_read64_2x32(__to_intel_display(p), __VA_ARGS__)
static inline void
__intel_de_posting_read(struct intel_display *display, i915_reg_t reg)
@@ -88,12 +86,11 @@ __intel_de_write(struct intel_display *display, i915_reg_t reg, u32 val)
#define intel_de_write(p,...) __intel_de_write(__to_intel_display(p), __VA_ARGS__)
static inline u32
-____intel_de_rmw_nowl(struct intel_display *display, i915_reg_t reg,
- u32 clear, u32 set)
+__intel_de_rmw_nowl(struct intel_display *display, i915_reg_t reg,
+ u32 clear, u32 set)
{
return intel_uncore_rmw(__to_uncore(display), reg, clear, set);
}
-#define __intel_de_rmw_nowl(p,...) ____intel_de_rmw_nowl(__to_intel_display(p), __VA_ARGS__)
static inline u32
__intel_de_rmw(struct intel_display *display, i915_reg_t reg, u32 clear,
@@ -112,18 +109,17 @@ __intel_de_rmw(struct intel_display *display, i915_reg_t reg, u32 clear,
#define intel_de_rmw(p,...) __intel_de_rmw(__to_intel_display(p), __VA_ARGS__)
static inline int
-____intel_de_wait_for_register_nowl(struct intel_display *display,
- i915_reg_t reg,
- u32 mask, u32 value, unsigned int timeout)
+__intel_de_wait_for_register_nowl(struct intel_display *display,
+ i915_reg_t reg,
+ u32 mask, u32 value, unsigned int timeout)
{
return intel_wait_for_register(__to_uncore(display), reg, mask,
value, timeout);
}
-#define __intel_de_wait_for_register_nowl(p,...) ____intel_de_wait_for_register_nowl(__to_intel_display(p), __VA_ARGS__)
static inline int
-__intel_de_wait(struct intel_display *display, i915_reg_t reg,
- u32 mask, u32 value, unsigned int timeout)
+intel_de_wait(struct intel_display *display, i915_reg_t reg,
+ u32 mask, u32 value, unsigned int timeout)
{
int ret;
@@ -136,11 +132,10 @@ __intel_de_wait(struct intel_display *display, i915_reg_t reg,
return ret;
}
-#define intel_de_wait(p,...) __intel_de_wait(__to_intel_display(p), __VA_ARGS__)
static inline int
-__intel_de_wait_fw(struct intel_display *display, i915_reg_t reg,
- u32 mask, u32 value, unsigned int timeout)
+intel_de_wait_fw(struct intel_display *display, i915_reg_t reg,
+ u32 mask, u32 value, unsigned int timeout)
{
int ret;
@@ -153,13 +148,12 @@ __intel_de_wait_fw(struct intel_display *display, i915_reg_t reg,
return ret;
}
-#define intel_de_wait_fw(p,...) __intel_de_wait_fw(__to_intel_display(p), __VA_ARGS__)
static inline int
-__intel_de_wait_custom(struct intel_display *display, i915_reg_t reg,
- u32 mask, u32 value,
- unsigned int fast_timeout_us,
- unsigned int slow_timeout_ms, u32 *out_value)
+intel_de_wait_custom(struct intel_display *display, i915_reg_t reg,
+ u32 mask, u32 value,
+ unsigned int fast_timeout_us,
+ unsigned int slow_timeout_ms, u32 *out_value)
{
int ret;
@@ -173,7 +167,6 @@ __intel_de_wait_custom(struct intel_display *display, i915_reg_t reg,
return ret;
}
-#define intel_de_wait_custom(p,...) __intel_de_wait_custom(__to_intel_display(p), __VA_ARGS__)
static inline int
__intel_de_wait_for_set(struct intel_display *display, i915_reg_t reg,
@@ -220,19 +213,16 @@ __intel_de_write_fw(struct intel_display *display, i915_reg_t reg, u32 val)
#define intel_de_write_fw(p,...) __intel_de_write_fw(__to_intel_display(p), __VA_ARGS__)
static inline u32
-__intel_de_read_notrace(struct intel_display *display, i915_reg_t reg)
+intel_de_read_notrace(struct intel_display *display, i915_reg_t reg)
{
return intel_uncore_read_notrace(__to_uncore(display), reg);
}
-#define intel_de_read_notrace(p,...) __intel_de_read_notrace(__to_intel_display(p), __VA_ARGS__)
static inline void
-__intel_de_write_notrace(struct intel_display *display, i915_reg_t reg,
- u32 val)
+intel_de_write_notrace(struct intel_display *display, i915_reg_t reg, u32 val)
{
intel_uncore_write_notrace(__to_uncore(display), reg, val);
}
-#define intel_de_write_notrace(p,...) __intel_de_write_notrace(__to_intel_display(p), __VA_ARGS__)
static __always_inline void
intel_de_write_dsb(struct intel_display *display, struct intel_dsb *dsb,
--
2.39.5
next prev parent reply other threads:[~2024-10-28 20:08 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 20:07 [CI v2 v2 00/12] drm/i915/display: bunch of struct intel_display conversions Jani Nikula
2024-10-28 20:07 ` [CI v2 v2 01/12] drm/i915/gmbus: convert to struct intel_display Jani Nikula
2024-10-28 20:07 ` [CI v2 v2 02/12] drm/i915/cx0: remove unnecessary includes Jani Nikula
2024-10-28 20:07 ` [CI v2 v2 03/12] drm/i915/cx0: convert to struct intel_display Jani Nikula
2024-10-29 16:08 ` [PATCH] " Jani Nikula
2024-10-28 20:07 ` [CI v2 v2 04/12] drm/i915/dpio: " Jani Nikula
2024-10-28 20:07 ` [CI v2 v2 05/12] drm/i915/hdcp: further conversion " Jani Nikula
2024-10-28 20:07 ` [CI v2 v2 06/12] drm/i915/dp/hdcp: convert " Jani Nikula
2024-10-29 9:04 ` [PATCH] " Jani Nikula
2024-10-28 20:07 ` [CI v2 v2 07/12] drm/i915/crt: " Jani Nikula
2024-10-29 10:52 ` [PATCH] " Jani Nikula
2024-10-28 20:07 ` [CI v2 v2 08/12] drm/i915/display: convert vlv_wait_port_ready() " Jani Nikula
2024-10-28 20:07 ` [CI v2 v2 09/12] drm/i915/power: convert assert_chv_phy_status() " Jani Nikula
2024-10-28 20:07 ` [CI v2 v2 10/12] drm/i915/ips: convert " Jani Nikula
2024-10-28 20:07 ` [CI v2 v2 11/12] drm/i915/dsi: " Jani Nikula
2024-10-28 20:07 ` Jani Nikula [this message]
2024-10-28 22:26 ` ✗ CI.Patch_applied: failure for drm/i915/display: bunch of struct intel_display conversions (rev3) Patchwork
2024-10-29 9:50 ` ✓ CI.Patch_applied: success for drm/i915/display: bunch of struct intel_display conversions (rev4) Patchwork
2024-10-29 9:51 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-29 9:52 ` ✓ CI.KUnit: success " Patchwork
2024-10-29 10:04 ` ✓ CI.Build: " Patchwork
2024-10-29 10:06 ` ✓ CI.Hooks: " Patchwork
2024-10-29 10:08 ` ✗ CI.checksparse: warning " Patchwork
2024-10-29 10:41 ` ✓ CI.BAT: success " Patchwork
2024-10-29 11:42 ` ✓ CI.Patch_applied: success for drm/i915/display: bunch of struct intel_display conversions (rev5) Patchwork
2024-10-29 11:42 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-29 11:43 ` ✓ CI.KUnit: success " Patchwork
2024-10-29 11:55 ` ✓ CI.Build: " Patchwork
2024-10-29 11:57 ` ✓ CI.Hooks: " Patchwork
2024-10-29 11:59 ` ✗ CI.checksparse: warning " Patchwork
2024-10-29 12:35 ` ✓ CI.BAT: success " Patchwork
2024-10-29 12:51 ` ✗ CI.FULL: failure for drm/i915/display: bunch of struct intel_display conversions (rev4) Patchwork
2024-10-29 14:12 ` ✗ CI.FULL: failure for drm/i915/display: bunch of struct intel_display conversions (rev5) Patchwork
2024-10-29 19:18 ` ✓ CI.Patch_applied: success for drm/i915/display: bunch of struct intel_display conversions (rev6) Patchwork
2024-10-29 19:19 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-29 19:20 ` ✓ CI.KUnit: success " Patchwork
2024-10-29 19:31 ` ✓ CI.Build: " Patchwork
2024-10-29 19:34 ` ✓ CI.Hooks: " Patchwork
2024-10-29 19:35 ` ✗ CI.checksparse: warning " Patchwork
2024-10-29 19:58 ` ✓ CI.BAT: success " Patchwork
2024-10-29 23:22 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-10-29 23:22 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-10-29 23:22 ` ✓ Fi.CI.BAT: success " Patchwork
2024-10-29 23:56 ` ✗ CI.FULL: failure " Patchwork
2024-10-30 12:16 ` [CI v2 v2 00/12] drm/i915/display: bunch of struct intel_display conversions Jani Nikula
2024-10-30 22:42 ` ✓ Fi.CI.IGT: success for drm/i915/display: bunch of struct intel_display conversions (rev6) Patchwork
2024-10-30 22:49 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82da66027a122b336278daa2c9a9eb39843082ba.1730146000.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.