From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79EFFC433F5 for ; Mon, 15 Nov 2021 21:47:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA3BD61B2C for ; Mon, 15 Nov 2021 21:47:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA3BD61B2C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0C0FC837B2; Mon, 15 Nov 2021 22:47:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="rU+Jn0+s"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7DD0C837AE; Mon, 15 Nov 2021 22:47:02 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1F5E0837B2 for ; Mon, 15 Nov 2021 22:46:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: adalessandro) with ESMTPSA id 0D2E71F44F0B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1637012818; bh=j4J/FYYrU08Y2Lbi7gTw8ZxXaHKyPlBmxJvR6XyxV0k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=rU+Jn0+s0NoTTQQ0aqq5nXC62KFF3oLAqvTLzmRJVtZssizByQkroPNjWXr/jP2zz 0vmbW0aOx70iX6o+V802ZBevR8CTWr+MYZMmkbjeuwP8Ut9ivdBuhxtiHerlRp83BP YOsDxBECKgPG9i0g4mAQOOGlXJXQVe9mneNrUqGw+NsbyBO2r79Is3sSlliuPErvfs g02hUd+FSh97liQV+U/GBFm8db2zwYBJZugQMptv/pVgWuzmIShNWMYZKwJ6vzem4J aKHPTPF7ZIHIPkiqYcj7mcmZbttLwCKtNyl6wpjHYKdLv3T1WLAE3vLTee3L7kE2dK U2McUQidlsm7g== Subject: Re: [PATCH v2] imx8mn_var_som: Add support for Variscite VAR-SOM-MX8M-NANO board To: Tom Rini Cc: u-boot@lists.denx.de, uboot-imx@nxp.com, aford173@gmail.com, andre.przywara@arm.com, andrey.zhizhikin@leica-geosystems.com, christianshewitt@gmail.com, festevam@gmail.com, hs@denx.de, iliev@ronetix.at, jagan@amarulasolutions.com, marcel.ziswiler@toradex.com, narmstrong@baylibre.com, patrick.delaunay@foss.st.com, pbrobinson@gmail.com, peng.fan@nxp.com, rick@andestech.com, sbabic@denx.de, seanga2@gmail.com, sjg@chromium.org, t.remmet@phytec.de, tharvey@gateworks.com References: <20211115202422.537136-1-ariel.dalessandro@collabora.com> <20211115211133.GX24579@bill-the-cat> <6ab89061-46eb-ef79-3133-a661f23101d1@collabora.com> <20211115212841.GY24579@bill-the-cat> From: Ariel D'Alessandro Message-ID: <82e26db3-4b29-afb6-c9b0-dea990621fb5@collabora.com> Date: Mon, 15 Nov 2021 18:46:47 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211115212841.GY24579@bill-the-cat> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 11/15/21 6:28 PM, Tom Rini wrote: > On Mon, Nov 15, 2021 at 06:27:08PM -0300, Ariel D'Alessandro wrote: >> Hi Tom, >> >> Thanks for the feedback. >> >> On 11/15/21 6:11 PM, Tom Rini wrote: >>> On Mon, Nov 15, 2021 at 05:24:22PM -0300, Ariel D'Alessandro wrote: >>> >>>> Add support for iMX8MN VAR-SOM-MX8M-NANO board. Enables support for: >>>> >>>> - 1GiB DDR4 RAM >>>> - 16 GiB eMMC >>>> - SD card >>>> - Gigabit ethernet >>>> - USBOTG1 peripheral - fastboot >>>> >>>> Signed-off-by: Ariel D'Alessandro >>>> --- [snip] >>>> +#ifdef CONFIG_SPL_BUILD >>>> + >>>> +#define CONFIG_SPL_STACK 0x980000 >>>> +#define CONFIG_SPL_BSS_START_ADDR 0x950000 >>>> +#define CONFIG_SPL_BSS_MAX_SIZE SZ_8K >>>> +#define CONFIG_SYS_SPL_MALLOC_START 0x42200000 >>>> +#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K >>>> + >>>> +/* For RAW image gives a error info not panic */ >>>> +#define CONFIG_SPL_ABORT_ON_RAW_IMAGE >>>> + >>>> +#endif /* CONFIG_SPL_BUILD */ >>> >>> We can't guard CONFIG options with CONFIG_SPL_BUILD or >>> !CONFIG_SPL_BUILD. >> >> Sorry I don't understand, could you expand on the proper way to handle >> the above configuration? AFAICS, several imx8m boards follow this same >> pattern: >> >> $ git grep -l CONFIG_SPL_BUILD -- include/configs/imx8m* >> include/configs/imx8mm-cl-iot-gate.h >> include/configs/imx8mm_beacon.h >> include/configs/imx8mm_evk.h >> include/configs/imx8mm_icore_mx8mm.h >> include/configs/imx8mm_venice.h >> include/configs/imx8mn_beacon.h >> include/configs/imx8mn_evk.h >> include/configs/imx8mp_evk.h >> include/configs/imx8mq_cm.h >> include/configs/imx8mq_evk.h >> include/configs/imx8mq_phanbell.h > > Yes, it's sadly a common anti-pattern. Just always define things. I see. Will be fixed in v3. Thanks a lot! Ariel