From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check Date: Thu, 28 Mar 2013 06:13:31 -0400 (EDT) Message-ID: <8300718.16452772.1364465611936.JavaMail.root@redhat.com> References: <20130328090416.GA18482@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130328090416.GA18482@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: Kevin O'Connor , kvm@vger.kernel.org, seabios-devel , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, target-devel@vger.kernel.org, Stefan Hajnoczi List-Id: virtualization@lists.linuxfoundation.org > I think it's the right thing to do, but maybe not the right place > to do this, need to reset after all IO is done, before > ring memory is write protected. Our emails are crossing each other unfortunately, but I want to reinforce this: ring memory is not write protected. Remember that SeaBIOS can even provide virtio-scsi access to DOS, so you must not reset the device. It must remain functional all the time, and the OS's own driver will reset it when it's started. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UL9q2-000841-OW for qemu-devel@nongnu.org; Thu, 28 Mar 2013 06:13:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UL9q1-0001i9-Ls for qemu-devel@nongnu.org; Thu, 28 Mar 2013 06:13:42 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:35351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UL9q1-0001i3-D7 for qemu-devel@nongnu.org; Thu, 28 Mar 2013 06:13:41 -0400 Date: Thu, 28 Mar 2013 06:13:31 -0400 (EDT) From: Paolo Bonzini Message-ID: <8300718.16452772.1364465611936.JavaMail.root@redhat.com> In-Reply-To: <20130328090416.GA18482@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Kevin O'Connor , kvm@vger.kernel.org, Stefan Hajnoczi , seabios-devel , qemu-devel@nongnu.org, "Nicholas A. Bellinger" , virtualization@lists.linux-foundation.org, target-devel@vger.kernel.org, Stefan Hajnoczi , Asias He > I think it's the right thing to do, but maybe not the right place > to do this, need to reset after all IO is done, before > ring memory is write protected. Our emails are crossing each other unfortunately, but I want to reinforce this: ring memory is not write protected. Remember that SeaBIOS can even provide virtio-scsi access to DOS, so you must not reset the device. It must remain functional all the time, and the OS's own driver will reset it when it's started. Paolo