From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6961C433EF for ; Fri, 21 Jan 2022 04:33:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8BF938378B; Fri, 21 Jan 2022 05:33:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="fnY3GHS4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 64C20838B0; Fri, 21 Jan 2022 05:33:05 +0100 (CET) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9479783494 for ; Fri, 21 Jan 2022 05:33:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vigneshr@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 20L4WwdR016035; Thu, 20 Jan 2022 22:32:58 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1642739578; bh=n688KVM9Jrjl+gL1AmNPz8eofhWyOUH9T/DfxNN7o2E=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=fnY3GHS4/fDSQmN7TpDblX+0iLyrOjSBUeLs6+fSA5mE/OgvfgQAMGMy9kUWPEbNP V+Yix/OCVm0ewWE6Ev2NCB4ww0YLvvDw5L3gw9LOHkRG37MrxJVYPpHsUhLOOYaF5s d6aGQmk1UCWXvTP/HcJVP1r1r25oe3QhF/9gxbBs= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 20L4WwWb115134 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 20 Jan 2022 22:32:58 -0600 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 20 Jan 2022 22:32:57 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 20 Jan 2022 22:32:57 -0600 Received: from [10.250.235.90] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 20L4WtSu108483; Thu, 20 Jan 2022 22:32:55 -0600 Message-ID: <83050e07-8134-5095-2fa2-0aed8d408bf4@ti.com> Date: Fri, 21 Jan 2022 10:02:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 2/8] net: ti: am65-cpsw: Add support for multi port independent MAC mode Content-Language: en-US To: Tom Rini , Ramon Fried CC: Dave Gerlach , Joe Hershberger , U-Boot Mailing List , Grygorii Strashko References: <20211224072536.270251-1-vigneshr@ti.com> <20211224072536.270251-3-vigneshr@ti.com> <20220117183701.GB2631111@bill-the-cat> <20220120231945.GN7004@bill-the-cat> From: Vignesh Raghavendra In-Reply-To: <20220120231945.GN7004@bill-the-cat> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 21/01/22 4:49 am, Tom Rini wrote: > On Fri, Jan 21, 2022 at 01:13:54AM +0200, Ramon Fried wrote: >> On Mon, Jan 17, 2022 at 8:37 PM Tom Rini wrote: >>> >>> On Fri, Dec 24, 2021 at 12:55:30PM +0530, Vignesh Raghavendra wrote: >>> >>>> On certain TI SoC, like AM64x there is a CPSW3G which supports 2 >>>> external independent MAC ports for single CPSW instance. >>>> It is not possible for Ethernet driver to register more than one port >>>> for given instance. >>>> >>>> This patch modifies top level CPSW NUSS as UCLASS_MISC and binds >>>> UCLASS_ETH to individual ports so as to support bring up more than one >>>> Ethernet interface in U-Boot. >>>> >>>> Note that there is no isolation in the since, CPSW NUSS is in promisc >>>> mode and forwards all packets to host. >>>> >>>> Since top level driver is now UCLASS_MISC, board files would need to >>>> instantiate this driver explicitly. >>>> >>>> Signed-off-by: Vignesh Raghavendra >>> >>> Applied to u-boot/master, thanks! >> why ? comments were not addressed. > > I missed that you had comments, sorry. Shall I revert this one for now? > Could you please hold off revert? Will send follow up patch fixing stray printf() pointed out by Ramon Apologies for not noticing comment beforehand! Regards Vignesh