All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Melissa Wen <mwen@igalia.com>,
	airlied@gmail.com, mripard@kernel.org, simona@ffwll.ch,
	tzimmermann@suse.de
Cc: amd-gfx@lists.freedesktop.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	dri-devel@lists.freedesktop.org, kernel-dev@igalia.com
Subject: Re: [PATCH 2/2] Revert "drm/gem: Acquire references on GEM handles for framebuffers"
Date: Mon, 22 Sep 2025 14:04:32 +0200	[thread overview]
Message-ID: <83089cef-9981-450d-b7ab-239fb16672c5@linux.intel.com> (raw)
In-Reply-To: <20250919155519.1104256-3-mwen@igalia.com>

Hey,

On 2025-09-19 17:54, Melissa Wen wrote:
> This reverts commit 5307dce878d4126e1b375587318955bd019c3741.
> 
> We've already reverted all other commits related to dma_bug handling and
> there is still something wrong with this approach that does not allow
> unloading a driver. By reverting this commit, we'd just go back ot the
> old behavior.

This is actually important to keep. i915 and xe already do this for similar reasons, so I'm glad it's enforced across all drivers.
Without this you can do this:
- CreateFB
- destroy gem object
- Have random memory being scanout.

I'd rather keep it. If amd no longer unloads, figure out why. I know there are igt tests for module load, do those work?

Best regards,
~Maarten

  parent reply	other threads:[~2025-09-22 12:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19 15:54 [PATCH 0/2] drm: revert the remaining commits about dma_buf handling Melissa Wen
2025-09-19 15:54 ` [PATCH 1/2] Revert "drm/framebuffer: Acquire internal references on GEM handles" Melissa Wen
2025-09-19 15:54 ` [PATCH 2/2] Revert "drm/gem: Acquire references on GEM handles for framebuffers" Melissa Wen
2025-09-22  8:34   ` Christian König
2025-09-22  8:40     ` Thomas Zimmermann
2025-09-22  9:20       ` Christian König
2025-09-22 12:04   ` Maarten Lankhorst [this message]
2025-09-22  7:41 ` [PATCH 0/2] drm: revert the remaining commits about dma_buf handling Thomas Zimmermann
2025-09-22 11:54 ` Thomas Zimmermann
2025-09-22 11:55   ` Christian König
2025-09-22 12:01     ` Thomas Zimmermann
2025-09-22 13:42   ` Melissa Wen
2025-09-22 14:00     ` Christian König
2025-09-22 14:06     ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83089cef-9981-450d-b7ab-239fb16672c5@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-dev@igalia.com \
    --cc=mario.limonciello@amd.com \
    --cc=mripard@kernel.org \
    --cc=mwen@igalia.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.