From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21B00EE4993 for ; Wed, 23 Aug 2023 14:09:55 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.589318.921188 (Exim 4.92) (envelope-from ) id 1qYoYD-00047i-Ds; Wed, 23 Aug 2023 14:09:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 589318.921188; Wed, 23 Aug 2023 14:09:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qYoYD-00047b-BF; Wed, 23 Aug 2023 14:09:37 +0000 Received: by outflank-mailman (input) for mailman id 589318; Wed, 23 Aug 2023 14:09:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qYoYC-00047V-NQ for xen-devel@lists.xenproject.org; Wed, 23 Aug 2023 14:09:36 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b038391b-41be-11ee-8783-cb3800f73035; Wed, 23 Aug 2023 16:09:35 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id BE3A14EE0737; Wed, 23 Aug 2023 16:09:34 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b038391b-41be-11ee-8783-cb3800f73035 MIME-Version: 1.0 Date: Wed, 23 Aug 2023 16:09:34 +0200 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, =?UTF-8?Q?Roger_Pau?= =?UTF-8?Q?_Monn=C3=A9?= , Julien Grall , Jan Beulich , Andrew Cooper , George Dunlap , Wei Liu Subject: Re: [XEN PATCH v2 2/3] vpci/msix: make 'get_slot' static In-Reply-To: References: User-Agent: Roundcube Webmail/1.4.3 Message-ID: <83384f49acf61489588faf76e54fa106@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 17/08/2023 14:39, Nicola Vetrini wrote: > The function can become static since it's used only within this file. > This also resolves a violation of MISRA C:2012 Rule 8.4 due to the > absence > of a declaration before the function definition. > > Fixes: b177892d2d0e ("vpci/msix: handle accesses adjacent to the MSI-X > table") > Signed-off-by: Nicola Vetrini > Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - Corrected wrong prefix in the commit subject. > > CC-ing maintainers from "THE REST" as well, perhaps this trivial change > can go > in straight away. > --- > xen/drivers/vpci/msix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c > index 25bde77586a4..f9df506f29bf 100644 > --- a/xen/drivers/vpci/msix.c > +++ b/xen/drivers/vpci/msix.c > @@ -223,7 +223,7 @@ static void __iomem *get_table(const struct vpci > *vpci, unsigned int slot) > return msix->table[slot]; > } > > -unsigned int get_slot(const struct vpci *vpci, unsigned long addr) > +static unsigned int get_slot(const struct vpci *vpci, unsigned long > addr) > { > unsigned long pfn = PFN_DOWN(addr); > > -- > 2.34.1 Any chance of an ack? The maintainer for that file is Roger Pau Monné as far as I can tell. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)