From: Evgeniy Polyakov <zbr@ioremap.net>
To: David Fries <david@fries.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
GregKH <greg@kroah.com>
Subject: Re: [PATCH 16/16] hold bus_mutex in netlink and search
Date: Thu, 16 Jan 2014 00:58:02 +0400 [thread overview]
Message-ID: <8351389819482@web5j.yandex.ru> (raw)
In-Reply-To: <20140115045200.GA29560@spacedout.fries.net>
Hi
15.01.2014, 08:52, "David Fries" <David@Fries.net>:
> The bus_mutex needs to be taken to serialize access to a specific bus.
> netlink wasn't updated when bus_mutex was added and was calling
> without that lock held, and not all of the masters were holding the
> bus_mutex in a search. This was causing the ds2490 hardware to stop
> responding when both netlink and /sys slaves were executing bus
> commands at the same time.
>
> Signed-off-by: David Fries <David@Fries.net>
Looks good to me, thank you.
Greg, please pull the whole set if you hadn't yet
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
next prev parent reply other threads:[~2014-01-15 20:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-29 6:45 [PATCH 00/14] w1: async netlink, search, fixes, and improvements David Fries
2013-12-29 6:45 ` [PATCH 01/14] w1: fix w1_send_slave dropping a slave id David Fries
2013-12-29 6:45 ` [PATCH 02/14] w1: fixup search to support abort from netlink David Fries
2013-12-29 6:45 ` [PATCH 03/14] w1: Only wake up the search process if it is going to be searching David Fries
2013-12-29 6:45 ` [PATCH 04/14] w1: increase w1_max_slave_count, allow write access David Fries
2013-12-29 6:45 ` [PATCH 05/14] w1: continue slave search where previous left off David Fries
2013-12-29 6:45 ` [PATCH 06/14] w1: new netlink commands, add/remove/list slaves David Fries
2013-12-29 6:45 ` [PATCH 07/14] w1: process w1 netlink commands in w1_process thread David Fries
2013-12-29 6:45 ` [PATCH 08/14] connector: add portid to unicast in addition to broadcasting David Fries
2013-12-29 6:45 ` [PATCH 09/14] w1: reply only to the requester portid David Fries
2013-12-29 6:45 ` [PATCH 10/14] w1: ds2490 reduce magic numbers David Fries
2013-12-29 6:45 ` [PATCH 11/14] w1: ds2490 USB setup fixes David Fries
2013-12-29 6:45 ` [PATCH 12/14] w1: ds2490 fix and enable hardware search David Fries
2013-12-29 6:45 ` [PATCH 13/14] w1: use family_data instead of rom in w1_slave David Fries
2013-12-29 6:45 ` [PATCH 14/14] w1: format for DocBook and fixes David Fries
2013-12-29 21:26 ` [PATCH 00/14] w1: async netlink, search, fixes, and improvements Evgeniy Polyakov
2014-01-15 4:52 ` [PATCH 16/16] hold bus_mutex in netlink and search David Fries
2014-01-15 20:58 ` Evgeniy Polyakov [this message]
2014-01-15 21:10 ` David Fries
2014-01-16 2:33 ` GregKH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8351389819482@web5j.yandex.ru \
--to=zbr@ioremap.net \
--cc=david@fries.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.