From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13FEA1CF9C; Sat, 13 Apr 2024 07:58:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712995104; cv=none; b=KUIPxCNui+Ht6UGTtjAJjlTXc9T/lPK3R5W6IJ+2woI9JtmZcAJ/S1THEy3S6wZ7790FQ/yJnlUIXSNQ6E8tHasvxEIChrnJ59+nxG69xrEbXnpYDJI9PMbcfXtfrlIf39NTTWJUEwoFQrFmTooGGLyXw85jxwCUl+rEHnUKsxw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712995104; c=relaxed/simple; bh=rpL+lRsCc+aSI0WLSyBqKU1GVKz1bsXEqGBEH/UyoFA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OB4qSgX8sFa4sg6UpyHM7omrJxBTqcoq0vYhZVLr0tZRyyjJVoPsLGwhkm9H5aP+DObqg7vGnYsEBqi2QdEPfUY2Gwg+A1bAu7VOt9IYLlz//yPI3MbGQPRmIxt5NMKn17gGgWMrXHG9u7QqaC2dLoBjyOXQ5IR+/5Ii9gEyFFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i5e8616c3.versanet.de ([94.134.22.195] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rvYGx-0001CH-RG; Sat, 13 Apr 2024 09:58:03 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Dragan Simic , Dragan Simic Cc: linux-i2c@vger.kernel.org, Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts Date: Sat, 13 Apr 2024 09:58:02 +0200 Message-ID: <8358604.T7Z3S40VBb@diego> In-Reply-To: References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Samstag, 13. April 2024, 08:44:41 CEST schrieb Dragan Simic: > On 2024-04-13 08:38, Wolfram Sang wrote: > >> Maybe it would be good to turn it into a debug message, instead of > >> simply removing it? Maybe not all client drivers handle it correctly, > >> in which case having an easy way for debugging would be beneficial. > > > > Hmm, but it still returns -ETIMEDOUT to distinguish cases? > > Sure, but I think that having such an additional debug facility > can only help and save the people from adding temporary printk()s > while debugging. Also we're talking about two lines of code, I wouldn't call that bloat ;-) I was thinking about dev_dbg vs. removal too, but hadn't a clear favorite. So essentially Dragan is tipping the scale and I guess dev_dbg might be the nicer way to go. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 153A9C4345F for ; Sat, 13 Apr 2024 07:58:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0VX5aQ22b888p+gcpHPxPOw9rqYCI7GMQ3XnPEV4caA=; b=gT5q/Y2ITjTzR7 mu50RVTRmJozZU/vDxAigIEeLokoiZQYsSs2h+by1ebNfllrKMGw3SCxEad9tYLXW6sNXnRrSxirV GK4BajDzgx80OaYYPGyUxtQxH1cgNm92Hku+CaP+AxDZe/4kHfzKjkq1QPVKMLpIZ8YqsLJTQjMLV Zq9J6URJeHHqFE42whZDyjSlVCv3XVMSK5hhcPJGi0YIsPXcz/dNTvLzLM1cPgSJbgbn+zQZ5ZdRv WWqmv4B30yrQvrEpj+Xy4M3tP2U1UT4CMMIXmr4CjJN57itRFL2hOyZepxTOx4lzNMIpk1v/GEX8x kCc1UfExkA/fMtrqoW5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvYHB-00000002gdT-43Kd; Sat, 13 Apr 2024 07:58:18 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvYH7-00000002gbn-49ee; Sat, 13 Apr 2024 07:58:15 +0000 Received: from i5e8616c3.versanet.de ([94.134.22.195] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rvYGx-0001CH-RG; Sat, 13 Apr 2024 09:58:03 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Dragan Simic , Dragan Simic Cc: linux-i2c@vger.kernel.org, Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts Date: Sat, 13 Apr 2024 09:58:02 +0200 Message-ID: <8358604.T7Z3S40VBb@diego> In-Reply-To: References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240413_005814_064522_68865357 X-CRM114-Status: GOOD ( 14.51 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Am Samstag, 13. April 2024, 08:44:41 CEST schrieb Dragan Simic: > On 2024-04-13 08:38, Wolfram Sang wrote: > >> Maybe it would be good to turn it into a debug message, instead of > >> simply removing it? Maybe not all client drivers handle it correctly, > >> in which case having an easy way for debugging would be beneficial. > > > > Hmm, but it still returns -ETIMEDOUT to distinguish cases? > > Sure, but I think that having such an additional debug facility > can only help and save the people from adding temporary printk()s > while debugging. Also we're talking about two lines of code, I wouldn't call that bloat ;-) I was thinking about dev_dbg vs. removal too, but hadn't a clear favorite. So essentially Dragan is tipping the scale and I guess dev_dbg might be the nicer way to go. Heiko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECBA3C4345F for ; Sat, 13 Apr 2024 07:58:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xmXdMnOnjh8r01U3Cg3aD4hp4iRxrOIPhLs/U7krJCU=; b=xFwUaQ0i9TOAd4 XZUfgKCT01Q5XemlBD3Df9fPfxM3l1sR0yimMlEdSIcUWIryTDZyQbvVvuEAUcqnP97Gy230TwZg0 UkyzQXoIv4fvLsBAoNwZxwkRV/X0FcI9XVpuYjnhYLolpnSQKR9HwR0dhDxDCk8V5Ub0c8Pz8S8C8 9xOL5CDx06VZaFlRi/YjZ0k7Gac8MuQxRglmitJHfmRUFtM8s9UwzKLoi0BvcCP6XpL0pqOxcnryP SoNYK6DHNkjJzBhbwFJiUp5cMEHNVzLTgVqE58K3VlZ+mW4+nkCouaRjTTDe75mNZszvBSIuthgff Y1kjvOTPObtUWivicvng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvYHB-00000002gdL-1DvT; Sat, 13 Apr 2024 07:58:17 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvYH7-00000002gbn-49ee; Sat, 13 Apr 2024 07:58:15 +0000 Received: from i5e8616c3.versanet.de ([94.134.22.195] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rvYGx-0001CH-RG; Sat, 13 Apr 2024 09:58:03 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Dragan Simic , Dragan Simic Cc: linux-i2c@vger.kernel.org, Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts Date: Sat, 13 Apr 2024 09:58:02 +0200 Message-ID: <8358604.T7Z3S40VBb@diego> In-Reply-To: References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240413_005814_064522_68865357 X-CRM114-Status: GOOD ( 14.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Samstag, 13. April 2024, 08:44:41 CEST schrieb Dragan Simic: > On 2024-04-13 08:38, Wolfram Sang wrote: > >> Maybe it would be good to turn it into a debug message, instead of > >> simply removing it? Maybe not all client drivers handle it correctly, > >> in which case having an easy way for debugging would be beneficial. > > > > Hmm, but it still returns -ETIMEDOUT to distinguish cases? > > Sure, but I think that having such an additional debug facility > can only help and save the people from adding temporary printk()s > while debugging. Also we're talking about two lines of code, I wouldn't call that bloat ;-) I was thinking about dev_dbg vs. removal too, but hadn't a clear favorite. So essentially Dragan is tipping the scale and I guess dev_dbg might be the nicer way to go. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel