From: Krzysztof Kozlowski <krzk@kernel.org>
To: Luca Weiss <luca.weiss@fairphone.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: milos: Add IMEM node
Date: Wed, 8 Apr 2026 10:36:34 +0200 [thread overview]
Message-ID: <8371586c-71f8-403e-b1a4-7a960a706830@kernel.org> (raw)
In-Reply-To: <DHNMDZ7M0BVS.36Z923XKNXPEC@fairphone.com>
On 08/04/2026 10:11, Luca Weiss wrote:
>>> };
>>>
>>> + sram@14680000 {
>>> + compatible = "qcom,milos-imem", "mmio-sram";
>>> + reg = <0x0 0x14680000 0x0 0x2c000>;
>>> + ranges = <0 0 0x14680000 0x2c000>;
>>
>> Use hex here as well.
>
> Will do: ranges = <0x0 0x0 0x14680000 0x2c000>;
>
> Do you also have a comment around the name of the subnodes? Do you think
> they're okay as-is, or should they be changed?
I think they follow what the binding expects, so not much to discuss here :)
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-08 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 15:11 [PATCH v2 0/2] Describe IMEM on Milos Luca Weiss
2026-04-07 15:11 ` [PATCH v2 1/2] dt-bindings: sram: Document qcom,milos-imem Luca Weiss
2026-04-08 7:33 ` Krzysztof Kozlowski
2026-04-07 15:11 ` [PATCH v2 2/2] arm64: dts: qcom: milos: Add IMEM node Luca Weiss
2026-04-08 7:34 ` Krzysztof Kozlowski
2026-04-08 8:11 ` Luca Weiss
2026-04-08 8:36 ` Krzysztof Kozlowski [this message]
2026-04-08 13:26 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8371586c-71f8-403e-b1a4-7a960a706830@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.