Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915/pm_rc6_residency: Modify rc6_fence to use intel_ctx_t from igt_fixture

["Gupta, Anshuman" <anshuman.gupta@intel.com>]

> -----Original Message-----
> From: Tauro, Riana <riana.tauro@intel.com>
> Sent: Tuesday, June 21, 2022 3:36 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Tauro, Riana <riana.tauro@intel.com>; Gupta, Anshuman
> <anshuman.gupta@intel.com>; Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Subject: [PATCH i-g-t 2/2] tests/i915/pm_rc6_residency: Modify rc6_fence to
> use intel_ctx_t from igt_fixture
> 
> Modify rc6_fence test to use intel_ctx_t from igt_fixture
Commit message can be more descriptive , this should be non-functional patch.
We are not doing any functional change to patch.
Also this should be the first patch of the series,
which create and destroy the context in igt_fixture and rc6_fences will use the same ctx,
Followed by second patch.
Regards,
Anshuman Gupta.
> 
> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> ---
>  tests/i915/i915_pm_rc6_residency.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/i915/i915_pm_rc6_residency.c
> b/tests/i915/i915_pm_rc6_residency.c
> index 560b635f..043370cc 100644
> --- a/tests/i915/i915_pm_rc6_residency.c
> +++ b/tests/i915/i915_pm_rc6_residency.c
> @@ -450,13 +450,12 @@ static void rc6_idle(int i915, uint64_t flags)
>  	}
>  }
> 
> -static void rc6_fence(int i915)
> +static void rc6_fence(int i915, const intel_ctx_t *ctx)
>  {
>  	const int64_t duration_ns = SLEEP_DURATION *
> (int64_t)NSEC_PER_SEC;
>  	const int tolerance = 20; /* Some RC6 is better than none! */
>  	const unsigned int gen = intel_gen(intel_get_drm_devid(i915));
>  	const struct intel_execution_engine2 *e;
> -	const intel_ctx_t *ctx;
>  	struct power_sample sample[2];
>  	unsigned long slept;
>  	uint64_t rc6, ts[2], ahnd;
> @@ -486,7 +485,6 @@ static void rc6_fence(int i915)
>  	assert_within_epsilon(rc6, ts[1] - ts[0], 5);
> 
>  	/* Submit but delay execution, we should be idle and conserving power
> */
> -	ctx = intel_ctx_create_all_physical(i915);
>  	ahnd = get_reloc_ahnd(i915, ctx->id);
>  	for_each_ctx_engine(i915, ctx, e) {
>  		igt_spin_t *spin;
> @@ -525,7 +523,6 @@ static void rc6_fence(int i915)
>  		assert_within_epsilon(rc6, ts[1] - ts[0], tolerance);
>  		gem_quiescent_gpu(i915);
>  	}
> -	intel_ctx_destroy(i915, ctx);
>  	put_ahnd(ahnd);
> 
>  	rapl_close(&rapl);
> @@ -560,7 +557,7 @@ igt_main
>  		igt_require_gem(i915);
>  		gem_quiescent_gpu(i915);
> 
> -		rc6_fence(i915);
> +		rc6_fence(i915, ctx);
>  	}
> 
>  	igt_subtest_group {
> --
> 2.25.1