Re: [PATCH 8/9] btrfs: convert zoned.c to use map->stripe_len

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2026/10/20 21:37, Johannes Thumshirn 写道:
> On 19.10.26 08:40, Qu Wenruo wrote:
>> -        if (zone_info[i].alloc_offset & BTRFS_STRIPE_LEN_MASK)
>> +        if (zone_info[i].alloc_offset & (stripe_len - 1))
>>               break;
> 
> I think this would be a good opportunity for using IS_ALIGNED() here.

That's a good idea, I'll also update similar callsites in the series.

> 
>>       }
>>       stripe_nr = 0;
>> @@ -1619,8 +1621,8 @@ static int btrfs_load_block_group_raid0(struct 
>> btrfs_block_group *bg,
>>       if (last_alloc) {
>>           u32 factor = map->num_stripes;
>> -        stripe_nr = last_alloc >> BTRFS_STRIPE_LEN_SHIFT;
>> -        stripe_offset = last_alloc & BTRFS_STRIPE_LEN_MASK;
>> +        stripe_nr = last_alloc >> stripe_shift;
>> +        stripe_offset = last_alloc & (stripe_len - 1);
>>
> And ALIGN()?

ALIGN() is round_up(), which doesn't seem to fit here.

And considering IS_ALIGNED() is also using "(a) - 1" as the mask, I 
don't think there is a better way to generate a mask.

Thanks,
Qu