From: gang.yan@linux.dev
To: "Paolo Abeni" <pabeni@redhat.com>, mptcp@lists.linux.dev
Cc: "Geliang Tang" <geliang@kernel.org>
Subject: Re: [PATCH v6 mptcp-next 0/7] mptcp: address stall under memory pressure
Date: Tue, 19 May 2026 08:50:42 +0000 [thread overview]
Message-ID: <83a3de2bffbecbad544544e77019cbae1ebd913f@linux.dev> (raw)
In-Reply-To: <7f816ee8-6119-47ff-a10d-bbfa61a24e6a@redhat.com>
May 19, 2026 at 12:30 AM, "Paolo Abeni" <pabeni@redhat.com mailto:pabeni@redhat.com?to=%22Paolo%20Abeni%22%20%3Cpabeni%40redhat.com%3E > wrote:
>
> On 5/18/26 10:13 AM, gang.yan@linux.dev wrote:
>
> >
> > May 15, 2026 at 5:29 PM, "Paolo Abeni" <pabeni@redhat.com mailto:pabeni@redhat.com?to=%22Paolo%20Abeni%22%20%3Cpabeni%40redhat.com%3E > wrote:
> >
> > >
> > > On 5/15/26 11:07 AM, Paolo Abeni wrote:
> > >
> > This an attempt to fix the data transfer stall reported by Geliang and
> > Gang more carefully enforcing memory constraints at the MPTCP level.
> >
> > This iteration presents a significant change WRT the previous one,
> > avoiding entirely the collapse attempt on memory pressure. Note that
> > this choice represent a trade off: collapsing allow much faster transfer
> > (to be more accurate: order of magnitude less slow) under some extreme
> > conditions, but makes transfer slower and much more CPU intensive for
> > less unlikely conditions.
> >
> > As a consequence of the above the `mptcp_data.multi_chunk_sendfile`
> > test-case needs a 240 seconds timeout to complete successfully:
> >
> > TEST_F_TIMEOUT(mptcp, multi_chunk_sendfile, 240)
> >
> > The solution performing data collapsing would need similar long timeout
> > for the multiproc tests cases: mutliproc_even, mutliproc_readers,
> > mutliproc_writers, mutliproc_sendpage_even, mutliproc_sendpage_readers,
> > mutliproc_sendpage_writers.
> >
> > Patch 1 is new in v6, and is actually a fix for an old issue (targeting
> > net), included here just for my convenience.
> >
> > Patch 2 and 3 makes the admission check much more strict for incoming
> > packets exceeding the memory limits, with some exception for fallback
> > sockets.
> > Patch 4 makes implement OoO queue pruning for MPTCP and patch 5
> > addresses an edge scenario that could still lead to transfer stall
> > under memory pressure.
> > Finally patch 6 and 7 improve the MPTCP-level retransmission schema to
> > make recovery from memory pressure/after MPTCP-level drop significanly
> > faster.
> >
> > >
> > > @Geliang, @Gang: could you please have a spin at this iteration? Note
> > > that you must increase the timeout for the
> > > mptcp_data.multi_chunk_sendfile test-case, as mentioned above.
> > >
> > Hi Paolo,
> >
> > Thanks a lot for the new patch set. We have encountered some issues during
> > our testing. It will take us some time to analyze and locate the root cause.
> > We will post updates on the mailing list as soon as we make progress.
> >
> I run a few hundred iterations of the mptcp_data test without observing
> any issue (still running). Can you please share which issue are you
> observing, the relevant tests case and the build type (debug/non debug)?
>
> Thanks,
>
Hi Paolo,
Sorry for not providing the specific details earlier in my first message.
The issue we are seeing occurs specifically when KTLS is enabled.
Today I ran several sets of comparative tests (many hundreds iterations), and the
current results suggest that the integration framework between KTLS and MPTCP
may need some adjustments. We are investigating the root cause.
Thanks for your help.
Cherrs,
Gang
> Paolo
>
next prev parent reply other threads:[~2026-05-19 8:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 9:07 [PATCH v6 mptcp-next 0/7] mptcp: address stall under memory pressure Paolo Abeni
2026-05-15 9:07 ` [PATCH v6 mptcp-next 1/7] mptcp: fix missing wakeups in edge scenarios Paolo Abeni
2026-05-15 9:07 ` [PATCH v6 mptcp-next 2/7] mptcp: explicitly drop over memory limits Paolo Abeni
2026-05-15 9:07 ` [PATCH v6 mptcp-next 3/7] mptcp: enforce hard limit on backlog flushing Paolo Abeni
2026-05-15 9:07 ` [PATCH v6 mptcp-next 4/7] mptcp: implemented OoO queue pruning Paolo Abeni
2026-05-15 9:07 ` [PATCH v6 mptcp-next 5/7] mptcp: track prune recovery status Paolo Abeni
2026-05-15 9:07 ` [PATCH v6 mptcp-next 6/7] mptcp: move the retrans loop to a separate helper Paolo Abeni
2026-05-15 9:07 ` [PATCH v6 mptcp-next 7/7] mptcp: let the retrans scheduler do its job Paolo Abeni
2026-05-15 9:29 ` [PATCH v6 mptcp-next 0/7] mptcp: address stall under memory pressure Paolo Abeni
2026-05-18 8:13 ` gang.yan
2026-05-18 16:30 ` Paolo Abeni
2026-05-19 8:50 ` gang.yan [this message]
2026-05-19 16:18 ` Paolo Abeni
2026-05-15 10:35 ` MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a3de2bffbecbad544544e77019cbae1ebd913f@linux.dev \
--to=gang.yan@linux.dev \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.