From: Derrick Stolee <derrickstolee@github.com>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] tests(scalar): tighten the stale `scalar.repo` test some
Date: Thu, 10 Nov 2022 08:56:41 -0500 [thread overview]
Message-ID: <83b9ff0b-a655-714e-a8f9-44b0d1ac3177@github.com> (raw)
In-Reply-To: <pull.1415.git.1668065327120.gitgitgadget@gmail.com>
On 11/10/2022 2:28 AM, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> As pointed out by Stolee, the previous incarnation of this test case was
> not stringent enough: we want to verify that _only_ the stale entries
> are removed (previously, the test case would have succeeded even if all
> entries had been removed).
Thanks for tightening the test!
LGTM.
-Stolee
next prev parent reply other threads:[~2022-11-10 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 7:28 [PATCH] tests(scalar): tighten the stale `scalar.repo` test some Johannes Schindelin via GitGitGadget
2022-11-10 13:56 ` Derrick Stolee [this message]
2022-11-11 22:25 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83b9ff0b-a655-714e-a8f9-44b0d1ac3177@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.