From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E39ACC4345F for ; Wed, 24 Apr 2024 10:07:12 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.711307.1111181 (Exim 4.92) (envelope-from ) id 1rzZWo-00017Z-T0; Wed, 24 Apr 2024 10:07:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 711307.1111181; Wed, 24 Apr 2024 10:07:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rzZWo-00017S-Pm; Wed, 24 Apr 2024 10:07:02 +0000 Received: by outflank-mailman (input) for mailman id 711307; Wed, 24 Apr 2024 10:07:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rzZWn-00086f-Pj for xen-devel@lists.xenproject.org; Wed, 24 Apr 2024 10:07:01 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 64657aec-0222-11ef-909a-e314d9c70b13; Wed, 24 Apr 2024 12:07:01 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 6A5114EE0739; Wed, 24 Apr 2024 12:07:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64657aec-0222-11ef-909a-e314d9c70b13 MIME-Version: 1.0 Date: Wed, 24 Apr 2024 12:07:00 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Volodymyr Babchuk , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 04/10] drivers: char: address violation of MISRA C Rule 20.7 In-Reply-To: <509a6c09-85e7-4854-b7dc-116cde022b26@suse.com> References: <509a6c09-85e7-4854-b7dc-116cde022b26@suse.com> Message-ID: <83c180d692149d5cf0f56fecdc3af4b3@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2024-04-24 09:23, Jan Beulich wrote: > On 23.04.2024 17:12, Nicola Vetrini wrote: >> --- a/xen/drivers/char/omap-uart.c >> +++ b/xen/drivers/char/omap-uart.c >> @@ -48,8 +48,9 @@ >> /* System configuration register */ >> #define UART_OMAP_SYSC_DEF_CONF 0x0d /* autoidle mode, wakeup is >> enabled */ >> >> -#define omap_read(uart, off) readl((uart)->regs + >> (off<> -#define omap_write(uart, off, val) writel((val), (uart)->regs + >> (off<> +#define omap_read(uart, off) readl((uart)->regs + ((off) << >> REG_SHIFT)) >> +#define omap_write(uart, off, val) writel((val), (uart)->regs + \ > > Would have been nice to drop the excess parentheses at the same time. > > Jan Right. I think I'll have a few more patches on this rule, so maybe I can adjust it. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)