From: Dave Hansen <dave.hansen@intel.com>
To: Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-hwmon@vger.kernel.org, linux-pm@vger.kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [PATCH v2 07/10] x86/msr: Switch rdmsr_safe_on_cpu() users to rdmsrq_safe_on_cpu()
Date: Fri, 5 Jun 2026 08:04:46 -0700 [thread overview]
Message-ID: <83c7e899-2ba7-435f-8ea8-7e893c9f207f@intel.com> (raw)
In-Reply-To: <20260605144314.3031049-8-jgross@suse.com>
On 6/5/26 07:43, Juergen Gross wrote:
> In order to prepare retiring rdmsr_safe_on_cpu() switch
> rdmsr_safe_on_cpu() users to rdmsrq_safe_on_cpu().
This needs a better changelog. This isn't just some kind of mechanical
replacement. It copies rdmsr_safe_on_cpu()'s implementation into
rdmsr<Q>_safe_on_cpu(). Yes, it's temporary and the next patch
effectively undoes it.
But it's exactly the kind of thing a reviewer should be told in a changelog.
Oh, and considering the size of the changelog at the moment, I think
there's room. ;)
next prev parent reply other threads:[~2026-06-05 15:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 14:43 [PATCH v2 00/10] x86/msr: Drop 32-bit variants of *_on_cpu() MSR functions Juergen Gross
2026-06-05 14:43 ` [PATCH v2 01/10] x86/msr: Switch rdmsrl_on_cpu() users to rdmsrq_on_cpu() Juergen Gross
2026-06-05 14:43 ` [PATCH v2 02/10] x86/msr: Remove rdmsrl_on_cpu() Juergen Gross
2026-06-05 14:43 ` [PATCH v2 03/10] x86/msr: Switch rdmsr_on_cpu() users to rdmsrq_on_cpu() Juergen Gross
2026-06-05 14:43 ` [PATCH v2 04/10] x86/msr: Remove rdmsr_on_cpu() Juergen Gross
2026-06-05 14:43 ` [PATCH v2 05/10] x86/msr: Switch wrmsr_on_cpu() users to wrmsrq_on_cpu() Juergen Gross
2026-06-05 14:43 ` [PATCH v2 06/10] x86/msr: Remove wrmsr_on_cpu() Juergen Gross
2026-06-05 14:43 ` [PATCH v2 07/10] x86/msr: Switch rdmsr_safe_on_cpu() users to rdmsrq_safe_on_cpu() Juergen Gross
2026-06-05 15:04 ` Dave Hansen [this message]
2026-06-06 9:51 ` Ingo Molnar
2026-06-05 14:43 ` [PATCH v2 08/10] x86/msr: Remove rdmsr_safe_on_cpu() Juergen Gross
2026-06-05 15:05 ` Dave Hansen
2026-06-05 14:43 ` [PATCH v2 09/10] x86/msr: Switch wrmsr_safe_on_cpu() users to wrmsrq_safe_on_cpu() Juergen Gross
2026-06-05 14:43 ` [PATCH v2 10/10] x86/msr: Remove wrmsr_safe_on_cpu() Juergen Gross
2026-06-05 15:08 ` [PATCH v2 00/10] x86/msr: Drop 32-bit variants of *_on_cpu() MSR functions Dave Hansen
2026-06-05 15:09 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83c7e899-2ba7-435f-8ea8-7e893c9f207f@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=daniel.lezcano@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lukasz.luba@arm.com \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.