From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 4/4] loop: take the file system minimum dio alignment into account
Date: Tue, 4 Feb 2025 10:01:03 +0900 [thread overview]
Message-ID: <83e10a67-3f1e-4433-8f3e-8cb008592710@kernel.org> (raw)
In-Reply-To: <20250131120120.1315125-5-hch@lst.de>
On 1/31/25 21:00, Christoph Hellwig wrote:
> The loop driver currently uses the logical block size of the underlying
> bdev as the lower bound of the loop device block size. While this works
> for many cases, it fails for file systems made up of multiple devices
> with different logic block size (e.g. XFS with a RT device that has a
Nit: s/logic block size/logical block sizes
> larger logical block size), or when the file systems doesn't support
> direct I/O writes at the sector size granularity (e.g. because it does
> out of place writes with a file system block size larger than the sector
> size).
>
> Fix this by querying the minimum direct I/O alignment from statx when
> available.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Other than that, looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-02-04 1:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 12:00 loop: take the file system minimum dio alignment into account v2 Christoph Hellwig
2025-01-31 12:00 ` [PATCH 1/4] loop: factor out a loop_assign_backing_file helper Christoph Hellwig
2025-02-04 0:55 ` Damien Le Moal
2025-01-31 12:00 ` [PATCH 2/4] loop: set LO_FLAGS_DIRECT_IO in loop_assign_backing_file Christoph Hellwig
2025-02-04 0:55 ` Damien Le Moal
2025-01-31 12:00 ` [PATCH 3/4] loop: check in LO_FLAGS_DIRECT_IO in loop_default_blocksize Christoph Hellwig
2025-02-04 0:56 ` Damien Le Moal
2025-01-31 12:00 ` [PATCH 4/4] loop: take the file system minimum dio alignment into account Christoph Hellwig
2025-02-04 1:01 ` Damien Le Moal [this message]
2025-02-24 23:01 ` loop: take the file system minimum dio alignment into account v2 Christoph Hellwig
2025-02-24 23:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83e10a67-3f1e-4433-8f3e-8cb008592710@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.