From: Bart Van Assche <bvanassche@acm.org>
To: Adrian Hunter <adrian.hunter@intel.com>,
Martin K Petersen <martin.petersen@oracle.com>
Cc: James EJ Bottomley <James.Bottomley@HansenPartnership.com>,
Avri Altman <avri.altman@sandisk.com>,
Archana Patni <archana.patni@intel.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/3] scsi: ufs: ufs-pci: Fix default runtime and system PM levels
Date: Mon, 7 Jul 2025 12:57:01 -0700 [thread overview]
Message-ID: <83eb436e-a76e-472b-9d50-c6db52b399d2@acm.org> (raw)
In-Reply-To: <20250703064322.46679-3-adrian.hunter@intel.com>
On 7/2/25 11:43 PM, Adrian Hunter wrote:
> static int ufs_intel_mtl_init(struct ufs_hba *hba)
> {
> + struct ufs_host *ufs_host;
> + int err;
> +
> hba->caps |= UFSHCD_CAP_CRYPTO | UFSHCD_CAP_WB_EN;
> - return ufs_intel_common_init(hba);
> + err = ufs_intel_common_init(hba);
> + ufs_host = ufshcd_get_variant(hba);
> + ufs_host->late_init = ufs_intel_mtl_late_init;
> + return err;
> }
Shouldn't the ufs_host declaration and assignment be combined as
follows?
struct ufs_host *ufs_host = ufshcd_get_variant(hba);
Otherwise this patch looks good to me.
Thanks,
Bart.
next prev parent reply other threads:[~2025-07-07 19:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 6:43 [PATCH 0/3] scsi: ufs: ufs-pci: Fix hibernate state transition for Intel MTL-like host controllers Adrian Hunter
2025-07-03 6:43 ` [PATCH 1/3] " Adrian Hunter
2025-07-07 19:51 ` Bart Van Assche
2025-07-22 9:27 ` Adrian Hunter
2025-07-22 15:20 ` Bart Van Assche
2025-07-03 6:43 ` [PATCH 2/3] scsi: ufs: ufs-pci: Fix default runtime and system PM levels Adrian Hunter
2025-07-07 19:57 ` Bart Van Assche [this message]
2025-07-08 16:47 ` Adrian Hunter
2025-07-03 6:43 ` [PATCH 3/3] scsi: ufs: ufs-pci: Remove UFS PCI driver's ->late_init() call back Adrian Hunter
2025-07-07 19:58 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eb436e-a76e-472b-9d50-c6db52b399d2@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=archana.patni@intel.com \
--cc=avri.altman@sandisk.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.